[{"id":32643,"web_url":"https://patchwork.libcamera.org/comment/32643/","msgid":"<20241209234526.GE26531@pendragon.ideasonboard.com>","date":"2024-12-09T23:45:26","subject":"Re: [libcamera-ci] [PATCH v2] Enable `cpp_debugstl`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Dec 09, 2024 at 06:11:28PM +0100, Barnabás Pőcze wrote:\n> Meson's `cpp_debugstl` built-in option enables extra checks\n> in libstdc++ and libc++, such as iterator invalidation tests,\n> bounds checking in the `operator[]` of multiple types, etc.\n> by setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> \n> Enable it in the same cases ASan is enabled as they are\n> somewhat similar debugging tools.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1326230\n> \n> Changes in v2:\n> * do not rebuild containers\n> * note that it is enabled when ASan is enabled\n> ---\n> gitlab-ci.yml | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index ea038ec..c78235e 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -15,6 +15,7 @@ variables:\n> -D android=enabled\n> -D b_sanitize=address\n> -D cam=enabled\n> + -D cpp_debugstl=true\n> -D documentation=enabled\n> -D gstreamer=enabled\n> -D lc-compliance=enabled\n> @@ -389,6 +390,7 @@ test-unit:\n> MESON_OPTIONS: >-\n> -D b_sanitize=address\n> -D cam=disabled\n> + -D cpp_debugstl=true\n> -D documentation=disabled\n> -D gstreamer=enabled\n> -D lc-compliance=disabled","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E0B0BD80A\n\tfor ;\n\tMon, 9 Dec 2024 23:45:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8794667E77;\n\tTue, 10 Dec 2024 00:45:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0A0A6612F\n\tfor ;\n\tTue, 10 Dec 2024 00:45:41 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A18616EC;\n\tTue, 10 Dec 2024 00:45:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oRNDBxpX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733787909;\n\tbh=f/1ANTnHNP/Y7NvJWt1PosTrgoQnQVWdU6TNrfBwvBU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oRNDBxpXNkS8pOtOVPTtG8pvn/WQpuPRmRV3yN/gKtjHDlMV3B2w7dsxHwaZrlbiS\n\tzbg/BjUJSJKbx8gLWtsUsVNRecPj/Llg3joxXbIG8Ja6KknVUHUDc2CO9+q3xMpCwa\n\tc8wGWBsH20RjhyrH4Io7HfUUEhcy0IiwZFqljAM8=","Date":"Tue, 10 Dec 2024 01:45:26 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-ci] [PATCH v2] Enable `cpp_debugstl`","Message-ID":"<20241209234526.GE26531@pendragon.ideasonboard.com>","References":"<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32652,"web_url":"https://patchwork.libcamera.org/comment/32652/","msgid":"<173382545087.2486563.8996195906459978025@ping.linuxembedded.co.uk>","date":"2024-12-10T10:10:50","subject":"Re: [libcamera-ci] [PATCH v2] Enable `cpp_debugstl`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-12-09 17:11:28)\n> Meson's `cpp_debugstl` built-in option enables extra checks\n> in libstdc++ and libc++, such as iterator invalidation tests,\n> bounds checking in the `operator[]` of multiple types, etc.\n> by setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> \n> Enable it in the same cases ASan is enabled as they are\n> somewhat similar debugging tools.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1326230\n> \n> Changes in v2:\n> * do not rebuild containers\n> * note that it is enabled when ASan is enabled\n\nSounds good to me.\n\n\nAcked-by: Kieran Bingham \n\n> ---\n> gitlab-ci.yml | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index ea038ec..c78235e 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -15,6 +15,7 @@ variables:\n> -D android=enabled\n> -D b_sanitize=address\n> -D cam=enabled\n> + -D cpp_debugstl=true\n> -D documentation=enabled\n> -D gstreamer=enabled\n> -D lc-compliance=enabled\n> @@ -389,6 +390,7 @@ test-unit:\n> MESON_OPTIONS: >-\n> -D b_sanitize=address\n> -D cam=disabled\n> + -D cpp_debugstl=true\n> -D documentation=disabled\n> -D gstreamer=enabled\n> -D lc-compliance=disabled\n> --\n> 2.47.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B550C3257\n\tfor ;\n\tTue, 10 Dec 2024 10:10:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B5E867E81;\n\tTue, 10 Dec 2024 11:10:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA273608B6\n\tfor ;\n\tTue, 10 Dec 2024 11:10:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FA3A6EC;\n\tTue, 10 Dec 2024 11:10:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nL0K+dS6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733825421;\n\tbh=JuAQVH6Pvvlf7aj1QuN32fibjQ/6VEIuqJFD0K+na6s=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=nL0K+dS6h9QiQuGhU8Guom56ouIXbNNBplFmcaoxUdvTGhekE6VMDAUTcCIWUgUq+\n\tOUzgEwXkUNgU0wR1FEvdwIUE2J2jbvSy4vKuZwVopP7znbXHxQpP9amN+A4iglk+vT\n\tiTwllzQN/NFOjQFqvehuYAKMW4YXkkOH4DhSde9E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>","References":"<20241209171128.270901-1-barnabas.pocze@ideasonboard.com>","Subject":"Re: [libcamera-ci] [PATCH v2] Enable `cpp_debugstl`","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 10 Dec 2024 10:10:50 +0000","Message-ID":"<173382545087.2486563.8996195906459978025@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]