[{"id":32631,"web_url":"https://patchwork.libcamera.org/comment/32631/","msgid":"<20241209105243.GF11343@pendragon.ideasonboard.com>","date":"2024-12-09T10:52:43","subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Dec 09, 2024 at 10:47:23AM +0000, Naushir Patuck wrote:\n> The frameIntegrationDiff value should be 25, otherwise we see invalid\n> frames when integration times are set to large values.\n> \n> Signed-off-by: Naushir Patuck \n\nI'll trust you on that.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> index a65c8ac08c1c..96f7fff499f5 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> @@ -25,7 +25,7 @@ private:\n> \t * Smallest difference between the frame length and integration time,\n> \t * in units of lines.\n> \t */\n> -\tstatic constexpr int frameIntegrationDiff = 4;\n> +\tstatic constexpr int frameIntegrationDiff = 25;\n> };\n> \n> /*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DFF7BE080\n\tfor ;\n\tMon, 9 Dec 2024 10:53:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FD6B67E61;\n\tMon, 9 Dec 2024 11:53:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23F5C618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:52:59 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BE6A89A;\n\tMon, 9 Dec 2024 11:52:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EauHrSci\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733741547;\n\tbh=ab4nvlns7pHZacH8RkQF4xAEPDc3iuKFgiodBC1uUQk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EauHrSciP8bIApnjKfFOdSemz3h1QlkmJ3x8tGSvtxqqNHjNIrlTt+xeLSpVe5xcS\n\tUdZtnBfldNakQndnyfC6KhLgH1fzXZgvW1hTAUiz1DuNQ+iETIans33kYYrCz4ANwf\n\tfU57agpUmJSFRGMNrp/rllfwAekOqW/xRVvJsXvA=","Date":"Mon, 9 Dec 2024 12:52:43 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org, dave.stevenson@raspberrypi.com","Subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","Message-ID":"<20241209105243.GF11343@pendragon.ideasonboard.com>","References":"<20241209104727.520859-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241209104727.520859-1-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32632,"web_url":"https://patchwork.libcamera.org/comment/32632/","msgid":"","date":"2024-12-09T10:52:59","subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"Thanks Naush\n\nOn Mon, 9 Dec 2024 at 10:47, Naushir Patuck wrote:\n>\n> The frameIntegrationDiff value should be 25, otherwise we see invalid\n> frames when integration times are set to large values.\n>\n> Signed-off-by: Naushir Patuck \n\nTested-by: Dave Stevenson \n\nI'm sorting a patch for the kernel driver too, as that has\nOV9282_EXPOSURE_OFFSET set to 12.\n\n Dave\n\n> ---\n> src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> index a65c8ac08c1c..96f7fff499f5 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> @@ -25,7 +25,7 @@ private:\n> * Smallest difference between the frame length and integration time,\n> * in units of lines.\n> */\n> - static constexpr int frameIntegrationDiff = 4;\n> + static constexpr int frameIntegrationDiff = 25;\n> };\n>\n> /*\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F41FDBE080\n\tfor ;\n\tMon, 9 Dec 2024 10:53:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A27F667E65;\n\tMon, 9 Dec 2024 11:53:23 +0100 (CET)","from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com\n\t[IPv6:2607:f8b0:4864:20::112f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D57467E5F\n\tfor ;\n\tMon, 9 Dec 2024 11:53:21 +0100 (CET)","by mail-yw1-x112f.google.com with SMTP id\n\t00721157ae682-6ef60e500d7so26131087b3.0\n\tfor ;\n\tMon, 09 Dec 2024 02:53:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pLni0kXy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733741600; x=1734346400;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=FF7+EJ682Pw3K5icVdsANEw85KoS8TZrXUMR1lQChTY=;\n\tb=pLni0kXyZyD8SaWNKbL5wp/bEyR1BLR9Q9W2+sHnAN0qtzu/UGhUAzdrS4L+dHJcOb\n\tjIffYykAlae8UQKt2pB6pirxn51AeA3Y0J7SUuPfZI98zq+vx+Er7epFMxEt86MlVlsa\n\taiPjs0Djllh8Gufp7j8LNeLC8qHbkprISW1fJH1kBJqM4fV6BPvYHVgkLv2uF+Uz9uXg\n\t+YG3f1fMPgldVqJphTTIgmbTXPccZu3ro7s8Nn5enie8bMRWlzUmmJCFB6Mx/xLbTTsI\n\tiHi83VpQd7Ws6mewnCkwEgvLGxka+KZFv6yZGGGvpfFqAHgNv65DJQZp2MIZZ+DotXOT\n\tG9KQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733741600; x=1734346400;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=FF7+EJ682Pw3K5icVdsANEw85KoS8TZrXUMR1lQChTY=;\n\tb=OL1oQGDxY4CC1rNclHL7vcGLjv24XFAQgVcEhPquGno1M9kTKk8jwR2GVB4AZ3TWCy\n\t54rr7+8XXlefhSbG8gpgfRiRhXi1ti2BWvYznU0rsTFw8HwoLHAuLQk4w34Siwkbe0ra\n\tVgMSsXif+OnuWUA4JyXxPDhM3MOopxaftK8sM4kiwekSiaK/J9gHQDOWuPXSqwcxmGja\n\tw+i29IrC/+svs2NKw+P8RWAQn5KHnqvKTrIzUwg+zqel9mEgjiV7tAsKkBn+1rPUSpLk\n\tWCd+ekO2/5loUdniw9fZ4MSLHFt5L+ogWRZ3+/4Ke8u64ZA40u792LQlwYgwWoTar00i\n\t3cPQ==","X-Gm-Message-State":"AOJu0YwrHQVdmRZbH70UK62L+IzcsTP70DxkMpbrBOEpvjS1hPgDUTkN\n\tGpXqc7jB3vKvo1f2nMogvBEc7LLXT8P0XylyUvQYdkGyhzSO6lBlOe2W0VmVG5HgLp3mX+JFPYV\n\tBLjedNA9qfC7zgs7OmqVvMBk1mo0hXo5Fb+guUA==","X-Gm-Gg":"ASbGncssBrHP28aixUMqwcpyZbINeIuFAtGmIf1QxDbhOFhbGhhHxQE1p91x1ruC67a\n\t7dtPJn8me+uI4pEH/5KA12/3no/ZBxXQ=","X-Google-Smtp-Source":"AGHT+IE07nOZmSloiUsaW8xnxrqjETchlbXBQEQuWX6f2o14rioSQl5dK/zJO3lGf/FQ/jgRXpNZbFB/jzkcBXQiGJU=","X-Received":"by 2002:a05:690c:7245:b0:6ef:652b:91cf with SMTP id\n\t00721157ae682-6efe3c605demr89215777b3.27.1733741600226;\n\tMon, 09 Dec 2024 02:53:20 -0800 (PST)","MIME-Version":"1.0","References":"<20241209104727.520859-1-naush@raspberrypi.com>","In-Reply-To":"<20241209104727.520859-1-naush@raspberrypi.com>","From":"Dave Stevenson ","Date":"Mon, 9 Dec 2024 10:52:59 +0000","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32633,"web_url":"https://patchwork.libcamera.org/comment/32633/","msgid":"<20241209105504.GG11343@pendragon.ideasonboard.com>","date":"2024-12-09T10:55:04","subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 09, 2024 at 10:52:59AM +0000, Dave Stevenson wrote:\n> On Mon, 9 Dec 2024 at 10:47, Naushir Patuck wrote:\n> >\n> > The frameIntegrationDiff value should be 25, otherwise we see invalid\n> > frames when integration times are set to large values.\n> >\n> > Signed-off-by: Naushir Patuck \n> \n> Tested-by: Dave Stevenson \n> \n> I'm sorting a patch for the kernel driver too, as that has\n> OV9282_EXPOSURE_OFFSET set to 12.\n\nThis makes me wish we had a centralized database for such information.\nIdeally populated by camera sensor vendors. I know, I'm a dreamer :-)\n\n> > ---\n> > src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > index a65c8ac08c1c..96f7fff499f5 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > @@ -25,7 +25,7 @@ private:\n> > * Smallest difference between the frame length and integration time,\n> > * in units of lines.\n> > */\n> > - static constexpr int frameIntegrationDiff = 4;\n> > + static constexpr int frameIntegrationDiff = 25;\n> > };\n> >\n> > /*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0843BD80A\n\tfor ;\n\tMon, 9 Dec 2024 10:55:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A849E67E67;\n\tMon, 9 Dec 2024 11:55:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BBED9618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:55:20 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A53E89A;\n\tMon, 9 Dec 2024 11:54:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r7rFv8zv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733741689;\n\tbh=gFZsvrrXlLnMz8Lu7pVY/CG4oGwSC5AjvyAwEyQ3tM0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r7rFv8zvd89GgOFvoJA9U8/CNjefJ0txT+fovAaVx9w53PvnF/KC48HpJ25yu0zgH\n\txxxEF5g2PwUiRH0xzOpWEDV6PHlHPaSBmJj6WHi2s3w448ALFj/ZzOBInNOwDMXdk3\n\tbZIv0c6lHS7ERq+qX8lNbEx54D0CnjTUQmSE7ZfY=","Date":"Mon, 9 Dec 2024 12:55:04 +0200","From":"Laurent Pinchart ","To":"Dave Stevenson ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","Message-ID":"<20241209105504.GG11343@pendragon.ideasonboard.com>","References":"<20241209104727.520859-1-naush@raspberrypi.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32636,"web_url":"https://patchwork.libcamera.org/comment/32636/","msgid":"<173374898180.812633.9243186600949358834@ping.linuxembedded.co.uk>","date":"2024-12-09T12:56:21","subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-12-09 10:47:23)\n> The frameIntegrationDiff value should be 25, otherwise we see invalid\n> frames when integration times are set to large values.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> index a65c8ac08c1c..96f7fff499f5 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> @@ -25,7 +25,7 @@ private:\n> * Smallest difference between the frame length and integration time,\n> * in units of lines.\n> */\n> - static constexpr int frameIntegrationDiff = 4;\n> + static constexpr int frameIntegrationDiff = 25;\n\nAha, quite helpfully - Laurent just pointed out to me that this is\nspecified in the datasheet as\n\n0x3502 EXPO 0x00 RW\n\nBit[7:0]: Exposure[7:0]\n\tLow 4 bits are fraction bits\n\nMinimum exposure time is 1 row period.\nMaximum exposure time is frame length -25 row\n\tperiods, where frame length is set by registers\n\t{0x380E, 0x380F}\n\nReviewed-by: Kieran Bingham \n\n\n> };\n> \n> /*\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AE51BE080\n\tfor ;\n\tMon, 9 Dec 2024 12:56:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7440C66132;\n\tMon, 9 Dec 2024 13:56:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17FF266132\n\tfor ;\n\tMon, 9 Dec 2024 13:56:25 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6954689A;\n\tMon, 9 Dec 2024 13:55:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EYWyXUR6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733748953;\n\tbh=t6euopVcVxtYyqg3h0f+hO5WTfhJ88hsgwSRF+tqCp0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=EYWyXUR6bcMFVuT+MTJ67FTa9jOGtJqAq8l22O0pyaPR0ForALM7REB1Gh8LxndCL\n\tPtpVBCPvD0JoBJfjIFMrWj9MJ3PiqkySD/X0NkqgyoQkGz047EF0W55MgqPySmeJld\n\ttN78/1prZqikCACteRvvdtdtTHhWbUuNe3oEP5ww=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241209104727.520859-1-naush@raspberrypi.com>","References":"<20241209104727.520859-1-naush@raspberrypi.com>","Subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","From":"Kieran Bingham ","Cc":"dave.stevenson@raspberrypi.com, Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 09 Dec 2024 12:56:21 +0000","Message-ID":"<173374898180.812633.9243186600949358834@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32637,"web_url":"https://patchwork.libcamera.org/comment/32637/","msgid":"","date":"2024-12-09T14:59:38","subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","submitter":{"id":27,"url":"https://patchwork.libcamera.org/api/people/27/","name":"Dave Stevenson","email":"dave.stevenson@raspberrypi.com"},"content":"On Mon, 9 Dec 2024 at 12:56, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2024-12-09 10:47:23)\n> > The frameIntegrationDiff value should be 25, otherwise we see invalid\n> > frames when integration times are set to large values.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > index a65c8ac08c1c..96f7fff499f5 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_ov9281.cpp\n> > @@ -25,7 +25,7 @@ private:\n> > * Smallest difference between the frame length and integration time,\n> > * in units of lines.\n> > */\n> > - static constexpr int frameIntegrationDiff = 4;\n> > + static constexpr int frameIntegrationDiff = 25;\n>\n> Aha, quite helpfully - Laurent just pointed out to me that this is\n> specified in the datasheet as\n\nProbably as I'd just sent him a link to the datasheet :-)\n\n> 0x3502 EXPO 0x00 RW\n>\n> Bit[7:0]: Exposure[7:0]\n> Low 4 bits are fraction bits\n>\n> Minimum exposure time is 1 row period.\n> Maximum exposure time is frame length -25 row\n> periods, where frame length is set by registers\n> {0x380E, 0x380F}\n>\n> Reviewed-by: Kieran Bingham \n\nMatching kernel commit submitted as\nhttps://lore.kernel.org/linux-media/20241209-media-ov9282-fix-v1-1-d06bb7546f18@raspberrypi.com/\n\n Dave\n\n> > };\n> >\n> > /*\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 692F4BE080\n\tfor ;\n\tMon, 9 Dec 2024 15:00:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FDAF67E62;\n\tMon, 9 Dec 2024 16:00:02 +0100 (CET)","from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com\n\t[IPv6:2607:f8b0:4864:20::112b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 531DB66132\n\tfor ;\n\tMon, 9 Dec 2024 16:00:01 +0100 (CET)","by mail-yw1-x112b.google.com with SMTP id\n\t00721157ae682-6ef824f40dbso31117187b3.2\n\tfor ;\n\tMon, 09 Dec 2024 07:00:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"URNGPJDP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1733756400; x=1734361200;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Oe9V021sco3QG5lDu8UhSWme11NleTuTtgPiCZWPTH4=;\n\tb=URNGPJDP8Mf4B8brB/OnrKpKCqZZirqP5vMokaZguacL4Mx6JskrAXNBiAkZoO3z/m\n\tg9o3lEZ3mS8WxqjYGissExvOHYF2NW1IRJEUy0vFBrshNmnmB67lhyn9GBpdoFFR8hgJ\n\ttzGapcmFZ5TRI7acmBt/Eukw/fzgONAWvTk7LnaPvLHEVdqMuNTLbCSCqSPGPzYYtVDH\n\tlPwTe1PQ/Eh/uLzQhBv6yixDz4MTPeJAWZlLOUxJ4qQxuS2Im082Gz5u7hA2RslSPjR0\n\taZRNM6AcjuHW8svvlT8EFT0BuTxycte+cNKf0+N5YzzR7CQJxy67bBG4oRqbhg9N72xj\n\tWapQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1733756400; x=1734361200;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Oe9V021sco3QG5lDu8UhSWme11NleTuTtgPiCZWPTH4=;\n\tb=WAUka/XDy4ARy97oAKkxFh/o+i3thqlegasBarnnmux/fZfzVA9fVMu+JuyFZyYnXF\n\tGdd7Rz19oJ0xanDSz2vlh9AVi9ZYbxwhkCK2lj5oguGZriGyk8qjtu1YU+VRM3r/lX6B\n\t352x0Zc+MYWZxxJW98Qk3Ww4EZ8rlcI9NAtKXMrEFDrSL/2QVq7bcsBstylWlWCiB9eH\n\tib3cWXitsizdgkgTvc0qwVwN/d2itivQHtAV16+LfDov4xMNeO8jdpUuHUcr++XW5Gdv\n\tczDuXmxB5ypLnbQ0t+I2q1A5gp49Msqtc6STHDKYk59k6kGi/5/chkoN8h0CKghPlSIK\n\tXRRg==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWkIoOV1iz3zkbKqezoFYFMWKEA4jC39D4kSsWVWG8/d7fuGbFF8WW3cEgQn6Lyr1hLkKfF/sLN3bKQ24ZODh4=@lists.libcamera.org","X-Gm-Message-State":"AOJu0Yzag6HlFjPx7xNXGyinbh73eAUoiYVfIN/Hj2DytaOttZyaTQQd\n\tSPVz1uriiEhE3uN8iQiDtkNiTdyN0ya10jBQ3OLe9P3sBxT9oxg7NHEcC33muOnMBiRdrYs6Ufk\n\tdnCjP72p0kwPDbmlQsztKC8LBPwn3nSXvHMdHvg==","X-Gm-Gg":"ASbGncvS7qyhmqn/A89zgG8iIHGQc4gibAyJ3nGsQE+fds+I6K3r+8cAS6237jFRxY7\n\teMLaM6XSaI6yCYvWv5GvRwZ/zVPxIRYk=","X-Google-Smtp-Source":"AGHT+IFez7yQ3c3f4MosFg9n8Z4dnQdfDSUEPLqAIxzsjFlKWj60atj0QzvsrWJ8WgmnW2Jv1UwrE5uwacyqovnEypY=","X-Received":"by 2002:a05:690c:640f:b0:6ef:68b9:c956 with SMTP id\n\t00721157ae682-6f022f6e618mr7745847b3.39.1733756400050;\n\tMon, 09 Dec 2024 07:00:00 -0800 (PST)","MIME-Version":"1.0","References":"<20241209104727.520859-1-naush@raspberrypi.com>\n\t<173374898180.812633.9243186600949358834@ping.linuxembedded.co.uk>","In-Reply-To":"<173374898180.812633.9243186600949358834@ping.linuxembedded.co.uk>","From":"Dave Stevenson ","Date":"Mon, 9 Dec 2024 14:59:38 +0000","Message-ID":"","Subject":"Re: [PATCH] ipa: rpi: Fix wrong frame integration difference value\n\tfor OV9281","To":"Kieran Bingham ","Cc":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]