[{"id":32628,"web_url":"https://patchwork.libcamera.org/comment/32628/","msgid":"<173374067661.3135963.14180315665209436146@ping.linuxembedded.co.uk>","date":"2024-12-09T10:37:56","subject":"Re: [PATCH v2] libcamera: libipa: camera_sensor_helper: Use\n\t`variant` instead of `union`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-12-09 10:04:17)\n> Use an `std::variant` to store the analogue gain instead of a bare union + tag.\n> \n> Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n> Changes in v2:\n>   * fix code style issues\n> \n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp | 194 ++++++++----------------\n>  src/ipa/libipa/camera_sensor_helper.h   |  18 +--\n>  2 files changed, 66 insertions(+), 146 deletions(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index a76e5e75..7c66cd57 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -87,21 +87,16 @@ namespace ipa {\n>   */\n>  uint32_t CameraSensorHelper::gainCode(double gain) const\n>  {\n> -       const AnalogueGainConstants &k = gainConstants_;\n> +       if (auto *l = std::get_if<AnalogueGainLinear>(&gain_)) {\n> +               ASSERT(l->m0 == 0 || l->m1 == 0);\n> \n> -       switch (gainType_) {\n> -       case AnalogueGainLinear:\n> -               ASSERT(k.linear.m0 == 0 || k.linear.m1 == 0);\n> +               return (l->c0 - l->c1 * gain) /\n> +                      (l->m1 * gain - l->m0);\n> +       } else if (auto *e = std::get_if<AnalogueGainExp>(&gain_)) {\n> +               ASSERT(e->a != 0 && e->m != 0);\n> \n> -               return (k.linear.c0 - k.linear.c1 * gain) /\n> -                      (k.linear.m1 * gain - k.linear.m0);\n> -\n> -       case AnalogueGainExponential:\n> -               ASSERT(k.exp.a != 0 && k.exp.m != 0);\n> -\n> -               return std::log2(gain / k.exp.a) / k.exp.m;\n> -\n> -       default:\n> +               return std::log2(gain / e->a) / e->m;\n> +       } else {\n>                 ASSERT(false);\n>                 return 0;\n>         }\n> @@ -119,38 +114,26 @@ uint32_t CameraSensorHelper::gainCode(double gain) const\n>   */\n>  double CameraSensorHelper::gain(uint32_t gainCode) const\n>  {\n> -       const AnalogueGainConstants &k = gainConstants_;\n>         double gain = static_cast<double>(gainCode);\n> \n> -       switch (gainType_) {\n> -       case AnalogueGainLinear:\n> -               ASSERT(k.linear.m0 == 0 || k.linear.m1 == 0);\n> -\n> -               return (k.linear.m0 * gain + k.linear.c0) /\n> -                      (k.linear.m1 * gain + k.linear.c1);\n> +       if (auto *l = std::get_if<AnalogueGainLinear>(&gain_)) {\n> +               ASSERT(l->m0 == 0 || l->m1 == 0);\n> \n> -       case AnalogueGainExponential:\n> -               ASSERT(k.exp.a != 0 && k.exp.m != 0);\n> +               return (l->m0 * gain + l->c0) /\n> +                      (l->m1 * gain + l->c1);\n> +       } else if (auto *e = std::get_if<AnalogueGainExp>(&gain_)) {\n> +               ASSERT(e->a != 0 && e->m != 0);\n> \n> -               return k.exp.a * std::exp2(k.exp.m * gain);\n> -\n> -       default:\n> +               return e->a * std::exp2(e->m * gain);\n> +       } else {\n>                 ASSERT(false);\n>                 return 0.0;\n>         }\n>  }\n> \n>  /**\n> - * \\enum CameraSensorHelper::AnalogueGainType\n> - * \\brief The gain calculation modes as defined by the MIPI CCS\n> - *\n> - * Describes the image sensor analogue gain capabilities.\n> - * Two modes are possible, depending on the sensor: Linear and Exponential.\n> - */\n> -\n> -/**\n> - * \\var CameraSensorHelper::AnalogueGainLinear\n> - * \\brief Gain is computed using linear gain estimation\n> + * \\struct CameraSensorHelper::AnalogueGainLinear\n> + * \\brief Analogue gain constants for the linear gain model\n>   *\n>   * The relationship between the integer gain parameter and the resulting gain\n>   * multiplier is given by the following equation:\n> @@ -165,11 +148,27 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n>   * The full Gain equation therefore reduces to either:\n>   *\n>   * \\f$gain=\\frac{c0}{m1x+c1}\\f$ or \\f$\\frac{m0x+c0}{c1}\\f$\n> + *\n> + * \\var CameraSensorHelper::AnalogueGainLinear::m0\n> + * \\brief Constant used in the linear gain coding/decoding\n> + *\n> + * \\note Either m0 or m1 shall be zero.\n> + *\n> + * \\var CameraSensorHelper::AnalogueGainLinear::c0\n> + * \\brief Constant used in the linear gain coding/decoding\n> + *\n> + * \\var CameraSensorHelper::AnalogueGainLinear::m1\n> + * \\brief Constant used in the linear gain coding/decoding\n> + *\n> + * \\note Either m0 or m1 shall be zero.\n> + *\n> + * \\var CameraSensorHelper::AnalogueGainLinear::c1\n> + * \\brief Constant used in the linear gain coding/decoding\n>   */\n> \n>  /**\n> - * \\var CameraSensorHelper::AnalogueGainExponential\n> - * \\brief Gain is expressed using an exponential model\n> + * \\struct CameraSensorHelper::AnalogueGainExp\n> + * \\brief Analogue gain constants for the exponential gain model\n>   *\n>   * The relationship between the integer gain parameter and the resulting gain\n>   * multiplier is given by the following equation:\n> @@ -185,54 +184,14 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n>   *\n>   * When the gain is expressed in dB, 'a' is equal to 1 and 'm' to\n>   * \\f$log_{2}{10^{\\frac{1}{20}}}\\f$.\n> - */\n> -\n> -/**\n> - * \\struct CameraSensorHelper::AnalogueGainLinearConstants\n> - * \\brief Analogue gain constants for the linear gain model\n>   *\n> - * \\var CameraSensorHelper::AnalogueGainLinearConstants::m0\n> - * \\brief Constant used in the linear gain coding/decoding\n> - *\n> - * \\note Either m0 or m1 shall be zero.\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainLinearConstants::c0\n> - * \\brief Constant used in the linear gain coding/decoding\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainLinearConstants::m1\n> - * \\brief Constant used in the linear gain coding/decoding\n> - *\n> - * \\note Either m0 or m1 shall be zero.\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainLinearConstants::c1\n> - * \\brief Constant used in the linear gain coding/decoding\n> - */\n> -\n> -/**\n> - * \\struct CameraSensorHelper::AnalogueGainExpConstants\n> - * \\brief Analogue gain constants for the exponential gain model\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainExpConstants::a\n> + * \\var CameraSensorHelper::AnalogueGainExp::a\n>   * \\brief Constant used in the exponential gain coding/decoding\n>   *\n> - * \\var CameraSensorHelper::AnalogueGainExpConstants::m\n> + * \\var CameraSensorHelper::AnalogueGainExp::m\n>   * \\brief Constant used in the exponential gain coding/decoding\n>   */\n> \n> -/**\n> - * \\struct CameraSensorHelper::AnalogueGainConstants\n> - * \\brief Analogue gain model constants\n> - *\n> - * This union stores the constants used to calculate the analogue gain. The\n> - * CameraSensorHelper::gainType_ variable selects which union member is valid.\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainConstants::linear\n> - * \\brief Constants for the linear gain model\n> - *\n> - * \\var CameraSensorHelper::AnalogueGainConstants::exp\n> - * \\brief Constants for the exponential gain model\n> - */\n> -\n>  /**\n>   * \\var CameraSensorHelper::blackLevel_\n>   * \\brief The black level of the sensor\n> @@ -240,12 +199,7 @@ double CameraSensorHelper::gain(uint32_t gainCode) const\n>   */\n> \n>  /**\n> - * \\var CameraSensorHelper::gainType_\n> - * \\brief The analogue gain model type\n> - */\n> -\n> -/**\n> - * \\var CameraSensorHelper::gainConstants_\n> + * \\var CameraSensorHelper::gain_\n>   * \\brief The analogue gain parameters used for calculation\n>   *\n>   * The analogue gain is calculated through a formula, and its parameters are\n> @@ -526,8 +480,7 @@ public:\n>         {\n>                 /* From datasheet: 64 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 100, 0, 0, 1024 };\n> +               gain_ = AnalogueGainLinear{ 100, 0, 0, 1024 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n> @@ -539,8 +492,7 @@ public:\n>         {\n>                 /* From datasheet: 64 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 100, 0, 0, 1024 };\n> +               gain_ = AnalogueGainLinear{ 100, 0, 0, 1024 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n> @@ -552,8 +504,7 @@ public:\n>         {\n>                 /* From datasheet: 64 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 0, 512, -1, 512 };\n> +               gain_ = AnalogueGainLinear{ 0, 512, -1, 512 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx214\", CameraSensorHelperImx214)\n> @@ -565,8 +516,7 @@ public:\n>         {\n>                 /* From datasheet: 64 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 0, 256, -1, 256 };\n> +               gain_ = AnalogueGainLinear{ 0, 256, -1, 256 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx219\", CameraSensorHelperImx219)\n> @@ -578,8 +528,7 @@ public:\n>         {\n>                 /* From datasheet: 0x40 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 0, 512, -1, 512 };\n> +               gain_ = AnalogueGainLinear{ 0, 512, -1, 512 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> @@ -591,8 +540,7 @@ public:\n>         {\n>                 /* From datasheet: 0x32 at 10bits. */\n>                 blackLevel_ = 3200;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 0, 2048, -1, 2048 };\n> +               gain_ = AnalogueGainLinear{ 0, 2048, -1, 2048 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx283\", CameraSensorHelperImx283)\n> @@ -604,8 +552,7 @@ public:\n>         {\n>                 /* From datasheet: 0xf0 at 12bits. */\n>                 blackLevel_ = 3840;\n> -               gainType_ = AnalogueGainExponential;\n> -               gainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +               gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> @@ -615,8 +562,7 @@ class CameraSensorHelperImx296 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperImx296()\n>         {\n> -               gainType_ = AnalogueGainExponential;\n> -               gainConstants_.exp = { 1.0, expGainDb(0.1) };\n> +               gain_ = AnalogueGainExp{ 1.0, expGainDb(0.1) };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> @@ -633,8 +579,7 @@ public:\n>         {\n>                 /* From datasheet: 0x32 at 10bits. */\n>                 blackLevel_ = 3200;\n> -               gainType_ = AnalogueGainExponential;\n> -               gainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +               gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n> @@ -644,8 +589,7 @@ class CameraSensorHelperImx415 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperImx415()\n>         {\n> -               gainType_ = AnalogueGainExponential;\n> -               gainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +               gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n> @@ -660,8 +604,7 @@ class CameraSensorHelperImx477 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperImx477()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 0, 1024, -1, 1024 };\n> +               gain_ = AnalogueGainLinear{ 0, 1024, -1, 1024 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx477\", CameraSensorHelperImx477)\n> @@ -675,8 +618,7 @@ public:\n>                  * The Sensor Manual doesn't appear to document the gain model.\n>                  * This has been validated with some empirical testing only.\n>                  */\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov2685\", CameraSensorHelperOv2685)\n> @@ -686,8 +628,7 @@ class CameraSensorHelperOv2740 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv2740()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n> @@ -699,8 +640,7 @@ public:\n>         {\n>                 /* From datasheet: 0x40 at 12bits. */\n>                 blackLevel_ = 1024;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov4689\", CameraSensorHelperOv4689)\n> @@ -712,8 +652,7 @@ public:\n>         {\n>                 /* From datasheet: 0x10 at 10bits. */\n>                 blackLevel_ = 1024;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 16 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 16 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> @@ -723,8 +662,7 @@ class CameraSensorHelperOv5647 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv5647()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 16 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 16 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov5647\", CameraSensorHelperOv5647)\n> @@ -734,8 +672,7 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv5670()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov5670\", CameraSensorHelperOv5670)\n> @@ -747,8 +684,7 @@ public:\n>         {\n>                 /* From Linux kernel driver: 0x40 at 10bits. */\n>                 blackLevel_ = 4096;\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov5675\", CameraSensorHelperOv5675)\n> @@ -758,8 +694,7 @@ class CameraSensorHelperOv5693 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv5693()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 16 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 16 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n> @@ -769,8 +704,7 @@ class CameraSensorHelperOv64a40 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv64a40()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov64a40\", CameraSensorHelperOv64a40)\n> @@ -780,15 +714,13 @@ class CameraSensorHelperOv8858 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv8858()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -\n>                 /*\n>                  * \\todo Validate the selected 1/128 step value as it differs\n>                  * from what the sensor manual describes.\n>                  *\n>                  * See: https://patchwork.linuxtv.org/project/linux-media/patch/20221106171129.166892-2-nicholas@rothemail.net/#142267\n>                  */\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov8858\", CameraSensorHelperOv8858)\n> @@ -798,8 +730,7 @@ class CameraSensorHelperOv8865 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv8865()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov8865\", CameraSensorHelperOv8865)\n> @@ -809,8 +740,7 @@ class CameraSensorHelperOv13858 : public CameraSensorHelper\n>  public:\n>         CameraSensorHelperOv13858()\n>         {\n> -               gainType_ = AnalogueGainLinear;\n> -               gainConstants_.linear = { 1, 0, 0, 128 };\n> +               gain_ = AnalogueGainLinear{ 1, 0, 0, 128 };\n>         }\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov13858\", CameraSensorHelperOv13858)\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index 75868205..a9300a64 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -11,6 +11,7 @@\n>  #include <optional>\n>  #include <stdint.h>\n>  #include <string>\n> +#include <variant>\n>  #include <vector>\n> \n>  #include <libcamera/base/class.h>\n> @@ -30,31 +31,20 @@ public:\n>         virtual double gain(uint32_t gainCode) const;\n> \n>  protected:\n> -       enum AnalogueGainType {\n> -               AnalogueGainLinear,\n> -               AnalogueGainExponential,\n> -       };\n> -\n> -       struct AnalogueGainLinearConstants {\n> +       struct AnalogueGainLinear {\n>                 int16_t m0;\n>                 int16_t c0;\n>                 int16_t m1;\n>                 int16_t c1;\n>         };\n> \n> -       struct AnalogueGainExpConstants {\n> +       struct AnalogueGainExp {\n>                 double a;\n>                 double m;\n>         };\n> \n> -       union AnalogueGainConstants {\n> -               AnalogueGainLinearConstants linear;\n> -               AnalogueGainExpConstants exp;\n> -       };\n> -\n>         std::optional<int16_t> blackLevel_;\n> -       AnalogueGainType gainType_;\n> -       AnalogueGainConstants gainConstants_;\n> +       std::variant<std::monostate, AnalogueGainLinear, AnalogueGainExp> gain_;\n> \n>  private:\n>         LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelper)\n> --\n> 2.47.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17B3CBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  9 Dec 2024 10:38:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70C0567E5B;\n\tMon,  9 Dec 2024 11:38:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3FC867E47\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  9 Dec 2024 11:37:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E54289A;\n\tMon,  9 Dec 2024 11:37:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GTCEjRVH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733740647;\n\tbh=AbCeWiMA8TstZsLWbVdaLbrh1Z7D0yo2nwmD31VrpuQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GTCEjRVHWK/Vsy3LSiUupffyo2X+1HAFF247zL7bPp//c8kqV4J8f3C00Ux1A72Rr\n\t2i3lYMJYpjqv2mbfvSFWwLKEddCSHwa5+msHHDRNmkgzB9D4VkvNZ0Iq9TGaXcvuV8\n\tM3Bekw/rryphovh1FQ71R+cfjS19i+XsgeJgpNK0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241209100415.168483-1-pobrn@protonmail.com>","References":"<20241209100415.168483-1-pobrn@protonmail.com>","Subject":"Re: [PATCH v2] libcamera: libipa: camera_sensor_helper: Use\n\t`variant` instead of `union`","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 09 Dec 2024 10:37:56 +0000","Message-ID":"<173374067661.3135963.14180315665209436146@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]