[{"id":32622,"web_url":"https://patchwork.libcamera.org/comment/32622/","msgid":"<7b6fd46f-88c7-4c38-a85f-2ebb6fdeee1e@ideasonboard.com>","date":"2024-12-09T09:52:47","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Sorry, of course I forgot to specify that this is for libcamera-ci.\n\n2024. 12. 09. 10:51 keltezéssel, Barnabás Pőcze írta:\n> Meson's `cpp_debugstl` built-in option enables extra checks\n> in libstdc++ and libc++, such as iterator invalidation tests,\n> bounds checking in `operator[]` of multiple types, etc by\n> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> gitlab-ci.yml | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index ea038ec..ec96330 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -15,6 +15,7 @@ variables:\n> -D android=enabled\n> -D b_sanitize=address\n> -D cam=enabled\n> + -D cpp_debugstl=true\n> -D documentation=enabled\n> -D gstreamer=enabled\n> -D lc-compliance=enabled\n> @@ -58,17 +59,17 @@ include:\n> .libcamera-ci.debian:11:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bullseye'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> .libcamera-ci.debian:12:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> .libcamera-ci.debian:13:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'trixie'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> .container-debian:\n> extends:\n> @@ -389,6 +390,7 @@ test-unit:\n> MESON_OPTIONS: >-\n> -D b_sanitize=address\n> -D cam=disabled\n> + -D cpp_debugstl=true\n> -D documentation=disabled\n> -D gstreamer=enabled\n> -D lc-compliance=disabled","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50F4CBE080\n\tfor ;\n\tMon, 9 Dec 2024 09:52:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F15D767E56;\n\tMon, 9 Dec 2024 10:52:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A69B618AE\n\tfor ;\n\tMon, 9 Dec 2024 10:52:51 +0100 (CET)","from [192.168.33.20] (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CAE89502\n\tfor ;\n\tMon, 9 Dec 2024 10:52:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TJ96yGmw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733737939;\n\tbh=c1ULV4z5SXBaMkxLIu9x6T/zm1DOdmfqLluZP+63KQI=;\n\th=Date:Subject:From:To:References:In-Reply-To:From;\n\tb=TJ96yGmwDTOqoXcnBoDUZv8+X3MYH0xzBAgqBUcQtjK/5oEUN0KWT4FM2fb1+pETt\n\tDJYCyMH5nluDC4yabah9THzoF2eDZdnMyZYiAkMNxfMzNzgB0t8pOo+7cbC9QrKvV1\n\t2X2jgWhZZ/LccS8faC2mBPG7gCwgYEz55ejyvZvo=","Message-ID":"<7b6fd46f-88c7-4c38-a85f-2ebb6fdeee1e@ideasonboard.com>","Date":"Mon, 9 Dec 2024 10:52:47 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>","Content-Language":"en-US","In-Reply-To":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32624,"web_url":"https://patchwork.libcamera.org/comment/32624/","msgid":"<20241209101219.GA3510@pendragon.ideasonboard.com>","date":"2024-12-09T10:12:19","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:\n> Meson's `cpp_debugstl` built-in option enables extra checks\n> in libstdc++ and libc++, such as iterator invalidation tests,\n> bounds checking in `operator[]` of multiple types, etc by\n> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n\nCould you point to a successful pipeline run with this enabled ?\n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> gitlab-ci.yml | 8 +++++---\n> 1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index ea038ec..ec96330 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -15,6 +15,7 @@ variables:\n> -D android=enabled\n> -D b_sanitize=address\n> -D cam=enabled\n> + -D cpp_debugstl=true\n> -D documentation=enabled\n> -D gstreamer=enabled\n> -D lc-compliance=enabled\n> @@ -58,17 +59,17 @@ include:\n> .libcamera-ci.debian:11:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bullseye'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n\nYou only need to bump the container tag when you make changes to the\ncontainer itself. To enable cpp_debugstl you don't need to rebuild\ncontainers.\n\n> \n> .libcamera-ci.debian:12:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> .libcamera-ci.debian:13:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'trixie'\n> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> .container-debian:\n> extends:\n> @@ -389,6 +390,7 @@ test-unit:\n> MESON_OPTIONS: >-\n> -D b_sanitize=address\n> -D cam=disabled\n> + -D cpp_debugstl=true\n> -D documentation=disabled\n> -D gstreamer=enabled\n> -D lc-compliance=disabled","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B695BD80A\n\tfor ;\n\tMon, 9 Dec 2024 10:12:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5B8467E56;\n\tMon, 9 Dec 2024 11:12:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FED2618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:12:35 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6374711EF;\n\tMon, 9 Dec 2024 11:12:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B+vr5khE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733739123;\n\tbh=9vGKXrn4h9sKDiGglgqOvcdpXSV0pk4XU0bquqdu+MU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=B+vr5khEdjdYfz8bcMUbTNmTSq6h3KXrZ1mnLqSSiSFp8rsOgRUB47ERNXEUZRgg5\n\tje1Nh2WVhybWGL0NG47yNX0C8nQ6Nk6RQygX/KJXxtzJfeD8MMz14+owejhLeTqS7D\n\t4ooZRl4Yd/I9VqBaVhJTjeLHitjaJd7Adp8yyhIc=","Date":"Mon, 9 Dec 2024 12:12:19 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","Message-ID":"<20241209101219.GA3510@pendragon.ideasonboard.com>","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32625,"web_url":"https://patchwork.libcamera.org/comment/32625/","msgid":"<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>","date":"2024-12-09T10:20:05","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2024. 12. 09. 11:12 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> Thank you for the patch.\n> \n> On Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:\n>> Meson's `cpp_debugstl` built-in option enables extra checks\n>> in libstdc++ and libc++, such as iterator invalidation tests,\n>> bounds checking in `operator[]` of multiple types, etc by\n>> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> \n> Could you point to a successful pipeline run with this enabled ?\n\nPlease see here:\nhttps://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1324797\n\nShould I put it in the commit message?\n\n\n> \n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> gitlab-ci.yml | 8 +++++---\n>> 1 file changed, 5 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n>> index ea038ec..ec96330 100644\n>> --- a/gitlab-ci.yml\n>> +++ b/gitlab-ci.yml\n>> @@ -15,6 +15,7 @@ variables:\n>> -D android=enabled\n>> -D b_sanitize=address\n>> -D cam=enabled\n>> + -D cpp_debugstl=true\n>> -D documentation=enabled\n>> -D gstreamer=enabled\n>> -D lc-compliance=enabled\n>> @@ -58,17 +59,17 @@ include:\n>> .libcamera-ci.debian:11:\n>> variables:\n>> FDO_DISTRIBUTION_VERSION: 'bullseye'\n>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> \n> You only need to bump the container tag when you make changes to the\n> container itself. To enable cpp_debugstl you don't need to rebuild\n> containers.\n> \n>> \n>> .libcamera-ci.debian:12:\n>> variables:\n>> FDO_DISTRIBUTION_VERSION: 'bookworm'\n>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n>> \n>> .libcamera-ci.debian:13:\n>> variables:\n>> FDO_DISTRIBUTION_VERSION: 'trixie'\n>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n>> \n>> .container-debian:\n>> extends:\n>> @@ -389,6 +390,7 @@ test-unit:\n>> MESON_OPTIONS: >-\n>> -D b_sanitize=address\n>> -D cam=disabled\n>> + -D cpp_debugstl=true\n>> -D documentation=disabled\n>> -D gstreamer=enabled\n>> -D lc-compliance=disabled\n> \n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E1B3BE080\n\tfor ;\n\tMon, 9 Dec 2024 10:20:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93E7167E59;\n\tMon, 9 Dec 2024 11:20:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3400667E47\n\tfor ;\n\tMon, 9 Dec 2024 11:20:09 +0100 (CET)","from [192.168.33.20] (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A4E389A;\n\tMon, 9 Dec 2024 11:19:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ikvHu+nV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733739577;\n\tbh=idYo6t+m+enaWeBBVbR/Ji20efio37cSd/3ng+D5/cE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ikvHu+nVrukuDgOQYlHHhTRjWfSVk7LFI18BKh64M4jw1ILZcU7wArBZGh4GGe4kS\n\tqPeuU7apnUQGl8ZDdRB0E5vrqPZ0IPR/KmutWwtQqI5pZUnAsv841WplFqyRU/d2fb\n\tHwWbz9xwlh4MIeJ4xcORnaX9FpkfIwIbOTFt6HFE=","Message-ID":"<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>","Date":"Mon, 9 Dec 2024 11:20:05 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>\n\t<20241209101219.GA3510@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","In-Reply-To":"<20241209101219.GA3510@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32626,"web_url":"https://patchwork.libcamera.org/comment/32626/","msgid":"<20241209102609.GB3510@pendragon.ideasonboard.com>","date":"2024-12-09T10:26:09","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 09, 2024 at 11:20:05AM +0100, Barnabás Pőcze wrote:\n> 2024. 12. 09. 11:12 keltezéssel, Laurent Pinchart írta:\n> > On Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:\n> >> Meson's `cpp_debugstl` built-in option enables extra checks\n> >> in libstdc++ and libc++, such as iterator invalidation tests,\n> >> bounds checking in `operator[]` of multiple types, etc by\n> >> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> > \n> > Could you point to a successful pipeline run with this enabled ?\n> \n> Please see here:\n> https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1324797\n> \n> Should I put it in the commit message?\n\nNo that's fine, it was only for my information.\n\nFor next time, information that you don't think belongs to the commit\nmessage but can be useful for review can be mentioned either in a cover\nletter, or below a --- line in the commit message of the patch.\n\n> >> Signed-off-by: Barnabás Pőcze \n> >> ---\n> >> gitlab-ci.yml | 8 +++++---\n> >> 1 file changed, 5 insertions(+), 3 deletions(-)\n> >>\n> >> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> >> index ea038ec..ec96330 100644\n> >> --- a/gitlab-ci.yml\n> >> +++ b/gitlab-ci.yml\n> >> @@ -15,6 +15,7 @@ variables:\n> >> -D android=enabled\n> >> -D b_sanitize=address\n> >> -D cam=enabled\n> >> + -D cpp_debugstl=true\n\nOne additional question, should this be done for all builds, or for\ndebug builds only ?\n\n> >> -D documentation=enabled\n> >> -D gstreamer=enabled\n> >> -D lc-compliance=enabled\n> >> @@ -58,17 +59,17 @@ include:\n> >> .libcamera-ci.debian:11:\n> >> variables:\n> >> FDO_DISTRIBUTION_VERSION: 'bullseye'\n> >> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> > \n> > You only need to bump the container tag when you make changes to the\n> > container itself. To enable cpp_debugstl you don't need to rebuild\n> > containers.\n> > \n> >> \n> >> .libcamera-ci.debian:12:\n> >> variables:\n> >> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> >> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> >> \n> >> .libcamera-ci.debian:13:\n> >> variables:\n> >> FDO_DISTRIBUTION_VERSION: 'trixie'\n> >> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> >> \n> >> .container-debian:\n> >> extends:\n> >> @@ -389,6 +390,7 @@ test-unit:\n> >> MESON_OPTIONS: >-\n> >> -D b_sanitize=address\n> >> -D cam=disabled\n> >> + -D cpp_debugstl=true\n> >> -D documentation=disabled\n> >> -D gstreamer=enabled\n> >> -D lc-compliance=disabled","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76343BD80A\n\tfor ;\n\tMon, 9 Dec 2024 10:26:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A622F67E59;\n\tMon, 9 Dec 2024 11:26:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A9F6618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:26:25 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59D5089A;\n\tMon, 9 Dec 2024 11:25:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i/zOXZB1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733739953;\n\tbh=zYATmFVMNmknpF0njSD5rvCoZv8Cxg+2YS2dXD+GxiQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i/zOXZB1IhvhxbykENeIjDcNeHh58LSoasVwQunikoIa1y3iLsWY8I91teiVNw1VF\n\t+YZJLBsMYSF62T1q0gcLUrjfdrBbBsmZVEDuGujqON5nuOWvMVPwE6tMmd3rGM8g4R\n\tqUlul0VIEexHXBDW5Mzp6d3zHvsaiQ701k5ptv3Q=","Date":"Mon, 9 Dec 2024 12:26:09 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","Message-ID":"<20241209102609.GB3510@pendragon.ideasonboard.com>","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>\n\t<20241209101219.GA3510@pendragon.ideasonboard.com>\n\t<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32629,"web_url":"https://patchwork.libcamera.org/comment/32629/","msgid":"","date":"2024-12-09T10:38:31","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2024. 12. 09. 11:26 keltezéssel, Laurent Pinchart írta:\n> On Mon, Dec 09, 2024 at 11:20:05AM +0100, Barnabás Pőcze wrote:\n>> 2024. 12. 09. 11:12 keltezéssel, Laurent Pinchart írta:\n>>> On Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:\n>>>> Meson's `cpp_debugstl` built-in option enables extra checks\n>>>> in libstdc++ and libc++, such as iterator invalidation tests,\n>>>> bounds checking in `operator[]` of multiple types, etc by\n>>>> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n>>>\n>>> Could you point to a successful pipeline run with this enabled ?\n>>\n>> Please see here:\n>> https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1324797\n>>\n>> Should I put it in the commit message?\n> \n> No that's fine, it was only for my information.\n> \n> For next time, information that you don't think belongs to the commit\n> message but can be useful for review can be mentioned either in a cover\n> letter, or below a --- line in the commit message of the patch.\n> \n>>>> Signed-off-by: Barnabás Pőcze \n>>>> ---\n>>>> gitlab-ci.yml | 8 +++++---\n>>>> 1 file changed, 5 insertions(+), 3 deletions(-)\n>>>>\n>>>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n>>>> index ea038ec..ec96330 100644\n>>>> --- a/gitlab-ci.yml\n>>>> +++ b/gitlab-ci.yml\n>>>> @@ -15,6 +15,7 @@ variables:\n>>>> -D android=enabled\n>>>> -D b_sanitize=address\n>>>> -D cam=enabled\n>>>> + -D cpp_debugstl=true\n> \n> One additional question, should this be done for all builds, or for\n> debug builds only ?\n\nAfter some deliberation I decided to enable it everywhere where \nAddressSanitizer is enabled, as I don't believe it to be meaningfully \ndifferent from AddressSanitizer in purpose. But I think not enabling it\nfor release builds also makes sense, so I could do that too.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n>>>> -D documentation=enabled\n>>>> -D gstreamer=enabled\n>>>> -D lc-compliance=enabled\n>>>> @@ -58,17 +59,17 @@ include:\n>>>> .libcamera-ci.debian:11:\n>>>> variables:\n>>>> FDO_DISTRIBUTION_VERSION: 'bullseye'\n>>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n>>>\n>>> You only need to bump the container tag when you make changes to the\n>>> container itself. To enable cpp_debugstl you don't need to rebuild\n>>> containers.\n>>>\n>>>> \n>>>> .libcamera-ci.debian:12:\n>>>> variables:\n>>>> FDO_DISTRIBUTION_VERSION: 'bookworm'\n>>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n>>>> \n>>>> .libcamera-ci.debian:13:\n>>>> variables:\n>>>> FDO_DISTRIBUTION_VERSION: 'trixie'\n>>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n>>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n>>>> \n>>>> .container-debian:\n>>>> extends:\n>>>> @@ -389,6 +390,7 @@ test-unit:\n>>>> MESON_OPTIONS: >-\n>>>> -D b_sanitize=address\n>>>> -D cam=disabled\n>>>> + -D cpp_debugstl=true\n>>>> -D documentation=disabled\n>>>> -D gstreamer=enabled\n>>>> -D lc-compliance=disabled\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F9B3BE080\n\tfor ;\n\tMon, 9 Dec 2024 10:38:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20BCD67E47;\n\tMon, 9 Dec 2024 11:38:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7C7467E47\n\tfor ;\n\tMon, 9 Dec 2024 11:38:34 +0100 (CET)","from [192.168.33.20] (185.221.143.90.nat.pool.zt.hu\n\t[185.221.143.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6798E11EF;\n\tMon, 9 Dec 2024 11:38:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CYgdyqj7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733740683;\n\tbh=pVtVOXwWYGvSgKhhJ3CjMGEIaG2+tsODQMy0BN26+Ag=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=CYgdyqj71Z4lRXZxPlg770bfmrfpFsKKZmdpaUe35FJzXlqQLKqM3Mf241MH+OPpu\n\tavqATPeVmDJctTgKcz7n8eF5+TKwlm4rPu2hH35RhIZs/wnJu6FLRigPtdbZrQqs/W\n\tMHr1JstcydQsH/7/t4Q2yWHlYdbEoSg4VEGTyzsE=","Message-ID":"","Date":"Mon, 9 Dec 2024 11:38:31 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>\n\t<20241209101219.GA3510@pendragon.ideasonboard.com>\n\t<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>\n\t<20241209102609.GB3510@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","In-Reply-To":"<20241209102609.GB3510@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32630,"web_url":"https://patchwork.libcamera.org/comment/32630/","msgid":"<20241209105138.GE11343@pendragon.ideasonboard.com>","date":"2024-12-09T10:51:38","subject":"Re: [PATCH v1] Enable `cpp_debugstl`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Dec 09, 2024 at 11:38:31AM +0100, Barnabás Pőcze wrote:\n> 2024. 12. 09. 11:26 keltezéssel, Laurent Pinchart írta:\n> > On Mon, Dec 09, 2024 at 11:20:05AM +0100, Barnabás Pőcze wrote:\n> >> 2024. 12. 09. 11:12 keltezéssel, Laurent Pinchart írta:\n> >>> On Mon, Dec 09, 2024 at 10:51:50AM +0100, Barnabás Pőcze wrote:\n> >>>> Meson's `cpp_debugstl` built-in option enables extra checks\n> >>>> in libstdc++ and libc++, such as iterator invalidation tests,\n> >>>> bounds checking in `operator[]` of multiple types, etc by\n> >>>> setting `GLIBCXX_DEBUG` and `_LIBCPP_HARDENING_MODE`.\n> >>>\n> >>> Could you point to a successful pipeline run with this enabled ?\n> >>\n> >> Please see here:\n> >> https://gitlab.freedesktop.org/pobrn/libcamera/-/pipelines/1324797\n> >>\n> >> Should I put it in the commit message?\n> > \n> > No that's fine, it was only for my information.\n> > \n> > For next time, information that you don't think belongs to the commit\n> > message but can be useful for review can be mentioned either in a cover\n> > letter, or below a --- line in the commit message of the patch.\n> > \n> >>>> Signed-off-by: Barnabás Pőcze \n> >>>> ---\n> >>>> gitlab-ci.yml | 8 +++++---\n> >>>> 1 file changed, 5 insertions(+), 3 deletions(-)\n> >>>>\n> >>>> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> >>>> index ea038ec..ec96330 100644\n> >>>> --- a/gitlab-ci.yml\n> >>>> +++ b/gitlab-ci.yml\n> >>>> @@ -15,6 +15,7 @@ variables:\n> >>>> -D android=enabled\n> >>>> -D b_sanitize=address\n> >>>> -D cam=enabled\n> >>>> + -D cpp_debugstl=true\n> > \n> > One additional question, should this be done for all builds, or for\n> > debug builds only ?\n> \n> After some deliberation I decided to enable it everywhere where \n> AddressSanitizer is enabled, as I don't believe it to be meaningfully \n> different from AddressSanitizer in purpose. But I think not enabling it\n> for release builds also makes sense, so I could do that too.\n\nTying it to ASan makes sense. Please mention that in the commit message\nfor the next version.\n\n> >>>> -D documentation=enabled\n> >>>> -D gstreamer=enabled\n> >>>> -D lc-compliance=enabled\n> >>>> @@ -58,17 +59,17 @@ include:\n> >>>> .libcamera-ci.debian:11:\n> >>>> variables:\n> >>>> FDO_DISTRIBUTION_VERSION: 'bullseye'\n> >>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> >>>\n> >>> You only need to bump the container tag when you make changes to the\n> >>> container itself. To enable cpp_debugstl you don't need to rebuild\n> >>> containers.\n> >>>\n> >>>> \n> >>>> .libcamera-ci.debian:12:\n> >>>> variables:\n> >>>> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> >>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> >>>> \n> >>>> .libcamera-ci.debian:13:\n> >>>> variables:\n> >>>> FDO_DISTRIBUTION_VERSION: 'trixie'\n> >>>> - FDO_DISTRIBUTION_TAG: '2024-11-05.1'\n> >>>> + FDO_DISTRIBUTION_TAG: '2024-12-06.1'\n> >>>> \n> >>>> .container-debian:\n> >>>> extends:\n> >>>> @@ -389,6 +390,7 @@ test-unit:\n> >>>> MESON_OPTIONS: >-\n> >>>> -D b_sanitize=address\n> >>>> -D cam=disabled\n> >>>> + -D cpp_debugstl=true\n> >>>> -D documentation=disabled\n> >>>> -D gstreamer=enabled\n> >>>> -D lc-compliance=disabled","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 952E3BE080\n\tfor ;\n\tMon, 9 Dec 2024 10:51:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDEEC67E61;\n\tMon, 9 Dec 2024 11:51:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6441C618AE\n\tfor ;\n\tMon, 9 Dec 2024 11:51:54 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3E1C89A;\n\tMon, 9 Dec 2024 11:51:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GpZXCwtd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733741482;\n\tbh=82ZIDMV0a6B2k1fDTGfv+yCKeJWO/ckOKAI75C8drto=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GpZXCwtdENVIFMIZPEzkskeO66Gcoy89ubUYlYAW+xAa4buii9ThD1lbNuLeGI7D+\n\tcQHqQYzS7ofPUE3TrBTedorwwP9qakz89hf4U6fwXtJSjGNaA8TPL7ZOfQ95wu8RjA\n\tmbQsIBiwbs3wpPQVRuW/LQJ77ITnfgKLGpz+cZEg=","Date":"Mon, 9 Dec 2024 12:51:38 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] Enable `cpp_debugstl`","Message-ID":"<20241209105138.GE11343@pendragon.ideasonboard.com>","References":"<20241209095150.164960-1-barnabas.pocze@ideasonboard.com>\n\t<20241209101219.GA3510@pendragon.ideasonboard.com>\n\t<8d6cf465-dda5-4fbb-b15c-0f3c4abcb944@ideasonboard.com>\n\t<20241209102609.GB3510@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]