[{"id":2963,"web_url":"https://patchwork.libcamera.org/comment/2963/","msgid":"<20191025234126.GG17290@pendragon.ideasonboard.com>","date":"2019-10-25T23:41:26","subject":"Re: [libcamera-devel] [PATCH] cam: capture: remove unused local\n\tvariable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Oct 26, 2019 at 01:40:04AM +0200, Paul Elder wrote:\n> Remove unused local map variable.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/cam/capture.cpp | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/src/cam/capture.cpp b/src/cam/capture.cpp\n> index 8a939c62..fa3922ba 100644\n> --- a/src/cam/capture.cpp\n> +++ b/src/cam/capture.cpp\n> @@ -91,7 +91,6 @@ int Capture::capture(EventLoop *loop)\n>  \t\t\treturn -ENOMEM;\n>  \t\t}\n>  \n> -\t\tstd::map<Stream *, Buffer *> map;\n>  \t\tfor (StreamConfiguration &cfg : *config_) {\n>  \t\t\tStream *stream = cfg.stream();\n>  \t\t\tstd::unique_ptr<Buffer> buffer = stream->createBuffer(i);","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B87D60C0F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 26 Oct 2019 01:41:34 +0200 (CEST)","from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 258FA43E;\n\tSat, 26 Oct 2019 01:41:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572046894;\n\tbh=LdBlHk5mEjpOAowmElJ2dm81Dlp3C5YX5z9stjSXBfY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=orNNs+X56KvI4F2jj0GcZZ0BFrh+HuK9GrTWAP2hfRza9qNpiVWkMLb9Y2CNz6CNL\n\tja7LEKDqJ1nfBlfBnhlpZN3nCHwQYGM2EEBzBz3BMCreBQ2FPl4gvEpBb3lu4u0jGE\n\tFf9j53OZSGGFocKGpT1mbVJ1JOQq6slshbofdE1w=","Date":"Sat, 26 Oct 2019 02:41:26 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191025234126.GG17290@pendragon.ideasonboard.com>","References":"<20191025234004.2754-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191025234004.2754-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] cam: capture: remove unused local\n\tvariable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 25 Oct 2019 23:41:34 -0000"}}]