[{"id":32606,"web_url":"https://patchwork.libcamera.org/comment/32606/","msgid":"<20241206181554.GD17570@pendragon.ideasonboard.com>","date":"2024-12-06T18:15:54","subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Dec 06, 2024 at 05:55:58PM +0100, Jacopo Mondi wrote:\n> The StreamConfiguration class only implements toString() but doesn't\n> offer an overload of operator<<() which is more convenient to use.\n> \n> Add an overload for operator<<(StreamConfiguration) and re-implement\n> StreamConfiguration::toString() on top of it.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Stefan Klug \n> ---\n> include/libcamera/stream.h | 2 ++\n> src/libcamera/stream.cpp | 18 +++++++++++++++++-\n> 2 files changed, 19 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 071b71698acb..ea228aea7d56 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -61,6 +61,8 @@ private:\n> \tStreamFormats formats_;\n> };\n> \n> +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n> +\n> enum class StreamRole {\n> \tRaw,\n> \tStillCapture,\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 1f75dbbc5b64..179e75df445b 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -392,7 +392,23 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> */\n> std::string StreamConfiguration::toString() const\n> {\n> -\treturn size.toString() + \"-\" + pixelFormat.toString();\n> +\tstd::stringstream ss;\n> +\tss << *this;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> +/**\n> + * \\brief Insert a text representation of a StreamConfiguration into an output\n> + * stream\n> + * \\param[in] out The output stream\n> + * \\param[in] cfg The StreamConfiguration\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n> +{\n> +\tout << cfg.size.toString() + \"-\" + cfg.pixelFormat.toString();\n\nIf we want to make streams usage efficient here, this should be\n\n\tout << cfg.size << \"-\" << cfg.pixelFormat;\n\nWith that,\n\nReviewed-by: Laurent Pinchart \n\n> +\treturn out;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92152BF415\n\tfor ;\n\tFri, 6 Dec 2024 18:16:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD5D567E36;\n\tFri, 6 Dec 2024 19:16:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68E5267E24\n\tfor ;\n\tFri, 6 Dec 2024 19:16:08 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81CCD641;\n\tFri, 6 Dec 2024 19:15:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H3Mi7FuD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733508938;\n\tbh=4/+DPdBkvg2AsOSvSuzCDPDCxM8Du8WxwQvxOiNI+bA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H3Mi7FuDBetF3CNRS18/lHO9mNlGGYVfViUyQYHdtDcG8DT+1cm0lg4o0mJmtH8w4\n\tE2ylfGu6TczDXJq4UBBfawwh40VXbTKus2RJOXs9L4V9RLPqv+oaJpMSto7nu11nF6\n\tElEml/seCXSGl28qrMUfT9jViZF2C/unYPn9qLFo=","Date":"Fri, 6 Dec 2024 20:15:54 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tStefan Klug ","Subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","Message-ID":"<20241206181554.GD17570@pendragon.ideasonboard.com>","References":"<20241206165559.102615-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241206165559.102615-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32608,"web_url":"https://patchwork.libcamera.org/comment/32608/","msgid":"","date":"2024-12-06T18:19:47","subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"Hi\n\n\n2024. december 6., péntek 19:15 keltezéssel, Laurent Pinchart írta:\n\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Fri, Dec 06, 2024 at 05:55:58PM +0100, Jacopo Mondi wrote:\n> > The StreamConfiguration class only implements toString() but doesn't\n> > offer an overload of operator<<() which is more convenient to use.\n> >\n> > Add an overload for operator<<(StreamConfiguration) and re-implement\n> > StreamConfiguration::toString() on top of it.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > Reviewed-by: Kieran Bingham \n> > Reviewed-by: Stefan Klug \n> > ---\n> > include/libcamera/stream.h | 2 ++\n> > src/libcamera/stream.cpp | 18 +++++++++++++++++-\n> > 2 files changed, 19 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 071b71698acb..ea228aea7d56 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -61,6 +61,8 @@ private:\n> > \tStreamFormats formats_;\n> > };\n> >\n> > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n> > +\n> > enum class StreamRole {\n> > \tRaw,\n> > \tStillCapture,\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index 1f75dbbc5b64..179e75df445b 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -392,7 +392,23 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> > */\n> > std::string StreamConfiguration::toString() const\n> > {\n> > -\treturn size.toString() + \"-\" + pixelFormat.toString();\n> > +\tstd::stringstream ss;\n> > +\tss << *this;\n> > +\n> > +\treturn ss.str();\n> > +}\n> > +\n> > +/**\n> > + * \\brief Insert a text representation of a StreamConfiguration into an output\n> > + * stream\n> > + * \\param[in] out The output stream\n> > + * \\param[in] cfg The StreamConfiguration\n> > + * \\return The output stream \\a out\n> > + */\n> > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n> > +{\n> > +\tout << cfg.size.toString() + \"-\" + cfg.pixelFormat.toString();\n> \n> If we want to make streams usage efficient here, this should be\n> \n> \tout << cfg.size << \"-\" << cfg.pixelFormat;\n> [...]\n\nI believe the argument should be `const StreamConfiguration&` in addition.\n\n\nRegards,\nBarnabás Pőcze","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2E41BE173\n\tfor ;\n\tFri, 6 Dec 2024 18:19:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C47267E3C;\n\tFri, 6 Dec 2024 19:19:54 +0100 (CET)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 054BB67E36\n\tfor ;\n\tFri, 6 Dec 2024 19:19:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"HYndirYC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1733509192; x=1733768392;\n\tbh=WL0nhEq5PK0X/tuIi9sbmGwXOvR7nAlReox62XSJ8Ys=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=HYndirYCMz+tiuQKb+Lps9niejq5XJCcimKnUR3a/fWRCvl0PP4zaO4bNF7i04N3u\n\tNnaFamEvbSkiuQtx5o91OIOEIaQJuXdE+3jmpICrcT6S6ZDd24C2X0G3ZilZ5t22aw\n\t03HLNsWz9SZkQ4czFbWE7ikAav7rhINtatw6owS9VtKbfm/Rj71eVGMA2//JOpjjsS\n\t7TiejhrEWAfEQfNdS2btHp9wSUvzVEP0JzRe+if73o+nyq419W/HkhdlnskwU5Z4l7\n\tQi9mA6jfrY+chdA7fGA9h9BIbqCji1h62Xzoz+BHmwlL5iJ5YGVlv79pTdfQwa4wEh\n\tEyqdRQCq103Cw==","Date":"Fri, 06 Dec 2024 18:19:47 +0000","To":"Laurent Pinchart ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tStefan Klug ","Subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","Message-ID":"","In-Reply-To":"<20241206181554.GD17570@pendragon.ideasonboard.com>","References":"<20241206165559.102615-1-jacopo.mondi@ideasonboard.com>\n\t<20241206181554.GD17570@pendragon.ideasonboard.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"9c2471ffaf4a3bbe7d2ae306553484060f4b27a8","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32609,"web_url":"https://patchwork.libcamera.org/comment/32609/","msgid":"<20241206182643.GF17570@pendragon.ideasonboard.com>","date":"2024-12-06T18:26:43","subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Dec 06, 2024 at 06:19:47PM +0000, Barnabás Pőcze wrote:\n> 2024. december 6., péntek 19:15 keltezéssel, Laurent Pinchart írta:\n> > On Fri, Dec 06, 2024 at 05:55:58PM +0100, Jacopo Mondi wrote:\n> > > The StreamConfiguration class only implements toString() but doesn't\n> > > offer an overload of operator<<() which is more convenient to use.\n> > >\n> > > Add an overload for operator<<(StreamConfiguration) and re-implement\n> > > StreamConfiguration::toString() on top of it.\n> > >\n> > > Signed-off-by: Jacopo Mondi \n> > > Reviewed-by: Kieran Bingham \n> > > Reviewed-by: Stefan Klug \n> > > ---\n> > > include/libcamera/stream.h | 2 ++\n> > > src/libcamera/stream.cpp | 18 +++++++++++++++++-\n> > > 2 files changed, 19 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > > index 071b71698acb..ea228aea7d56 100644\n> > > --- a/include/libcamera/stream.h\n> > > +++ b/include/libcamera/stream.h\n> > > @@ -61,6 +61,8 @@ private:\n> > > \tStreamFormats formats_;\n> > > };\n> > >\n> > > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n> > > +\n> > > enum class StreamRole {\n> > > \tRaw,\n> > > \tStillCapture,\n> > > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > > index 1f75dbbc5b64..179e75df445b 100644\n> > > --- a/src/libcamera/stream.cpp\n> > > +++ b/src/libcamera/stream.cpp\n> > > @@ -392,7 +392,23 @@ StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> > > */\n> > > std::string StreamConfiguration::toString() const\n> > > {\n> > > -\treturn size.toString() + \"-\" + pixelFormat.toString();\n> > > +\tstd::stringstream ss;\n> > > +\tss << *this;\n> > > +\n> > > +\treturn ss.str();\n> > > +}\n> > > +\n> > > +/**\n> > > + * \\brief Insert a text representation of a StreamConfiguration into an output\n> > > + * stream\n> > > + * \\param[in] out The output stream\n> > > + * \\param[in] cfg The StreamConfiguration\n> > > + * \\return The output stream \\a out\n> > > + */\n> > > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n> > > +{\n> > > +\tout << cfg.size.toString() + \"-\" + cfg.pixelFormat.toString();\n> > \n> > If we want to make streams usage efficient here, this should be\n> > \n> > \tout << cfg.size << \"-\" << cfg.pixelFormat;\n> > [...]\n> \n> I believe the argument should be `const StreamConfiguration&` in addition.\n\nYes, that too, I've missed it.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE91EBF415\n\tfor ;\n\tFri, 6 Dec 2024 18:27:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E685D67E37;\n\tFri, 6 Dec 2024 19:26:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 413EA618B3\n\tfor ;\n\tFri, 6 Dec 2024 19:26:58 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D1B5641;\n\tFri, 6 Dec 2024 19:26:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oiBcrBrY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733509588;\n\tbh=SxJljLhVyL4w1Q5aPRf4S7tAPvOLbuDlOA7UDE2DAMA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oiBcrBrYe+YU75pMYA90EoNYQQqdP3TKDE/RCGcmas2Z9BKLltB1l+2mPtHI5Q8Eg\n\tRR76FVTK5AbrMlI09PFVaEIOs1ikydZIQt/vdUMDJzip9/mquUvy1zEpRRMNrZxZMA\n\tQwdZDGGmTMosYll5rICzwMl9P/l4npdplpDKYu90=","Date":"Fri, 6 Dec 2024 20:26:43 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tStefan Klug ","Subject":"Re: [PATCH v3] libcamera: stream: Add\n\toperator<<(StreamConfiguration)","Message-ID":"<20241206182643.GF17570@pendragon.ideasonboard.com>","References":"<20241206165559.102615-1-jacopo.mondi@ideasonboard.com>\n\t<20241206181554.GD17570@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]