{"id":22234,"url":"https://patchwork.libcamera.org/api/patches/22234/?format=json","web_url":"https://patchwork.libcamera.org/patch/22234/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206160747.97176-9-jacopo.mondi@ideasonboard.com>","date":"2024-12-06T16:07:46","name":"[8/8,DNI] apps: cam: Use Camera::metadataAvailable signal","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"1b73ec77f1ea4957af63060667b5cf4898074bf6","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22234/mbox/","series":[{"id":4858,"url":"https://patchwork.libcamera.org/api/series/4858/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4858","date":"2024-12-06T16:07:38","name":"libcamera: Support partial metadata completion","version":1,"mbox":"https://patchwork.libcamera.org/series/4858/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22234/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22234/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9EDBBE173\n\tfor ;\n\tFri, 6 Dec 2024 16:08:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1CED67E30;\n\tFri, 6 Dec 2024 17:08:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18E9F67E29\n\tfor ;\n\tFri, 6 Dec 2024 17:07:58 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 633D1B2B;\n\tFri, 6 Dec 2024 17:07:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JP+oIAMH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733501248;\n\tbh=IpztqRtWVNDKpC+2Hj1pd4wRUpF3AsCDrijqdSYA3X0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JP+oIAMHh3GLvU4UkZunLxuyMg2Dl/nmj+0sCPjOgNXDUlJn1NhB5PzarJgJHNHgp\n\t74cZDBN/S2K0ZJG465P5ikjqid+jeBupON8Go6G6B6aBdJfpH1SlvNsr4rFRd9brTG\n\t32xGdt3HVva/K6A27/UEcp3YlY32KRNd3NoKCYIU=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tHarvey Yang ,\n\tHan-Lin Chen ","Subject":"[PATCH 8/8] [DNI] apps: cam: Use Camera::metadataAvailable signal","Date":"Fri, 6 Dec 2024 17:07:46 +0100","Message-ID":"<20241206160747.97176-9-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.47.1","In-Reply-To":"<20241206160747.97176-1-jacopo.mondi@ideasonboard.com>","References":"<20241206160747.97176-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Handle the Camera::metadataAvailable signal and print the metadata\nlist.\n\nUse the --metadata option of cam to validate that the metadata list\nin Request::metadata() matches the accumulated results.\n\nSigned-off-by: Jacopo Mondi \n---\n src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n src/apps/cam/camera_session.h | 2 ++\n 2 files changed, 19 insertions(+)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 6e9890ccfda1..422874ae74ea 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -246,6 +246,7 @@ int CameraSession::start()\n \t\t\t\t\t + \"-stream\" + std::to_string(index);\n \t}\n \n+\tcamera_->metadataAvailable.connect(this, &CameraSession::metadataAvailable);\n \tcamera_->requestCompleted.connect(this, &CameraSession::requestComplete);\n \n #ifdef HAVE_KMS\n@@ -407,6 +408,22 @@ int CameraSession::queueRequest(Request *request)\n \treturn camera_->queueRequest(request);\n }\n \n+void CameraSession::metadataAvailable(Request *request,\n+\t\t\t\t std::unordered_set ids)\n+{\n+\tconst ControlList &metadata = request->metadata();\n+\n+\tstd::cerr << \"EARLY METADATA COMPLETION FOR REQUEST: \"\n+\t\t << request->sequence() << std::endl;\n+\n+\tfor (const auto id : ids) {\n+\t\tconst ControlValue &value = metadata.get(id->id());\n+\n+\t\tstd::cout << \"\\t\" << id->name() << \" = \"\n+\t\t\t << value.toString() << std::endl;\n+\t}\n+}\n+\n void CameraSession::requestComplete(Request *request)\n {\n \tif (request->status() == Request::RequestCancelled)\ndiff --git a/src/apps/cam/camera_session.h b/src/apps/cam/camera_session.h\nindex 4442fd9b1a6a..0539f759a65a 100644\n--- a/src/apps/cam/camera_session.h\n+++ b/src/apps/cam/camera_session.h\n@@ -53,6 +53,8 @@ private:\n \tint startCapture();\n \n \tint queueRequest(libcamera::Request *request);\n+\tvoid metadataAvailable(libcamera::Request *request,\n+\t\t\t std::unordered_set ids);\n \tvoid requestComplete(libcamera::Request *request);\n \tvoid processRequest(libcamera::Request *request);\n \tvoid sinkRelease(libcamera::Request *request);\n","prefixes":["8/8","DNI"]}