[{"id":32618,"web_url":"https://patchwork.libcamera.org/comment/32618/","msgid":"<20241209020854.GP17570@pendragon.ideasonboard.com>","date":"2024-12-09T02:08:54","subject":"Re: [PATCH v5 6/8] libtuning: Fix access to color member in\n\tctt_awb.awb()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Dec 06, 2024 at 03:52:26PM +0100, Stefan Klug wrote:\n> Fix the access to the color temperature member of the Img object.\n\nThat's a bit terse.\n\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Paul Elder \n> ---\n> utils/tuning/libtuning/ctt_awb.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py\n> index 5494bdb5c103..117612f2582a 100644\n> --- a/utils/tuning/libtuning/ctt_awb.py\n> +++ b/utils/tuning/libtuning/ctt_awb.py\n> @@ -304,7 +304,7 @@ def get_alsc_patches(Img, colour_cals, grey=True):\n> \"\"\"\n> if grey:\n> cen_coords = Img.cen_coords[3::4]\n> - col = Img.col\n> + col = Img.color\n\nThere's one similar change left in 4/8. Move it here, and\n\nReviewed-by: Laurent Pinchart \n\n> patches = [np.array(Img.patches[i]) for i in Img.order]\n> r_patchs = patches[0][3::4] - Img.blacklevel_16\n> b_patchs = patches[3][3::4] - Img.blacklevel_16","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D304BD80A\n\tfor ;\n\tMon, 9 Dec 2024 02:09:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D95F67E4A;\n\tMon, 9 Dec 2024 03:09:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7514618AD\n\tfor ;\n\tMon, 9 Dec 2024 03:09:09 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59058502;\n\tMon, 9 Dec 2024 03:08:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"N0FF37eO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733710118;\n\tbh=Y+ZmI0ysEIQE1JleTjPLNY+tImCS6fT6wfUoLlW2drs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=N0FF37eO1Y9YE0H7PS8nU4BxBLvxYeeWnGuMR7Au+tAkj1VwQkcJjalcpViCc3GYW\n\t3ok5a0FmmYUbMzyF03XJzQp9fvQ4WTiKTCCCy5uUVBkPQwvpSRAt+qlAlhcDWPxoXE\n\t0hfH/Ynq1vAG9mOVNqsNZP1xo6WSm3MXoCnJo6Hs=","Date":"Mon, 9 Dec 2024 04:08:54 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"Re: [PATCH v5 6/8] libtuning: Fix access to color member in\n\tctt_awb.awb()","Message-ID":"<20241209020854.GP17570@pendragon.ideasonboard.com>","References":"<20241206145242.827886-1-stefan.klug@ideasonboard.com>\n\t<20241206145242.827886-7-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241206145242.827886-7-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]