[{"id":32617,"web_url":"https://patchwork.libcamera.org/comment/32617/","msgid":"<20241209020650.GO17570@pendragon.ideasonboard.com>","date":"2024-12-09T02:06:50","subject":"Re: [PATCH v5 5/8] libtuning: Remove the Cam object from\n\tctt_awb.awb()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Fri, Dec 06, 2024 at 03:52:25PM +0100, Stefan Klug wrote:\n> Replace the Cam object with a list parameter to be able to call the\n> ctt_awb.awb() function from libtuning code.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> utils/tuning/libtuning/ctt_awb.py | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/ctt_awb.py b/utils/tuning/libtuning/ctt_awb.py\n> index 899f204da8cf..5494bdb5c103 100644\n> --- a/utils/tuning/libtuning/ctt_awb.py\n> +++ b/utils/tuning/libtuning/ctt_awb.py\n> @@ -18,8 +18,7 @@ logger = logging.getLogger(__name__)\n> \"\"\"\n> obtain piecewise linear approximation for colour curve\n> \"\"\"\n> -def awb(Cam, cal_cr_list, cal_cb_list, plot):\n> - imgs = Cam.imgs\n> +def awb(imgs, cal_cr_list, cal_cb_list, plot):\n> \"\"\"\n> condense alsc calibration tables into one dictionary\n> \"\"\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03B75C3259\n\tfor ;\n\tMon, 9 Dec 2024 02:07:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B180C67E41;\n\tMon, 9 Dec 2024 03:07:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D3AB67E41\n\tfor ;\n\tMon, 9 Dec 2024 03:07:05 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21FF2502;\n\tMon, 9 Dec 2024 03:06:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k3ATmmCS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733709994;\n\tbh=hLKWpp2l1it9+BJ9te6jyiQfmWMlesygXX2gY7cNXKA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k3ATmmCSn28HF950c63C9FHVYpTMkCjka4/nqRgmwGqAuWWy9QuRKQfkpami6NRL2\n\ttkf00JvDyAfYpF7I3y2DgNEPji9k7pnBCNNnIdPtNQYL/cchQj/4mbYCu4EeliMWSK\n\t5+GjK39S0eibBLrBeV5Cgbd3TS8O9wdsJ8s/IsIc=","Date":"Mon, 9 Dec 2024 04:06:50 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"Re: [PATCH v5 5/8] libtuning: Remove the Cam object from\n\tctt_awb.awb()","Message-ID":"<20241209020650.GO17570@pendragon.ideasonboard.com>","References":"<20241206145242.827886-1-stefan.klug@ideasonboard.com>\n\t<20241206145242.827886-6-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241206145242.827886-6-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]