[{"id":32592,"web_url":"https://patchwork.libcamera.org/comment/32592/","msgid":"<173349953074.312267.10868769758605682531@ping.linuxembedded.co.uk>","date":"2024-12-06T15:38:50","subject":"Re: [PATCH 4/5] pipeline: rpi: common: Add wallclock timestamp\n\tsupport","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman (2024-12-06 14:27:41)\n> A ClockRecovery object is added for derived classes to use, and\n> wallclock timetamps are copied into the request metadata for\n> applications.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 ++\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 3 +++\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index 6f278b29..34971973 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -1509,6 +1509,8 @@ void CameraData::fillRequestMetadata(const ControlList &bufferControls, Request\n> {\n> request->metadata().set(controls::SensorTimestamp,\n> bufferControls.get(controls::SensorTimestamp).value_or(0));\n> + request->metadata().set(controls::FrameWallClock,\n> + bufferControls.get(controls::FrameWallClock).value_or(0));\n> \n> if (cropParams_.size()) {\n> std::vector crops;\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index aae0c2f3..9aa591d6 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -20,6 +20,7 @@\n> #include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/clock_recovery.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/media_object.h\"\n> @@ -237,6 +238,8 @@ protected:\n> virtual int platformRegister(std::unique_ptr &cameraData,\n> MediaDevice *unicam, MediaDevice *isp) = 0;\n> \n> + ClockRecovery wallClockRecoery_;\n\ns/wallClockRecoery_/wallClockRecovery_/\n\n(If this object stays instantiated in the Pipeline Handler)\n\n> +\n> private:\n> CameraData *cameraData(Camera *camera)\n> {\n> -- \n> 2.39.5\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A2F6BF415\n\tfor ;\n\tFri, 6 Dec 2024 15:38:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B313D66177;\n\tFri, 6 Dec 2024 16:38:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A9F3618B3\n\tfor ;\n\tFri, 6 Dec 2024 16:38:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 124FD74C;\n\tFri, 6 Dec 2024 16:38:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FqjIsP4h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733499504;\n\tbh=WJVdGAmMRvogSNzsHTiCa8c/G+Rl9aelc0HGwuRqPI4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FqjIsP4hvoUfP6+ZuY3IZqcls//ijXQ5KiwX7Euv2+bnBQ2adC2Y4mXnYuwKl2MAb\n\tQnghCrMRjlPoY9B6hkKE01hPDQGNNmddr6zZynDazNPkRXQ739SXoZaNtI6Rrnc93y\n\tkb+uSFOrKo2Mw5trZ+/5Nv1QNDKOACqS4h9rniNg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241206142742.7931-5-david.plowman@raspberrypi.com>","References":"<20241206142742.7931-1-david.plowman@raspberrypi.com>\n\t<20241206142742.7931-5-david.plowman@raspberrypi.com>","Subject":"Re: [PATCH 4/5] pipeline: rpi: common: Add wallclock timestamp\n\tsupport","From":"Kieran Bingham ","Cc":"David Plowman ","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 06 Dec 2024 15:38:50 +0000","Message-ID":"<173349953074.312267.10868769758605682531@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]