[{"id":32678,"web_url":"https://patchwork.libcamera.org/comment/32678/","msgid":"","date":"2024-12-11T14:40:25","subject":"Re: [PATCH v3 13/17] camera: Add a const version of the pipe()\n\tfunction","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Fri, Dec 06, 2024 at 11:13:35AM +0100, Stefan Klug wrote:\n> Allow access to the pipeline handler on a const instance of\n> Camera::Private.\n>\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> Changes in v3:\n> - Added this patch\n> ---\n> include/libcamera/internal/camera.h | 1 +\n> src/libcamera/camera.cpp | 5 +++++\n> 2 files changed, 6 insertions(+)\n>\n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 0add0428bb5d..2bb00bbcb644 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -32,6 +32,7 @@ public:\n> \t~Private();\n>\n> \tPipelineHandler *pipe() { return pipe_.get(); }\n> +\tconst PipelineHandler *pipe() const { return pipe_.get(); }\n>\n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 4c865a46af53..69a7ee5353f1 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -603,6 +603,11 @@ Camera::Private::~Private()\n> * \\return The pipeline handler that created this camera\n> */\n>\n> +/**\n> + * \\fn Camera::Private::pipe() const\n> + * \\copydoc Camera::Private::pipe()\n> + */\n> +\n> /**\n> * \\fn Camera::Private::validator()\n> * \\brief Retrieve the control validator related to this camera\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A80A6BD80A\n\tfor ;\n\tWed, 11 Dec 2024 14:40:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D6DA67EB1;\n\tWed, 11 Dec 2024 15:40:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31C23618AE\n\tfor ;\n\tWed, 11 Dec 2024 15:40:28 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29D93352;\n\tWed, 11 Dec 2024 15:39:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MFFY8xum\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733927995;\n\tbh=vPPtxQrIJZg46EiZtrPh3Yi/CV4Uw8yDWSKm3a1iTkk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MFFY8xum17Px8WJJMJha/utWNLgYqm5qilaSnQIx6I2V3BO3baFVBHGovQ5ccjuHt\n\tY06biURxBdw+rKxDgVDQFfpmvxVgo6XDyhPDXDbSb/rpeTNaPjlhxDjwnTj+z0/0kI\n\tYvRejADtcVsni4EyN+P/RO5Y7pzx0g7t9zMNTf/g=","Date":"Wed, 11 Dec 2024 15:40:25 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 13/17] camera: Add a const version of the pipe()\n\tfunction","Message-ID":"","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>\n\t<20241206101344.767170-14-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241206101344.767170-14-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32700,"web_url":"https://patchwork.libcamera.org/comment/32700/","msgid":"","date":"2024-12-12T12:05:09","subject":"Re: [PATCH v3 13/17] camera: Add a const version of the pipe()\n\tfunction","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 06, 2024 at 11:13:35AM +0100, Stefan Klug wrote:\n> Allow access to the pipeline handler on a const instance of\n> Camera::Private.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> Changes in v3:\n> - Added this patch\n> ---\n> include/libcamera/internal/camera.h | 1 +\n> src/libcamera/camera.cpp | 5 +++++\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\n> index 0add0428bb5d..2bb00bbcb644 100644\n> --- a/include/libcamera/internal/camera.h\n> +++ b/include/libcamera/internal/camera.h\n> @@ -32,6 +32,7 @@ public:\n> \t~Private();\n> \n> \tPipelineHandler *pipe() { return pipe_.get(); }\n> +\tconst PipelineHandler *pipe() const { return pipe_.get(); }\n> \n> \tstd::list queuedRequests_;\n> \tControlInfoMap controlInfo_;\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 4c865a46af53..69a7ee5353f1 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -603,6 +603,11 @@ Camera::Private::~Private()\n> * \\return The pipeline handler that created this camera\n> */\n> \n> +/**\n> + * \\fn Camera::Private::pipe() const\n> + * \\copydoc Camera::Private::pipe()\n> + */\n> +\n> /**\n> * \\fn Camera::Private::validator()\n> * \\brief Retrieve the control validator related to this camera\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB66FBD80A\n\tfor ;\n\tThu, 12 Dec 2024 12:05:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 989E067ED4;\n\tThu, 12 Dec 2024 13:05:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8175567ED0\n\tfor ;\n\tThu, 12 Dec 2024 13:05:15 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:39eb:989c:b016:217b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 047B1316;\n\tThu, 12 Dec 2024 13:04:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mqD5JNAr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734005082;\n\tbh=zKVdyldjM4R3CfM5YWDsXTsQw7Lr1lEWM7b61veUtDg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mqD5JNArKipPOf3HsP4sqMfWtvsF4HHYgjHOwH30DDZ4V0cx133RObXhM3Qtq0c0X\n\tqYRVh79QCv8Z5OqqCIZTTM+y1dFgok1HSxNR4aKs6nSUKJ/ZLwEqAy0PfRIGoRuJMh\n\trjs6paMez5lJ98H3wSLyeqj0sYllFx71Huol9VZU=","Date":"Thu, 12 Dec 2024 21:05:09 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 13/17] camera: Add a const version of the pipe()\n\tfunction","Message-ID":"","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>\n\t<20241206101344.767170-14-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241206101344.767170-14-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]