[{"id":32699,"web_url":"https://patchwork.libcamera.org/comment/32699/","msgid":"","date":"2024-12-12T12:04:37","subject":"Re: [PATCH v3 12/17] libcamera: rkisp1: Enable the dewarper\n\tunconditionally","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Fri, Dec 06, 2024 at 11:13:34AM +0100, Stefan Klug wrote:\n> In configure() and in the future in generateConfiguration() the\n> calculated stream sizes and crop rectangles depend on the dewarper being\n> used or not. It is therefore not possible to postpone that decision\n> until the dewarper gets configured. Enable the dewarper unconditionally\n> if it is found and the stream type is not RAW.\n> \n> Signed-off-by: Stefan Klug \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 7f41092ee2d5..2c8d670768b1 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -865,7 +865,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\tif (dewarper_ && !isRaw_) {\n> \t\t\t\toutputCfgs.push_back(const_cast(cfg));\n> \t\t\t\tret = dewarper_->configure(cfg, outputCfgs);\n> -\t\t\t\tuseDewarper_ = ret ? false : true;\n> +\t\t\t\tif (ret)\n> +\t\t\t\t\treturn ret;\n> +\n> +\t\t\t\tuseDewarper_ = true;\n> \n> \t\t\t\t/*\n> \t\t\t\t * Calculate the crop rectangle of the data\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3675CBD80A\n\tfor ;\n\tThu, 12 Dec 2024 12:04:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D9CF767ED0;\n\tThu, 12 Dec 2024 13:04:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED72F608B6\n\tfor ;\n\tThu, 12 Dec 2024 13:04:44 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:39eb:989c:b016:217b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 367DF316;\n\tThu, 12 Dec 2024 13:04:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cH2ykFlE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734005051;\n\tbh=GDB067zZcqWq4oEx3k299TwkHahfQDVniY+pzFEJUv8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cH2ykFlEDawnpvtd+tC8/T3pfpVa9TZZRowPTht/Tsq8vIkovmM/vfy0tLEGo/G/x\n\tbnfymfktH+dsZzHTzqN77UMflpYcZJrI1icUzEAa5BZwhF52dDe6Y2EhjZtmURqqzA\n\ty/8/mN2BddQyU3iDRds17SaHE4QQ3tSftv1Lq1Pc=","Date":"Thu, 12 Dec 2024 21:04:37 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tJacopo Mondi ","Subject":"Re: [PATCH v3 12/17] libcamera: rkisp1: Enable the dewarper\n\tunconditionally","Message-ID":"","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>\n\t<20241206101344.767170-13-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241206101344.767170-13-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]