[{"id":32677,"web_url":"https://patchwork.libcamera.org/comment/32677/","msgid":"","date":"2024-12-11T14:39:54","subject":"Re: [PATCH v3 08/17] pipeline: rkisp1: Add ScalerMaximumCrop\n\tproperty","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Fri, Dec 06, 2024 at 11:13:30AM +0100, Stefan Klug wrote:\n> The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\n> value. Add it to the rkisp1.\n>\n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> ---\n> Changes in v2:\n> - Moved one hunk to the correct patch 6/7\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index ad556ec85a2c..098c560ca5c8 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -24,6 +24,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -1245,6 +1246,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n> \t\t\t\t\t\t\t scalerMaxCrop_,\n> \t\t\t\t\t\t\t scalerMaxCrop_);\n> +\t\tdata->properties_.set(properties::ScalerCropMaximum, scalerMaxCrop_);\n> \t\tactiveCrop_ = scalerMaxCrop_;\n> \t}\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FDD7BD80A\n\tfor ;\n\tWed, 11 Dec 2024 14:40:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 843DE67EB0;\n\tWed, 11 Dec 2024 15:39:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57D95618AE\n\tfor ;\n\tWed, 11 Dec 2024 15:39:57 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3404A352;\n\tWed, 11 Dec 2024 15:39:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fmA2PG0P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733927964;\n\tbh=Dk1MiiG7KjMEONZqtyiz+t8JTv7MBRYPuq5kAUcF1QQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fmA2PG0PKom2zhOInsll7aeFo8/aFIarSzvjdyWqCnqLTQkam2Zk1QlKnWKOe7hiS\n\t4KMvET2r++2As9BIW6WfzIs4WIHKpKz/FkAKiwWKLvb2WzrMuX3JIfrdXbYwOmYmo2\n\t9AIjLnWDhe+eBKO+Xu7FLuY12BNRSWnPDIZf5U5A=","Date":"Wed, 11 Dec 2024 15:39:54 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPaul Elder ","Subject":"Re: [PATCH v3 08/17] pipeline: rkisp1: Add ScalerMaximumCrop\n\tproperty","Message-ID":"","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>\n\t<20241206101344.767170-9-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241206101344.767170-9-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]