{"id":222,"url":"https://patchwork.libcamera.org/api/patches/222/?format=json","web_url":"https://patchwork.libcamera.org/patch/222/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190114095417.16473-2-kieran.bingham@ideasonboard.com>","date":"2019-01-14T09:54:16","name":"[libcamera-devel,RFC,1/2] test: Add TestStatus classes","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"278dcb8d534543f6c5011d7aa4f1eee8bb0baf00","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/222/mbox/","series":[{"id":76,"url":"https://patchwork.libcamera.org/api/series/76/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=76","date":"2019-01-14T09:54:15","name":"Test Status Refactoring","version":1,"mbox":"https://patchwork.libcamera.org/series/76/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/222/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/222/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E32DD60C6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jan 2019 10:54:21 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69ABB530;\n\tMon, 14 Jan 2019 10:54:21 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547459661;\n\tbh=/fE6aOUSI0e6XdN7rveyCnhQUi+6lY5g4WPeeWxslfU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=krLlo4N828lspLQajS+crGUA/17rsqzX+7AKuzkfngKAgvIXO+uc1Nbbe0vPWRB7w\n\t4+fahGuKSZy42DpV+E+LCIn1liZ4wdKNJATWgxKA0bI3g7u1GoZmYgb+nfuUOoGaco\n\tsSKwXHr/BAhKtBCblEV7JoI88rwNzWMKsfPCfhIk=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Mon, 14 Jan 2019 09:54:16 +0000","Message-Id":"<20190114095417.16473-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","In-Reply-To":"<20190114095417.16473-1-kieran.bingham@ideasonboard.com>","References":"<20190114095417.16473-1-kieran.bingham@ideasonboard.com>","Subject":"[libcamera-devel] [PATCH RFC 1/2] test: Add TestStatus classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 14 Jan 2019 09:54:22 -0000"},"content":"Provide Class object to return the test status, and perform any result reporting.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n test/libtest/meson.build     |  1 +\n test/libtest/test.h          |  2 ++\n test/libtest/test_status.cpp | 42 +++++++++++++++++++++++++++\n test/libtest/test_status.h   | 55 ++++++++++++++++++++++++++++++++++++\n 4 files changed, 100 insertions(+)\n create mode 100644 test/libtest/test_status.cpp\n create mode 100644 test/libtest/test_status.h","diff":"diff --git a/test/libtest/meson.build b/test/libtest/meson.build\nindex e0893b70c3d4..a9e67d8d7e6c 100644\n--- a/test/libtest/meson.build\n+++ b/test/libtest/meson.build\n@@ -1,5 +1,6 @@\n libtest_sources = files([\n     'test.cpp',\n+    'test_status.cpp',\n ])\n \n libtest = static_library('libtest', libtest_sources)\ndiff --git a/test/libtest/test.h b/test/libtest/test.h\nindex ec08bf97c03d..d816cf15aaf0 100644\n--- a/test/libtest/test.h\n+++ b/test/libtest/test.h\n@@ -9,6 +9,8 @@\n \n #include <sstream>\n \n+#include \"test_status.h\"\n+\n enum TestStatus {\n \tTestPass = 0,\n \tTestFail = -1,\ndiff --git a/test/libtest/test_status.cpp b/test/libtest/test_status.cpp\nnew file mode 100644\nindex 000000000000..c0daef866740\n--- /dev/null\n+++ b/test/libtest/test_status.cpp\n@@ -0,0 +1,42 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * test_status.cpp - libcamera test result management\n+ */\n+\n+#include \"test.h\"\n+\n+static unsigned int test_number = 0;\n+\n+TestStatusBase::TestStatusBase()\n+\t: value(-99)\n+{\n+\ttest_number++;\n+};\n+\n+TestStatusBase::~TestStatusBase()\n+{\n+\tstd::cout << prefix << test_number << \" \" << message << std::endl;\n+};\n+\n+TestStatusPass::TestStatusPass(const std::string &m)\n+{\n+\tvalue = ValuePass;\n+\tprefix = \"ok \";\n+\tmessage = m;\n+};\n+\n+TestStatusFail::TestStatusFail(const std::string &m)\n+{\n+\tvalue = ValueFail;\n+\tprefix = \"not ok \";\n+\tmessage = m;\n+};\n+\n+TestStatusSkip::TestStatusSkip(const std::string &m)\n+{\n+\tvalue = ValueSkip;\n+\tprefix = \"skip \";\n+\tmessage = m;\n+};\ndiff --git a/test/libtest/test_status.h b/test/libtest/test_status.h\nnew file mode 100644\nindex 000000000000..2e4713ad3f6d\n--- /dev/null\n+++ b/test/libtest/test_status.h\n@@ -0,0 +1,55 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * test_status.h - libcamera test status class\n+ */\n+#ifndef __TEST_TEST_STATUS_H__\n+#define __TEST_TEST_STATUS_H__\n+\n+#include <iostream>\n+#include <string>\n+\n+class TestStatusBase\n+{\n+public:\n+\tTestStatusBase();\n+\tTestStatusBase(const std::string &m);\n+\t~TestStatusBase();\n+\n+\toperator int() { return value; };\n+\n+\tenum ReturnValues {\n+\t\tValuePass = 0,\n+\t\tValueFail = -1,\n+\t\tValueSkip = 77,\n+\t};\n+\n+protected:\n+\tint value;\n+\tstd::string prefix;\n+\tstd::string message;\n+};\n+\n+class TestStatusPass : public TestStatusBase\n+{\n+public:\n+\tTestStatusPass(const std::string &m);\n+};\n+\n+class TestStatusFail : public TestStatusBase\n+{\n+public:\n+\tTestStatusFail(const std::string &m);\n+};\n+\n+class TestStatusSkip : public TestStatusBase\n+{\n+public:\n+\tTestStatusSkip(const std::string &m);\n+};\n+\n+#define is(a, b, m) ({((a) == (b)) ? TestStatusPass((m)) : TestStatusFail((m));})\n+#define isnt(a, b, m) ({((a) != (b)) ? TestStatusPass((m)) : TestStatusFail((m));})\n+\n+#endif /* __TEST_TEST_STATUS_H__ */\n","prefixes":["libcamera-devel","RFC","1/2"]}