{"id":22193,"url":"https://patchwork.libcamera.org/api/patches/22193/?format=json","web_url":"https://patchwork.libcamera.org/patch/22193/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241206101344.767170-2-stefan.klug@ideasonboard.com>","date":"2024-12-06T10:13:23","name":"[v3,01/17] libcamera: rkisp1: Fix scope of dewarper stop() exit action","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"61e258ccfc4ca6185a3766861e8895540cc63f3e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22193/mbox/","series":[{"id":4854,"url":"https://patchwork.libcamera.org/api/series/4854/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4854","date":"2024-12-06T10:13:22","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":3,"mbox":"https://patchwork.libcamera.org/series/4854/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22193/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22193/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 71E7BBF415\n\tfor ;\n\tFri, 6 Dec 2024 10:13:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 215BC66121;\n\tFri, 6 Dec 2024 11:13:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9BF966121\n\tfor ;\n\tFri, 6 Dec 2024 11:13:51 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28A3374C;\n\tFri, 6 Dec 2024 11:13:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jv44pKlZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733480002;\n\tbh=1aGKYMCKt5K+IXdrsLHVElOYWh2VWsVZUQHcG7tgHOc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Jv44pKlZeViSx3euygHTcKGLkc7mcaAroE95XelK/r6rChxcwIJpnV1vPCYwePxXw\n\tTR6c280XKaeGmkubpEyOw5dR1vlFIoziZyDc2ea3fgh9lyp5ItVG2FyGsRSeVRqH/C\n\tfKU/EsnHjPeW3HUAyR4x4BCjpYerDgYF8iCdVyIs=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tPaul Elder ,\n\tJacopo Mondi ","Subject":"[PATCH v3 01/17] libcamera: rkisp1: Fix scope of dewarper stop()\n\texit action","Date":"Fri, 6 Dec 2024 11:13:23 +0100","Message-ID":"<20241206101344.767170-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","References":"<20241206101344.767170-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Move the definition of the dewarper stop() action into the scope were\nthe corresponding start() happens.\n\nFixes: 12b553d691d4 (\"libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\")\nSigned-off-by: Stefan Klug \nReviewed-by: Paul Elder \nReviewed-by: Jacopo Mondi \n\n---\nChanges in v3:\n- Removed blank line from commit message\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 908724e20975..8b92fdebdd63 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1044,8 +1044,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL\n \t\t\t\tLOG(RkISP1, Error) << \"Failed to start dewarper\";\n \t\t\t\treturn ret;\n \t\t\t}\n+\t\t\tactions += [&]() { dewarper_->stop(); };\n \t\t}\n-\t\tactions += [&]() { dewarper_->stop(); };\n \t}\n \n \tif (data->mainPath_->isEnabled()) {\n","prefixes":["v3","01/17"]}