[{"id":32561,"web_url":"https://patchwork.libcamera.org/comment/32561/","msgid":"<173344563610.1906024.13079287892283171470@ping.linuxembedded.co.uk>","date":"2024-12-06T00:40:36","subject":"Re: [PATCH resend 3/5] libcamera: swstats_cpu: Move header to\n\tlibcamera/internal/software_isp","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2024-12-05 19:25:17)\n> Move the swstats_cpu.h file to include/libcamera/internal/software_isp/\n> so that it can be used outside the src/libcamera/software_isp/ directory.\n> \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Hans de Goede \n> ---\n> include/libcamera/internal/software_isp/meson.build | 1 +\n> .../libcamera/internal}/software_isp/swstats_cpu.h | 0\n> src/libcamera/software_isp/debayer_cpu.h | 2 +-\n> src/libcamera/software_isp/swstats_cpu.cpp | 2 +-\n> 4 files changed, 3 insertions(+), 2 deletions(-)\n> rename {src/libcamera => include/libcamera/internal}/software_isp/swstats_cpu.h (100%)\n> \n> diff --git a/include/libcamera/internal/software_isp/meson.build b/include/libcamera/internal/software_isp/meson.build\n> index 508ddddc..ea3f3f1c 100644\n> --- a/include/libcamera/internal/software_isp/meson.build\n> +++ b/include/libcamera/internal/software_isp/meson.build\n> @@ -4,4 +4,5 @@ libcamera_internal_headers += files([\n> 'debayer_params.h',\n> 'software_isp.h',\n> 'swisp_stats.h',\n> + 'swstats_cpu.h',\n> ])\n> diff --git a/src/libcamera/software_isp/swstats_cpu.h b/include/libcamera/internal/software_isp/swstats_cpu.h\n> similarity index 100%\n> rename from src/libcamera/software_isp/swstats_cpu.h\n> rename to include/libcamera/internal/software_isp/swstats_cpu.h\n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index 2c47e7c6..feb0452e 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -18,9 +18,9 @@\n> #include \n> \n> #include \"libcamera/internal/bayer_format.h\"\n> +#include \"libcamera/internal/software_isp/swstats_cpu.h\"\n> \n> #include \"debayer.h\"\n> -#include \"swstats_cpu.h\"\n> \n> namespace libcamera {\n> \n> diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\n> index 5e4246a9..aa5654dc 100644\n> --- a/src/libcamera/software_isp/swstats_cpu.cpp\n> +++ b/src/libcamera/software_isp/swstats_cpu.cpp\n> @@ -9,7 +9,7 @@\n> * CPU based software statistics implementation\n> */\n> \n> -#include \"swstats_cpu.h\"\n> +#include \"libcamera/internal/software_isp/swstats_cpu.h\"\n> \n> #include \n> \n> -- \n> 2.47.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 697C2BDB1C\n\tfor ;\n\tFri, 6 Dec 2024 00:40:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD314660C8;\n\tFri, 6 Dec 2024 01:40:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 585E1660C8\n\tfor ;\n\tFri, 6 Dec 2024 01:40:39 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 462D716A;\n\tFri, 6 Dec 2024 01:40:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kkmwiSYP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733445610;\n\tbh=c/PshteW8fQIDUIJKUQkjLfehPR/4UKuw7Q13ZMrbRs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=kkmwiSYPj9bU9HWfb5iFULpDf1AngjJ+SzrCEuJMNEt+CA+0aBH6fvR+4qlYHKbYk\n\tEKea4d8Ht9gT9Noc1eT1piuj6eF0ijgElB6UNVKzPzvMffTR1NnqE8njF7xbBjzvIL\n\t3ojEAUYYG61ZsJ3pxFIXoPe3z4QGQt00OKVde1Co=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241205192519.49104-4-hdegoede@redhat.com>","References":"<20241205192519.49104-1-hdegoede@redhat.com>\n\t<20241205192519.49104-4-hdegoede@redhat.com>","Subject":"Re: [PATCH resend 3/5] libcamera: swstats_cpu: Move header to\n\tlibcamera/internal/software_isp","From":"Kieran Bingham ","Cc":"Milan Zamazal , Hans de Goede ","To":"Hans de Goede , libcamera-devel@lists.libcamera.org","Date":"Fri, 06 Dec 2024 00:40:36 +0000","Message-ID":"<173344563610.1906024.13079287892283171470@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]