[{"id":32539,"web_url":"https://patchwork.libcamera.org/comment/32539/","msgid":"<20241205122345.GC20214@pendragon.ideasonboard.com>","date":"2024-12-05T12:23:45","subject":"Re: [PATCH] libcamera: stream: Add operator<<(StreamConfiguration)","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Dec 05, 2024 at 12:23:13PM +0100, Jacopo Mondi wrote:\n> The StreamConfiguration class only implements toString() but doesn't\n> offer an overload of operator<<() which is more convenient to use.\n> \n> Add an overload for operator<<(StreamConfiguration) which is based on\n> the usage of StreamConfiguration::toString().\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/stream.h | 2 ++\n> src/libcamera/stream.cpp | 13 +++++++++++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index 071b71698acb..ea228aea7d56 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -61,6 +61,8 @@ private:\n> \tStreamFormats formats_;\n> };\n> \n> +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n> +\n> enum class StreamRole {\n> \tRaw,\n> \tStillCapture,\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 1f75dbbc5b64..a093abf48c7c 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -395,6 +395,19 @@ std::string StreamConfiguration::toString() const\n> \treturn size.toString() + \"-\" + pixelFormat.toString();\n> }\n> \n> +/**\n> + * \\brief Insert a text representation of a StreamConfiguration into an output\n> + * stream\n> + * \\param[in] out The output stream\n> + * \\param[in] cfg The StreamConfiguration\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n> +{\n> +\tout << cfg.toString();\n> +\treturn out;\n> +}\n\nWould it be more efficient to instead implement toString() on top of\noperator<<(), like we do for the Request class for instance ?\n\n> +\n> /**\n> * \\enum StreamRole\n> * \\brief Identify the role a stream is intended to play","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4162FBDB1C\n\tfor ;\n\tThu, 5 Dec 2024 12:24:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63771660F3;\n\tThu, 5 Dec 2024 13:23:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1C146608C\n\tfor ;\n\tThu, 5 Dec 2024 13:23:57 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 032103E;\n\tThu, 5 Dec 2024 13:23:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YNaXOYP2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733401409;\n\tbh=axD8zRKUAa39cwTDFo0xo6Vbyo4JVb9Vd6320PNXCGs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YNaXOYP2ZdfL/E4wJ/MhgXvZJR4K8/8g5zMgMJtWiLSRv+uS/J7n+yEq6t9mCVZnv\n\tm/DPCG/S2dUY5ZpOG5PK/IukxrSb4NhWPJx7hlAVP6+ncNIttfaJrRE0R+JxhivX40\n\tncbvGM8TZ3/723mvP3q2O50gjm/0cs+8teHF/IVo=","Date":"Thu, 5 Dec 2024 14:23:45 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: stream: Add operator<<(StreamConfiguration)","Message-ID":"<20241205122345.GC20214@pendragon.ideasonboard.com>","References":"<20241205112314.26296-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241205112314.26296-1-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32596,"web_url":"https://patchwork.libcamera.org/comment/32596/","msgid":"<7syuuwagxrb6pt75mj3qfwm4czvivtqml7mikmhqjqytfbevxm@hlvawzuc2xwb>","date":"2024-12-06T16:15:01","subject":"Re: [PATCH] libcamera: stream: Add operator<<(StreamConfiguration)","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Laurent\n\nOn Thu, Dec 05, 2024 at 02:23:45PM +0200, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Thu, Dec 05, 2024 at 12:23:13PM +0100, Jacopo Mondi wrote:\n> > The StreamConfiguration class only implements toString() but doesn't\n> > offer an overload of operator<<() which is more convenient to use.\n> >\n> > Add an overload for operator<<(StreamConfiguration) which is based on\n> > the usage of StreamConfiguration::toString().\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/stream.h | 2 ++\n> > src/libcamera/stream.cpp | 13 +++++++++++++\n> > 2 files changed, 15 insertions(+)\n> >\n> > diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> > index 071b71698acb..ea228aea7d56 100644\n> > --- a/include/libcamera/stream.h\n> > +++ b/include/libcamera/stream.h\n> > @@ -61,6 +61,8 @@ private:\n> > \tStreamFormats formats_;\n> > };\n> >\n> > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg);\n> > +\n> > enum class StreamRole {\n> > \tRaw,\n> > \tStillCapture,\n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index 1f75dbbc5b64..a093abf48c7c 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -395,6 +395,19 @@ std::string StreamConfiguration::toString() const\n> > \treturn size.toString() + \"-\" + pixelFormat.toString();\n> > }\n> >\n> > +/**\n> > + * \\brief Insert a text representation of a StreamConfiguration into an output\n> > + * stream\n> > + * \\param[in] out The output stream\n> > + * \\param[in] cfg The StreamConfiguration\n> > + * \\return The output stream \\a out\n> > + */\n> > +std::ostream &operator<<(std::ostream &out, StreamConfiguration cfg)\n> > +{\n> > +\tout << cfg.toString();\n> > +\treturn out;\n> > +}\n>\n> Would it be more efficient to instead implement toString() on top of\n> operator<<(), like we do for the Request class for instance ?\n>\n\nMore efficiant I'm not sure, if it's more consistent I can do that.\n\n> > +\n> > /**\n> > * \\enum StreamRole\n> > * \\brief Identify the role a stream is intended to play\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF391BF415\n\tfor ;\n\tFri, 6 Dec 2024 16:15:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C757D67E23;\n\tFri, 6 Dec 2024 17:15:06 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C00F67E17\n\tfor ;\n\tFri, 6 Dec 2024 17:15:05 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 415AE641;\n\tFri, 6 Dec 2024 17:14:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"teqo7EhL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733501675;\n\tbh=2WYjB8Anf1DEIvsdvigWJwZHFJWWxzsmA1bUvRSV8i0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=teqo7EhLawiJDp+pb7G6acSp5CJoRaCCDpO8otSrUT3qIa5Kbs9xXsbh3kt0rvriX\n\tqOv+d5ubITuHj8mu5z48E8cfBQw56fkfBqPnwf7uQ+QynrEkvrGR7GEPOexVQQ8Xz5\n\tkoPQ2KDCGKyl7741HfFShnMhZjbc2Bx0KQut91aw=","Date":"Fri, 6 Dec 2024 17:15:01 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: stream: Add operator<<(StreamConfiguration)","Message-ID":"<7syuuwagxrb6pt75mj3qfwm4czvivtqml7mikmhqjqytfbevxm@hlvawzuc2xwb>","References":"<20241205112314.26296-1-jacopo.mondi@ideasonboard.com>\n\t<20241205122345.GC20214@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241205122345.GC20214@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]