[{"id":32647,"web_url":"https://patchwork.libcamera.org/comment/32647/","msgid":"<20241210023957.GI26531@pendragon.ideasonboard.com>","date":"2024-12-10T02:39:57","subject":"Re: [PATCH v4 4/8] test: ipa_data_serialization: Use\n\tDebugMetadataEnable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Thu, Dec 05, 2024 at 08:22:37PM +0900, Paul Elder wrote:\n> From: Jacopo Mondi \n> \n> Replace the deprecated AeEnable control with DebugMetadataEnable\n> in ipa_data_serialization test. We use DebugMetadataEnable instead of\n> one of the controls replacing AeEnable as they are not boolean controls.\n> \n> Signed-off-by: Jacopo Mondi \n> Signed-off-by: Paul Elder \n> Reviewed-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Changes in v4:\n> - s/ExposureTimeMode/DebugMetadataEnable/\n> \n> No change in v3\n> ---\n> test/serialization/ipa_data_serializer_test.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index aea63c73187e..afea93a6c24d 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -29,7 +29,7 @@ using namespace std;\n> using namespace libcamera;\n> \n> static const ControlInfoMap Controls = ControlInfoMap({\n> -\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t\t{ &controls::DebugMetadataEnable, ControlInfo(false, true) },\n> \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E0B5BD80A\n\tfor ;\n\tTue, 10 Dec 2024 02:40:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB53467E7E;\n\tTue, 10 Dec 2024 03:40:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F73667E77\n\tfor ;\n\tTue, 10 Dec 2024 03:40:12 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11E596EC;\n\tTue, 10 Dec 2024 03:39:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eiBk5zEw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733798380;\n\tbh=lYiN+cplzLd4ygL0h5lIoiWp3y3uTwhE3ULH2fAALbY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eiBk5zEwWW2Jw/HHpvV83O1bt+zcpvKNy9kKhkKl6rVhVTjJSr5kSM1urH6Mep/LE\n\tIDHaPl5G2Edtisg9zUYmXLbvmMIrOKXiSP3jy7TMWPRN4eKHwNAqVMdXTHqBc+iP5c\n\txjj3ZGMOLKZ2wP1UQzhHgkv55gXxkWaVVEqVx19w=","Date":"Tue, 10 Dec 2024 04:39:57 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org, Jacopo Mondi ","Subject":"Re: [PATCH v4 4/8] test: ipa_data_serialization: Use\n\tDebugMetadataEnable","Message-ID":"<20241210023957.GI26531@pendragon.ideasonboard.com>","References":"<20241205112241.641964-1-paul.elder@ideasonboard.com>\n\t<20241205112241.641964-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241205112241.641964-5-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]