[{"id":32555,"web_url":"https://patchwork.libcamera.org/comment/32555/","msgid":"<20241205202509.GI21014@pendragon.ideasonboard.com>","date":"2024-12-05T20:25:09","subject":"Re: [PATCH v2 1/2] libcamera: utils: StringSplitter: Inline some\n\ttrivial methods","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Thu, Dec 05, 2024 at 09:23:00AM +0000, Barnabás Pőcze wrote:\n> Inline some of the more trivial methods so that they can\n> be inlined by the compiler.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/base/utils.h | 17 ++++++++++++++---\n> src/libcamera/base/utils.cpp | 15 ---------------\n> 2 files changed, 14 insertions(+), 18 deletions(-)\n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 957150cb..c4a06660 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -204,7 +204,11 @@ public:\n> \n> \t\titerator &operator++();\n> \t\tstd::string operator*() const;\n> -\t\tbool operator!=(const iterator &other) const;\n> +\n> +\t\tbool operator!=(const iterator &other) const\n> +\t\t{\n> +\t\t\treturn pos_ != other.pos_;\n> +\t\t}\n> \n> \tprivate:\n> \t\tconst StringSplitter *ss_;\n> @@ -212,8 +216,15 @@ public:\n> \t\tstd::string::size_type next_;\n> \t};\n> \n> -\titerator begin() const;\n> -\titerator end() const;\n> +\titerator begin() const\n> +\t{\n> +\t\treturn { this, 0 };\n> +\t}\n> +\n> +\titerator end() const\n> +\t{\n> +\t\treturn { this, std::string::npos };\n> +\t}\n> \n> private:\n> \tstd::string str_;\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 67e5a896..bcfc1941 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -276,21 +276,6 @@ std::string details::StringSplitter::iterator::operator*() const\n> \treturn ss_->str_.substr(pos_, count);\n> }\n> \n> -bool details::StringSplitter::iterator::operator!=(const details::StringSplitter::iterator &other) const\n> -{\n> -\treturn pos_ != other.pos_;\n> -}\n> -\n> -details::StringSplitter::iterator details::StringSplitter::begin() const\n> -{\n> -\treturn iterator(this, 0);\n> -}\n> -\n> -details::StringSplitter::iterator details::StringSplitter::end() const\n> -{\n> -\treturn iterator(this, std::string::npos);\n> -}\n> -\n> /**\n> * \\fn template \\\n> * std::string utils::join(const Container &items, const std::string &sep, UnaryOp op)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DEF0BF415\n\tfor ;\n\tThu, 5 Dec 2024 20:25:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53F506611A;\n\tThu, 5 Dec 2024 21:25:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C3FF66112\n\tfor ;\n\tThu, 5 Dec 2024 21:25:22 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 259A17E2;\n\tThu, 5 Dec 2024 21:24:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bo1lInUY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733430293;\n\tbh=Ks+4jStwgKDheHSvW3PqSDTyq2BGb8bcrZauocQKuXc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Bo1lInUYxRbi3qBH2+7BpCZ2JtXnmCvFWQtSV0p2ZfAYxefbewow8zIxkohA/tNMg\n\tbNl0T2wHFK48IRD9z5MbNEJs/LvDcyoHs4B336s29FjMuXNFKInhLY3bK0wCqAkq7I\n\tdVyKxutG9YedkQA8E+DkUV19wtl+AOPHU67bNYo8=","Date":"Thu, 5 Dec 2024 22:25:09 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/2] libcamera: utils: StringSplitter: Inline some\n\ttrivial methods","Message-ID":"<20241205202509.GI21014@pendragon.ideasonboard.com>","References":"<20241205092258.1058077-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241205092258.1058077-1-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]