{"id":22161,"url":"https://patchwork.libcamera.org/api/patches/22161/?format=json","web_url":"https://patchwork.libcamera.org/patch/22161/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241204145422.968446-1-pobrn@protonmail.com>","date":"2024-12-04T14:54:24","name":"[v1] libcamera: utils: StringSplitter: Add `operator==`","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fec05e81e4f4024976757e1eb55a6a5dab26f62f","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22161/mbox/","series":[{"id":4846,"url":"https://patchwork.libcamera.org/api/series/4846/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4846","date":"2024-12-04T14:54:24","name":"[v1] libcamera: utils: StringSplitter: Add `operator==`","version":1,"mbox":"https://patchwork.libcamera.org/series/4846/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22161/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22161/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F059BDB1C\n\tfor ;\n\tWed, 4 Dec 2024 14:54:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E08B660C4;\n\tWed, 4 Dec 2024 15:54:30 +0100 (CET)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB2D5618B5\n\tfor ;\n\tWed, 4 Dec 2024 15:54:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"spgumTDs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1733324067; x=1733583267;\n\tbh=fTh3FAqvhUpwyqo2FPJE13W5KzYBU2KF0EN0Tr9cG14=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=spgumTDsLcMq5JyUiQWUDk/n3SLi4RQ/uEjhmllHBj+yVF/kVy7OTpSBdipqLX2DJ\n\t6ZpMCbMuQtisWGTUogDdVfZUdVKlNefaVdmOevxQbrQ64EvCFM1KpLokNJWUW0nrX/\n\tP/nPyZKdme8Ejk+W3rf1YjtmY5TWo5NA/ebW1ChNTaki7rO0f4zdLOrSF9yMzCMHNV\n\tcXVjyapVxjcnpR8JmJ3mEK0I5vmvzLGp6ybN1/FF1JLXn/5MV9RXt02H8a4luiTfDn\n\tT8wB7RfKJNwWKVrY6xAkXPIpagycRr1v0vOAG/XBt7Elvk+aRlgi4nIU2X2ZnoJ3uW\n\tTtPerZqhI2CXw==","Date":"Wed, 04 Dec 2024 14:54:24 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1] libcamera: utils: StringSplitter: Add `operator==`","Message-ID":"<20241204145422.968446-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"0ad3ab9295967ff9928b42c964f34074dbc0d68f","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If `cpp_debugstl=true` in the build configuration, then libstdc++ will\ntry to use `operator==` and the build will fail.\n\nImplement `operator==` in terms of `operator!=` to avoid the build failure.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/base/utils.h | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 957150cb..782d5c97 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -205,6 +205,10 @@ public:\n \t\titerator &operator++();\n \t\tstd::string operator*() const;\n \t\tbool operator!=(const iterator &other) const;\n+\t\tbool operator==(const iterator &other) const\n+\t\t{\n+\t\t\treturn !(*this != other);\n+\t\t}\n \n \tprivate:\n \t\tconst StringSplitter *ss_;\n","prefixes":["v1"]}