{"id":22160,"url":"https://patchwork.libcamera.org/api/patches/22160/?format=json","web_url":"https://patchwork.libcamera.org/patch/22160/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241204111017.343760-1-stefan.klug@ideasonboard.com>","date":"2024-12-04T11:10:13","name":"libcamera: yaml_parser: Output more details when parsing fails","commit_ref":"fa0013c953b488ae421e66c0de726bf351072589","pull_url":null,"state":"accepted","archived":false,"hash":"7a9e5c31380653feac9ee7eed3b5d8ef22570864","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22160/mbox/","series":[{"id":4845,"url":"https://patchwork.libcamera.org/api/series/4845/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4845","date":"2024-12-04T11:10:13","name":"libcamera: yaml_parser: Output more details when parsing fails","version":1,"mbox":"https://patchwork.libcamera.org/series/4845/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22160/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22160/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75A49BDB13\n\tfor ;\n\tWed, 4 Dec 2024 11:10:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F610618B5;\n\tWed, 4 Dec 2024 12:10:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B7D9F618B5\n\tfor ;\n\tWed, 4 Dec 2024 12:10:21 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9f48:37c3:24be:426d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FB6FB2B;\n\tWed, 4 Dec 2024 12:09:53 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Riu9pgtW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733310593;\n\tbh=6AwESIuz7ykjlck03k727WR/pQPVsoRXjWoCd5no3oU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Riu9pgtW7JK9oh8vcRnfZ8R19WMrQBMQOeyOyStkYmrmrvOohrYey9pgu1gy3VH4A\n\tas9PzTzCywYIn/neCY7CGN9Zh1KHBcX7Le+HAvJXCI6v/lBLxvEF8RU5PHVJ5+RFG7\n\tPBbDlfOtndVsLUbKFmG8d8deUmtFN/eLHV2XSz2I=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH] libcamera: yaml_parser: Output more details when parsing\n\tfails","Date":"Wed, 4 Dec 2024 12:10:13 +0100","Message-ID":"<20241204111017.343760-1-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"On malformed yaml files, the yaml parser only errors out without giving\ndetails on the error that happened. Fix that by providing a more detailed\nerror message.\n\nOutput old:\n\nERROR YamlParser yaml_parser.cpp:886 Failed to parse YAML content from /root/imx283.yaml\n\nOutput new:\n\nERROR YamlParser yaml_parser.cpp:627 /root/imx283.yaml:72:8 could not find expected ':' while scanning a simple key\nERROR YamlParser yaml_parser.cpp:886 Failed to parse YAML content from /root/imx283.yaml\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/yaml_parser.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex db256ec5b04d..f9302c4ee3fa 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -509,8 +509,17 @@ YamlParserContext::EventPtr YamlParserContext::nextEvent()\n \tEventPtr event(new yaml_event_t);\n \n \t/* yaml_parser_parse returns 1 when it succeeds */\n-\tif (!yaml_parser_parse(&parser_, event.get()))\n+\tif (!yaml_parser_parse(&parser_, event.get())) {\n+\t\tFile *file = static_cast(parser_.read_handler_data);\n+\n+\t\tLOG(YamlParser, Error) << file->fileName() << \":\"\n+\t\t\t\t << parser_.problem_mark.line << \":\"\n+\t\t\t\t << parser_.problem_mark.column << \" \"\n+\t\t\t\t << parser_.problem << \" \"\n+\t\t\t\t << parser_.context;\n+\n \t\treturn nullptr;\n+\t}\n \n \treturn event;\n }\n","prefixes":[]}