[{"id":32507,"web_url":"https://patchwork.libcamera.org/comment/32507/","msgid":"<93489dbd-bb39-4280-ab2f-d0200d8f2383@ideasonboard.com>","date":"2024-12-04T10:23:33","subject":"Re: [PATCH] libipa: agc_mean_luminance: Rename yaml key from\n\texposure-time to exposureTime","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Stefan\n\nOn 04/12/2024 10:21, Stefan Klug wrote:\n> In d0478c41f432 (\"libcamera: Rename \"shutter speed\" to \"exposure time\"\")\n> the tuning file entry \"shutter\" was renamed to \"exposure-time\". As the\n> tuning files use camel cased key names, change \"exposure-time\" to\n> \"exposureTime\" for consitency. It doesn't break our users setups as\ns/consitency/consistency\n> there are no tuning files using that entry in the wild (at least\n> officially).\n>\n> Signed-off-by: Stefan Klug \nReviewed-by: Daniel Scally \n> ---\n> src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++----\n> utils/tuning/libtuning/modules/agc/rkisp1.py | 4 ++--\n> 2 files changed, 6 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\n> index cd17570861e9..02555a44d271 100644\n> --- a/src/ipa/libipa/agc_mean_luminance.cpp\n> +++ b/src/ipa/libipa/agc_mean_luminance.cpp\n> @@ -248,7 +248,7 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> \t\t\t}\n> \n> \t\t\tstd::vector exposureTimes =\n> -\t\t\t\tmodeValues[\"exposure-time\"].getList().value_or(std::vector{});\n> +\t\t\t\tmodeValues[\"exposureTime\"].getList().value_or(std::vector{});\n> \t\t\tstd::vector gains =\n> \t\t\t\tmodeValues[\"gain\"].getList().value_or(std::vector{});\n> \n> @@ -338,7 +338,7 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> * For the AeExposureMode control the data should contain a dictionary called\n> * AeExposureMode containing per-mode setting dictionaries with the key being a\n> * value from \\ref controls::AeExposureModeNameValueMap. Each mode dict should\n> - * contain an array of exposure times with the key \"exposure-time\" and an array\n> + * contain an array of exposure times with the key \"exposureTime\" and an array\n> * of gain values with the key \"gain\", in this format:\n> *\n> * \\code{.unparsed}\n> @@ -346,10 +346,10 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> * - Agc:\n> * AeExposureMode:\n> * ExposureNormal:\n> - * exposure-time: [ 100, 10000, 30000, 60000, 120000 ]\n> + * exposureTime: [ 100, 10000, 30000, 60000, 120000 ]\n> * gain: [ 2.0, 4.0, 6.0, 8.0, 10.0 ]\n> * ExposureShort:\n> - * exposure-time: [ 100, 10000, 30000, 60000, 120000 ]\n> + * exposureTime: [ 100, 10000, 30000, 60000, 120000 ]\n> * gain: [ 2.0, 4.0, 6.0, 8.0, 10.0 ]\n> *\n> * \\endcode\n> diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> index 1a4dbe7b416a..2dad3a09cecb 100644\n> --- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n> +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> @@ -47,9 +47,9 @@ class AGCRkISP1(AGC):\n> }\n> \n> def _generate_exposure_modes(self) -> dict:\n> - normal = {'exposure-time': [100, 10000, 30000, 60000, 120000],\n> + normal = {'exposureTime': [100, 10000, 30000, 60000, 120000],\n> 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n> - short = {'exposure-time': [100, 5000, 10000, 20000, 120000],\n> + short = {'exposureTime': [100, 5000, 10000, 20000, 120000],\n> 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n> \n> return {'ExposureNormal': normal, 'ExposureShort': short}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 585A3BDB1C\n\tfor ;\n\tWed, 4 Dec 2024 10:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 120EC660A9;\n\tWed, 4 Dec 2024 11:23:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADC5E6609E\n\tfor ;\n\tWed, 4 Dec 2024 11:23:36 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A48EB6D6\n\tfor ;\n\tWed, 4 Dec 2024 11:23:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rx20foFA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733307788;\n\tbh=xV+/Sg7sd60G4ShZhHpJk+CDWycQxhfpBQEuO2deazs=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=rx20foFAbNlSXcRcBJ350cruq5/K18EdGw2lQLP10m/ZivoiVKVmhVOYUOlpJ0QLq\n\t7s8AJxU3lt6oNkVlFoF3mzggPpRei+BzUXt3VgAejRrE7UPscOnuEvHaTBoGCKws2l\n\tcLvgStfO2b6gC4mr4VywcYCUj+FJMc3axQncjbLM=","Message-ID":"<93489dbd-bb39-4280-ab2f-d0200d8f2383@ideasonboard.com>","Date":"Wed, 4 Dec 2024 10:23:33 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libipa: agc_mean_luminance: Rename yaml key from\n\texposure-time to exposureTime","To":"libcamera-devel@lists.libcamera.org","References":"<20241204102119.335089-1-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20241204102119.335089-1-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32511,"web_url":"https://patchwork.libcamera.org/comment/32511/","msgid":"<173331151451.3135963.13516302171755848151@ping.linuxembedded.co.uk>","date":"2024-12-04T11:25:14","subject":"Re: [PATCH] libipa: agc_mean_luminance: Rename yaml key from\n\texposure-time to exposureTime","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2024-12-04 10:21:17)\n> In d0478c41f432 (\"libcamera: Rename \"shutter speed\" to \"exposure time\"\")\n> the tuning file entry \"shutter\" was renamed to \"exposure-time\". As the\n> tuning files use camel cased key names, change \"exposure-time\" to\n> \"exposureTime\" for consitency. It doesn't break our users setups as\n> there are no tuning files using that entry in the wild (at least\n> officially).\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++----\n> > utils/tuning/libtuning/modules/agc/rkisp1.py | 4 ++--\n> > 2 files changed, 6 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\n> > index cd17570861e9..02555a44d271 100644\n> > --- a/src/ipa/libipa/agc_mean_luminance.cpp\n> > +++ b/src/ipa/libipa/agc_mean_luminance.cpp\n> > @@ -248,7 +248,7 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> > }\n> > \n> > std::vector exposureTimes =\n> > - modeValues[\"exposure-time\"].getList().value_or(std::vector{});\n> > + modeValues[\"exposureTime\"].getList().value_or(std::vector{});\n> > std::vector gains =\n> > modeValues[\"gain\"].getList().value_or(std::vector{});\n> > \n> > @@ -338,7 +338,7 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> > * For the AeExposureMode control the data should contain a dictionary called\n> > * AeExposureMode containing per-mode setting dictionaries with the key being a\n> > * value from \\ref controls::AeExposureModeNameValueMap. Each mode dict should\n> > - * contain an array of exposure times with the key \"exposure-time\" and an array\n> > + * contain an array of exposure times with the key \"exposureTime\" and an array\n> > * of gain values with the key \"gain\", in this format:\n> > *\n> > * \\code{.unparsed}\n> > @@ -346,10 +346,10 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n> > * - Agc:\n> > * AeExposureMode:\n> > * ExposureNormal:\n> > - * exposure-time: [ 100, 10000, 30000, 60000, 120000 ]\n> > + * exposureTime: [ 100, 10000, 30000, 60000, 120000 ]\n> > * gain: [ 2.0, 4.0, 6.0, 8.0, 10.0 ]\n> > * ExposureShort:\n> > - * exposure-time: [ 100, 10000, 30000, 60000, 120000 ]\n> > + * exposureTime: [ 100, 10000, 30000, 60000, 120000 ]\n> > * gain: [ 2.0, 4.0, 6.0, 8.0, 10.0 ]\n> > *\n> > * \\endcode\n> > diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> > index 1a4dbe7b416a..2dad3a09cecb 100644\n> > --- a/utils/tuning/libtuning/modules/agc/rkisp1.py\n> > +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py\n> > @@ -47,9 +47,9 @@ class AGCRkISP1(AGC):\n> > }\n> > \n> > def _generate_exposure_modes(self) -> dict:\n> > - normal = {'exposure-time': [100, 10000, 30000, 60000, 120000],\n> > + normal = {'exposureTime': [100, 10000, 30000, 60000, 120000],\n> > 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n> > - short = {'exposure-time': [100, 5000, 10000, 20000, 120000],\n> > + short = {'exposureTime': [100, 5000, 10000, 20000, 120000],\n> > 'gain': [2.0, 4.0, 6.0, 6.0, 6.0]}\n> > \n> > return {'ExposureNormal': normal, 'ExposureShort': short}\n> > -- \n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5EBBBDB13\n\tfor ;\n\tWed, 4 Dec 2024 11:25:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 47876660AE;\n\tWed, 4 Dec 2024 12:25:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ABAB618B5\n\tfor ;\n\tWed, 4 Dec 2024 12:25:17 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAF6E9FC;\n\tWed, 4 Dec 2024 12:24:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P3tlQqWz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733311488;\n\tbh=o15vu501EicjiNkv0rj8iWgwn6xXF67zvRTAM4IoLs8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=P3tlQqWzTJBqjUJ3zStAaNN/Zz8lRgP/Hgcbf+XDPs+5f++7TOHtxtyS9OtngqZVz\n\teb+tCbr00uUXxcyUo27sBSgUgI28Juoz8aVMJ+UyikK3vItNVyp/NrvMLxH7LdN7Bb\n\tBUvugjWO6kXyqFCg2bcqAUXdXobwZcP7vt/4bdYU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241204102119.335089-1-stefan.klug@ideasonboard.com>","References":"<20241204102119.335089-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH] libipa: agc_mean_luminance: Rename yaml key from\n\texposure-time to exposureTime","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 04 Dec 2024 11:25:14 +0000","Message-ID":"<173331151451.3135963.13516302171755848151@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]