[{"id":32503,"web_url":"https://patchwork.libcamera.org/comment/32503/","msgid":"<20241203214012.GX10736@pendragon.ideasonboard.com>","date":"2024-12-03T21:40:12","subject":"Re: [PATCH v1] test: span: Use intended variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the patch.\n\nOn Tue, Dec 03, 2024 at 03:12:53PM +0000, Barnabás Pőcze wrote:\n> It appears that the original intention was to use it in these\n> particular constructor tests: the variable is otherwise unused,\n> and `Span{ v }` is already tested.\n> \n> Signed-off-by: Barnabás Pőcze \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/span.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/span.cpp b/test/span.cpp\n> index 5452967d..4b9f3279 100644\n> --- a/test/span.cpp\n> +++ b/test/span.cpp\n> @@ -143,9 +143,9 @@ protected:\n> \t\tSpan{ v };\n> \t\t/* Span{ v }; */\n> \n> -\t\tSpan{ v };\n> -\t\t/* Span{ v }; */\n> -\t\t/* Span{ v }; */\n> +\t\tSpan{ cv };\n> +\t\t/* Span{ cv }; */\n> +\t\t/* Span{ cv }; */\n> \n> \t\tSpan dynamicSpan{ i };\n> \t\tSpan{ dynamicSpan };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9042BDB1C\n\tfor ;\n\tTue, 3 Dec 2024 21:40:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B53F6609D;\n\tTue, 3 Dec 2024 22:40:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 814D765FD6\n\tfor ;\n\tTue, 3 Dec 2024 22:40:24 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9CE2C4CE;\n\tTue, 3 Dec 2024 22:39:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bQNZ1FTc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733261996;\n\tbh=OCsWELH62XfSnTvh6vJO11X0rnLAEFOve+P3JecKyss=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bQNZ1FTcCDBsqc6P9BGudkUHoODQXMlAk0X0HTCpC1jIymHpK3kcf77kUYg++IMZj\n\tM15guqvDdewvfKWVkbZNUzs33YIc1gC+zfHIWoE7K+uUVJ5DGGneA+XOcFuW33esHA\n\tIOCi9IksRzzgahRpTbdlFQTC1+4bmGJqpVD213tY=","Date":"Tue, 3 Dec 2024 23:40:12 +0200","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] test: span: Use intended variable","Message-ID":"<20241203214012.GX10736@pendragon.ideasonboard.com>","References":"<20241203151251.794657-1-pobrn@protonmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20241203151251.794657-1-pobrn@protonmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]