{"id":22156,"url":"https://patchwork.libcamera.org/api/patches/22156/?format=json","web_url":"https://patchwork.libcamera.org/patch/22156/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241203151251.794657-1-pobrn@protonmail.com>","date":"2024-12-03T15:12:53","name":"[v1] test: span: Use intended variable","commit_ref":"b5fd7631e6d681a89d800b22a153cfe13e4e5631","pull_url":null,"state":"accepted","archived":false,"hash":"7fd2e0f920102f409e9e0131d404e308ede4d052","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22156/mbox/","series":[{"id":4841,"url":"https://patchwork.libcamera.org/api/series/4841/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4841","date":"2024-12-03T15:12:53","name":"[v1] test: span: Use intended variable","version":1,"mbox":"https://patchwork.libcamera.org/series/4841/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22156/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22156/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00DCCBDC71\n\tfor ;\n\tTue, 3 Dec 2024 15:13:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADA166608F;\n\tTue, 3 Dec 2024 16:12:59 +0100 (CET)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9AF465FD6\n\tfor ;\n\tTue, 3 Dec 2024 16:12:58 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"prAtBTMt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1733238778; x=1733497978;\n\tbh=YZX3/AztNGo0VqFKwQp+e5cnb3O7E+Oj73wubOwwVaQ=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=prAtBTMtWtN4/S76XWphWE9wIYoOXEpu9iw1swcGXlSfDoagwVwnwL4XuLGj3nxp+\n\tBgPC6V7JpztZehC41L9XNtt72NQ0w3/wEK895mqKjyv33B2ZleWXQfZS7s7MPhcdCW\n\tqY/+FERd3BWojo0t9ybha5yoeuV+4VW8e7GpzWAFEn7rjdALfZQA2OVKkwXdQXdo87\n\t0rQMYMMo0vK09MYi8gQsk64HZwsoeJ1JzctOt4RF7psPNKDNCxyuycSjWg3KOz80h0\n\t84LU8qLH6WUeJ2ePiigOruizX/59pd6+eXtfY+7vlafNTOIro4DwEl8s+lYB6hVIoJ\n\tx0pVQ6phYQIzQ==","Date":"Tue, 03 Dec 2024 15:12:53 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1] test: span: Use intended variable","Message-ID":"<20241203151251.794657-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"9b133d231e679d926016ed7092eef759ed9d1f2f","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It appears that the original intention was to use it in these\nparticular constructor tests: the variable is otherwise unused,\nand `Span{ v }` is already tested.\n\nSigned-off-by: Barnabás Pőcze \n---\n test/span.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/test/span.cpp b/test/span.cpp\nindex 5452967d..4b9f3279 100644\n--- a/test/span.cpp\n+++ b/test/span.cpp\n@@ -143,9 +143,9 @@ protected:\n \t\tSpan{ v };\n \t\t/* Span{ v }; */\n \n-\t\tSpan{ v };\n-\t\t/* Span{ v }; */\n-\t\t/* Span{ v }; */\n+\t\tSpan{ cv };\n+\t\t/* Span{ cv }; */\n+\t\t/* Span{ cv }; */\n \n \t\tSpan dynamicSpan{ i };\n \t\tSpan{ dynamicSpan };\n","prefixes":["v1"]}