[{"id":32484,"web_url":"https://patchwork.libcamera.org/comment/32484/","msgid":"<20241202141342.GA13003@pendragon.ideasonboard.com>","date":"2024-12-02T14:13:42","subject":"Re: [PATCH 1/1] libcamera: documentation: Update meson build\n\trequirements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Isaac,\n\nThank you for the patch.\n\nOn Mon, Dec 02, 2024 at 01:40:32PM +0000, Isaac Scott wrote:\n> The current README states the meson version required is v0.60 or higher.\n> When running the build process, libcamera says it requires meson >=\n> 0.63. Update the README to reflect this.\n> \n> Signed-off-by: Isaac Scott \n> ---\n> README.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 4068c6cc..f1169059 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -44,7 +44,7 @@ A C++ toolchain: [required]\n> Either {g++, clang}\n> \n> Meson Build system: [required]\n> - meson (>= 0.60) ninja-build pkg-config\n> + meson (>= 0.63) ninja-build pkg-config\n\nThe source of truth is meson.build. I wonder if we should drop the\nversion number here to avoid risks of future discrepancies.\n\n> \n> for the libcamera core: [required]\n> libyaml-dev python3-yaml python3-ply python3-jinja2","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF134BEFBE\n\tfor ;\n\tMon, 2 Dec 2024 14:13:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBC2B6606B;\n\tMon, 2 Dec 2024 15:13:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA9F96605F\n\tfor ;\n\tMon, 2 Dec 2024 15:13:53 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0266520;\n\tMon, 2 Dec 2024 15:13:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RBUzVn+w\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733148807;\n\tbh=oBxPhPEZLDyfHBmKUqyX120vBzGuuc0Q7E/H5RLOINs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RBUzVn+waz7fM0l2ng4O2GPt4VuAKWdkogiOUbPGhfS1X/+btmQy0NP9iYlCpUS89\n\tOPL3o3e8Wk5oaoXFo8ZSEl+P3EcpAYz5wr5DpD0rs8UgzlQNoJulukzRBH8XrfJYjv\n\t7TbIVuIcqejWRRcYl2GV25Xaz4yjCwLL7ZJvA91E=","Date":"Mon, 2 Dec 2024 16:13:42 +0200","From":"Laurent Pinchart ","To":"Isaac Scott ","Cc":"libcamera devel ","Subject":"Re: [PATCH 1/1] libcamera: documentation: Update meson build\n\trequirements","Message-ID":"<20241202141342.GA13003@pendragon.ideasonboard.com>","References":"<20241202134032.34205-1-isaac.scott@ideasonboard.com>\n\t<20241202134032.34205-2-isaac.scott@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241202134032.34205-2-isaac.scott@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32595,"web_url":"https://patchwork.libcamera.org/comment/32595/","msgid":"<173350081632.3135963.14698207387561191786@ping.linuxembedded.co.uk>","date":"2024-12-06T16:00:16","subject":"Re: [PATCH 1/1] libcamera: documentation: Update meson build\n\trequirements","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-12-02 14:13:42)\n> Hi Isaac,\n> \n> Thank you for the patch.\n> \n> On Mon, Dec 02, 2024 at 01:40:32PM +0000, Isaac Scott wrote:\n> > The current README states the meson version required is v0.60 or higher.\n> > When running the build process, libcamera says it requires meson >=\n> > 0.63. Update the README to reflect this.\n> > \n> > Signed-off-by: Isaac Scott \n> > ---\n> > README.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 4068c6cc..f1169059 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -44,7 +44,7 @@ A C++ toolchain: [required]\n> > Either {g++, clang}\n> > \n> > Meson Build system: [required]\n> > - meson (>= 0.60) ninja-build pkg-config\n> > + meson (>= 0.63) ninja-build pkg-config\n> \n> The source of truth is meson.build. I wonder if we should drop the\n> version number here to avoid risks of future discrepancies.\n\nEarlier on in the project we changed this quite a lot - so I suspect it\nwas helpful to say what version we needed, particularly as meson hadn't\nhad a major release back then.\n\nBut now - indeed - I think we could drop this.\n\nIsaac, could you respin this patch and smiply remove the specification\nhere please?\n\n--\nKieran\n\n> \n> > \n> > for the libcamera core: [required]\n> > libyaml-dev python3-yaml python3-ply python3-jinja2\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BF67BF415\n\tfor ;\n\tFri, 6 Dec 2024 16:00:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AB8C67E16;\n\tFri, 6 Dec 2024 17:00:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8D62618B3\n\tfor ;\n\tFri, 6 Dec 2024 17:00:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4332274C;\n\tFri, 6 Dec 2024 16:59:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jXzAa/5j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733500789;\n\tbh=B8oiMN8Nl0jdQks6OWCbsjhapz/xGrvwETt9FAo1Ux4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jXzAa/5jFYlkRijy6aln7bqe/+Iqrfc8zYXaKBbSYfVNiGf3PhEWQD651/SuK4v9T\n\t2L77mOlwny7oTapsa9ifbJeI8+cMI5BugKzzRXOAO8Mc7iDBQhIIklaRARac9wIZOe\n\t03j0pVdrM9gOckwMRoQu97XfMx4UR7vv2LikpSMY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241202141342.GA13003@pendragon.ideasonboard.com>","References":"<20241202134032.34205-1-isaac.scott@ideasonboard.com>\n\t<20241202134032.34205-2-isaac.scott@ideasonboard.com>\n\t<20241202141342.GA13003@pendragon.ideasonboard.com>","Subject":"Re: [PATCH 1/1] libcamera: documentation: Update meson build\n\trequirements","From":"Kieran Bingham ","Cc":"libcamera devel ","To":"Isaac Scott ,\n\tLaurent Pinchart ","Date":"Fri, 06 Dec 2024 16:00:16 +0000","Message-ID":"<173350081632.3135963.14698207387561191786@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]