{"id":22139,"url":"https://patchwork.libcamera.org/api/patches/22139/?format=json","web_url":"https://patchwork.libcamera.org/patch/22139/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241129091916.298359-5-paul.elder@ideasonboard.com>","date":"2024-11-29T09:19:16","name":"[v3,4/4] apps: cam: Print control direction information","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7eab01faec5bdc6c31baf9df6b17f1c1de3e001c","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22139/mbox/","series":[{"id":4833,"url":"https://patchwork.libcamera.org/api/series/4833/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4833","date":"2024-11-29T09:19:12","name":"Add direction field to ControlId","version":3,"mbox":"https://patchwork.libcamera.org/series/4833/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22139/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22139/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C108C3220\n\tfor ;\n\tFri, 29 Nov 2024 09:19:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58AED66032;\n\tFri, 29 Nov 2024 10:19:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B316C66014\n\tfor ;\n\tFri, 29 Nov 2024 10:19:32 +0100 (CET)","from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:b147:f3c:c4e8:a42a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 743CAA8F;\n\tFri, 29 Nov 2024 10:19:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"h4+fvTBG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732871948;\n\tbh=Vrhi0lc4JXRFqpRFHP/wsI3ESjAGS5Y6RRv1L7F5K+A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=h4+fvTBGjzCjRMllWXI7H35x3AWPTuYCZBO0tB8DqtA7MAuMgcGhVreEccKJJJgo0\n\t6xpF3+IEJSr3wfaIk+O3RFQXnB5tuEjQeZbxhac4dL7q9ZBzod/ktCS0iu3hPwpMg7\n\tg24CpworQ0Ayrn7TtxMQVDu3zsU96gH7nQDa5Qgo=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH v3 4/4] apps: cam: Print control direction information","Date":"Fri, 29 Nov 2024 18:19:16 +0900","Message-Id":"<20241129091916.298359-5-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20241129091916.298359-1-paul.elder@ideasonboard.com>","References":"<20241129091916.298359-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now that there is support for retrieving the allowed directions of a\ncontrol, print this information when listing controls.\n\nSample output:\n$ cam --list-controls -c 2\nUsing camera Virtual0 as cam0\nControl: [inout] draft::FaceDetectMode:\n - FaceDetectModeOff (0)\nControl: [in ] libcamera::FrameDurationLimits: [16666..33333]\n Size: 2\n\nSigned-off-by: Paul Elder \n\n---\nNo change in v3\n\nChanges in v2:\n- s/i/in/, s/o/out/ so that the output is easier to read\n---\n src/apps/cam/camera_session.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 6e9890ccfda1..9e93482775c3 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -159,12 +159,18 @@ CameraSession::~CameraSession()\n void CameraSession::listControls() const\n {\n \tfor (const auto &[id, info] : camera_->controls()) {\n+\t\tstd::stringstream io;\n+\t\tio << \"[\"\n+\t\t << (id->isInput() ? \"in\" : \" \")\n+\t\t << (id->isOutput() ? \"out\" : \" \")\n+\t\t << \"] \";\n+\n \t\tif (info.values().empty()) {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t << id->vendor() << \"::\" << id->name() << \": \"\n \t\t\t\t << info.toString() << std::endl;\n \t\t} else {\n-\t\t\tstd::cout << \"Control: \"\n+\t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n \t\t\t\t << std::endl;\n \t\t\tfor (const auto &value : info.values()) {\n","prefixes":["v3","4/4"]}