[{"id":32460,"web_url":"https://patchwork.libcamera.org/comment/32460/","msgid":"<173287759610.1605529.14330591259363138530@ping.linuxembedded.co.uk>","date":"2024-11-29T10:53:16","subject":"Re: [PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Harvey,\n\nYour e-mails are now breaking our CI tests. Technically this might be a\nform of a false positive, but is there anythign we can do to prevent\nthis from happening? or could you fix this please?\n\n\nQuoting Harvey Yang (2024-11-29 05:52:18)\n> From: Harvey Yang \n\nHere you are from 'google'\n\n> \n> Provide the GalaxyCore gc05a2 camera sensor properties and registration\n> with libipa for the gain code helpers.\n> \n> Signed-off-by: Han-Lin Chen \n> Co-developed-by: Xing Gu \n> Signed-off-by: Xing Gu \n> Co-developed-by: Yudhistira Erlandinata \n> Signed-off-by: Yudhistira Erlandinata \n> Co-developed-by: Harvey Yang \n> Signed-off-by: Harvey Yang \n\nBut no one at google has signed this commit - so the following test\nfails.:\n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/jobs/67426810\n\nRunning Pre-merge checks for patchwork/4832 (4d9db06d669044c0c461a2aed79c85c7fe32a502..3eb97f403536c34edaecd42464637e44dd999cea) 00:17\nMissing author Signed-off-by in commit 3eb97f403536c34edaecd42464637e44dd999cea\nMissing author Signed-off-by in commit 26bc3bd1e4f7c767f98fb0d44572122e3f7adf8a\nFound 2 errors in patchwork/4832, not pushing\n\n--\nKieran\n\n\n> Reviewed-by: Kieran Bingham \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++\n> 2 files changed, 26 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index a0a5437aa..9fb55bcfa 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -519,6 +519,19 @@ private:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n> \n> +class CameraSensorHelperGc05a2 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperGc05a2()\n> + {\n> + /* From datasheet: 64 at 10bits. */\n> + blackLevel_ = 4096;\n> + gainType_ = AnalogueGainLinear;\n> + gainConstants_.linear = { 100, 0, 0, 1024 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n> +\n> class CameraSensorHelperImx214 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 3fe18c164..73c47b9a1 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -106,6 +106,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> },\n> .sensorDelays = { },\n> } },\n> + { \"gc05a2\", {\n> + .unitCellSize = { 1120, 1120 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1 },\n> + },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"hi846\", {\n> .unitCellSize = { 1120, 1120 },\n> .testPatternModes = {\n> -- \n> 2.47.0.338.g60cca15819-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59D61C3220\n\tfor ;\n\tFri, 29 Nov 2024 10:53:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 380246600F;\n\tFri, 29 Nov 2024 11:53:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E36D60CE6\n\tfor ;\n\tFri, 29 Nov 2024 11:53:19 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88EE7BDB;\n\tFri, 29 Nov 2024 11:52:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zfyi2MWB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732877574;\n\tbh=JlmHBt3K9ZWUQLPq525I28ql9U77OaKRspSTH87Df9I=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Zfyi2MWBWN2sZOFa8BGSCbfSRBHHhzlEdcWmbNmGgnau0JADnK/lEDm2NBJJaLLl7\n\tMtMrRavWqRy8SvTmyd7kmUkePZdgv9VBDUxB16IcGdFpeeTcNOIGo7ieUWpGydIdu4\n\tOysaBZYNAHKF3Qr38Tt994aApN2jIpz6gJI2ndiE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241129055331.2490988-2-chenghaoyang@chromium.org>","References":"<20241129055331.2490988-1-chenghaoyang@chromium.org>\n\t<20241129055331.2490988-2-chenghaoyang@chromium.org>","Subject":"Re: [PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","From":"Kieran Bingham ","Cc":"Harvey Yang ,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ,\n\tHarvey Yang ","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 29 Nov 2024 10:53:16 +0000","Message-ID":"<173287759610.1605529.14330591259363138530@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32462,"web_url":"https://patchwork.libcamera.org/comment/32462/","msgid":"","date":"2024-11-29T12:36:30","subject":"Re: [PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran,\n\nOn Fri, Nov 29, 2024 at 6:53 PM Kieran Bingham\n wrote:\n>\n> Hi Harvey,\n>\n> Your e-mails are now breaking our CI tests. Technically this might be a\n> form of a false positive, but is there anythign we can do to prevent\n> this from happening? or could you fix this please?\n>\n>\n> Quoting Harvey Yang (2024-11-29 05:52:18)\n> > From: Harvey Yang \n>\n> Here you are from 'google'\n>\n> >\n> > Provide the GalaxyCore gc05a2 camera sensor properties and registration\n> > with libipa for the gain code helpers.\n> >\n> > Signed-off-by: Han-Lin Chen \n> > Co-developed-by: Xing Gu \n> > Signed-off-by: Xing Gu \n> > Co-developed-by: Yudhistira Erlandinata \n> > Signed-off-by: Yudhistira Erlandinata \n> > Co-developed-by: Harvey Yang \n> > Signed-off-by: Harvey Yang \n>\n> But no one at google has signed this commit - so the following test\n> fails.:\n>\n> https://gitlab.freedesktop.org/camera/libcamera/-/jobs/67426810\n>\n> Running Pre-merge checks for patchwork/4832 (4d9db06d669044c0c461a2aed79c85c7fe32a502..3eb97f403536c34edaecd42464637e44dd999cea) 00:17\n> Missing author Signed-off-by in commit 3eb97f403536c34edaecd42464637e44dd999cea\n> Missing author Signed-off-by in commit 26bc3bd1e4f7c767f98fb0d44572122e3f7adf8a\n> Found 2 errors in patchwork/4832, not pushing\n\nSorry, I think I cherry-picked from Google's Gerrit.\nUpdated in v7. Please try again, thanks!\n\nBR,\nHarvey\n\n>\n> --\n> Kieran\n>\n>\n> > Reviewed-by: Kieran Bingham \n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n> > src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++\n> > 2 files changed, 26 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index a0a5437aa..9fb55bcfa 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -519,6 +519,19 @@ private:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n> >\n> > +class CameraSensorHelperGc05a2 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperGc05a2()\n> > + {\n> > + /* From datasheet: 64 at 10bits. */\n> > + blackLevel_ = 4096;\n> > + gainType_ = AnalogueGainLinear;\n> > + gainConstants_.linear = { 100, 0, 0, 1024 };\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n> > +\n> > class CameraSensorHelperImx214 : public CameraSensorHelper\n> > {\n> > public:\n> > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > index 3fe18c164..73c47b9a1 100644\n> > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > @@ -106,6 +106,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > },\n> > .sensorDelays = { },\n> > } },\n> > + { \"gc05a2\", {\n> > + .unitCellSize = { 1120, 1120 },\n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 1 },\n> > + },\n> > + .sensorDelays = {\n> > + .exposureDelay = 2,\n> > + .gainDelay = 2,\n> > + .vblankDelay = 2,\n> > + .hblankDelay = 2\n> > + },\n> > + } },\n> > { \"hi846\", {\n> > .unitCellSize = { 1120, 1120 },\n> > .testPatternModes = {\n> > --\n> > 2.47.0.338.g60cca15819-goog\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D63C5C31E9\n\tfor ;\n\tFri, 29 Nov 2024 12:36:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB52466032;\n\tFri, 29 Nov 2024 13:36:43 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FFC06601A\n\tfor ;\n\tFri, 29 Nov 2024 13:36:42 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2ffa49f623cso24656001fa.1\n\tfor ;\n\tFri, 29 Nov 2024 04:36:42 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mFb5Z76z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732883801; x=1733488601;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VZtGzdWqC/p/7qFzkRlbhSe9XnctWvppMoE1hmRCS4E=;\n\tb=mFb5Z76zshZUN3dZLPxu34osC3hGPqsbD95bulCnNuqAJ3xoGgQ2HPoVbciIyahub+\n\tmrd7L4cqAko0KDX9+dwk64EMgL80aKp6ZLVjBZrzZkHTtzPie9zo+Ye3YlmjHnGfU29j\n\txkkjz4dXPnSGJVNOGFbgQt9nHw4A1fdPguSQM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732883801; x=1733488601;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=VZtGzdWqC/p/7qFzkRlbhSe9XnctWvppMoE1hmRCS4E=;\n\tb=rXKE7gCH1ThN5zJ/1qz73zCzGfLD82e433vgXVPy0NwQH0sB6/rxem6eaw4YHQ028P\n\tXWgpZiaGerop3VzMoLj7bdYHeW7IlcFO1/kOwXOWnqa9LEMYAuqVd84BsviV+yUQ3pqG\n\tbDq91HPA7OouE+Uc/0uqcf4VG0PloEqP6rlB8mH1twqtz1WFdpIHY6sdfvoneAZQg9ta\n\tI2dtOakXumpzhZZRpnj6WFxdMqcq2IG0ttcgObQpl6RB/w0kz294cJ4Rw26rLeBxI+J7\n\tiJMvD6UfAUtDROmTtNJBS469rTOfzKFvuTBavaWLtwiEF/9PFjlYVdco8pva+fue5VTw\n\tq7YQ==","X-Gm-Message-State":"AOJu0YyotHBFn/+051SD1ESNNs51Os588QuFQWv8bG9kHvjsKPwM4/IT\n\t1mfnNPgk5MU2wkEudn388Fn1Q2rMu+W3LNKyfHofCOhgEt751umpkOqmelC+Y78V5LshNoPdZHb\n\tE/GuwJf2b3HAWuy7ftVzzBvOCWsJTYt7460OS","X-Gm-Gg":"ASbGnct6klXZiqd85gaSZOZy0fWdssry4KkdTQoeNqSx2eQiD19bnKJKV6bqm+EpdcN\n\txxQqkb4dbr1rrbu5HDgFrv/ojkjNgEZYfkPF1ODEO3f9LUxh6R5Z4C8r8B0k+zqeMlQ==","X-Google-Smtp-Source":"AGHT+IFEtvzlBHbEsqbQnIgfmKHrK0yY6UykYoMPw4NjBxM0X+Y6QVE4mTwp25AecSWlaYVNa4OXv4P8TJkN0TPIpMw=","X-Received":"by 2002:a2e:bea3:0:b0:2ff:b812:36e6 with SMTP id\n\t38308e7fff4ca-2ffd60e2197mr67902681fa.35.1732883801267;\n\tFri, 29 Nov 2024 04:36:41 -0800 (PST)","MIME-Version":"1.0","References":"<20241129055331.2490988-1-chenghaoyang@chromium.org>\n\t<20241129055331.2490988-2-chenghaoyang@chromium.org>\n\t<173287759610.1605529.14330591259363138530@ping.linuxembedded.co.uk>","In-Reply-To":"<173287759610.1605529.14330591259363138530@ping.linuxembedded.co.uk>","From":"Cheng-Hao Yang ","Date":"Fri, 29 Nov 2024 20:36:30 +0800","Message-ID":"","Subject":"Re: [PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tHarvey Yang , \n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]