{"id":22133,"url":"https://patchwork.libcamera.org/api/patches/22133/?format=json","web_url":"https://patchwork.libcamera.org/patch/22133/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241129055331.2490988-2-chenghaoyang@chromium.org>","date":"2024-11-29T05:52:18","name":"[v6,1/2] libcamera: libipa: camera_sensor: Add GalaxyCore gc05a2 sensor properties","commit_ref":"407620187398724fadee5dea2adeb6dc72173ce0","pull_url":null,"state":"accepted","archived":false,"hash":"c9f6f4800e3feb78a69f7d6db9707741c59f7106","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22133/mbox/","series":[{"id":4832,"url":"https://patchwork.libcamera.org/api/series/4832/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4832","date":"2024-11-29T05:52:17","name":"Add camera sensor properties for ciri","version":6,"mbox":"https://patchwork.libcamera.org/series/4832/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22133/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22133/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1254CC31E9\n\tfor ;\n\tFri, 29 Nov 2024 05:53:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF8D465FE9;\n\tFri, 29 Nov 2024 06:53:40 +0100 (CET)","from mail-oi1-x230.google.com (mail-oi1-x230.google.com\n\t[IPv6:2607:f8b0:4864:20::230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D07165FE2\n\tfor ;\n\tFri, 29 Nov 2024 06:53:38 +0100 (CET)","by mail-oi1-x230.google.com with SMTP id\n\t5614622812f47-3ea68fc1a7cso643089b6e.0\n\tfor ;\n\tThu, 28 Nov 2024 21:53:38 -0800 (PST)","from chenghaoyang-low.c.googlers.com.com\n\t(112.212.229.35.bc.googleusercontent.com. [35.229.212.112])\n\tby smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-7fc9c2e537fsm2029676a12.24.2024.11.28.21.53.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Nov 2024 21:53:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HCKu5scy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1732859617; x=1733464417;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=trMwrlEwaXahNOC8jOa41wck1eBNwIwqGHQXCuJvaxQ=;\n\tb=HCKu5scyw02zZsu3YKlP3E1QGMGlPdoqZS/8a2Fi1V3rhVutgzZWT+ekdKffc4T9Wk\n\tmzGyzfoFZLp4qvodrv6mku577HOGBcwIDpnlQZqCCrjtYS9flcjuTp5cP1X4T83lcjry\n\t21z8Nqebz1+c/OPGScNa/vioTSe+jD9T6+k28=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732859617; x=1733464417;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=trMwrlEwaXahNOC8jOa41wck1eBNwIwqGHQXCuJvaxQ=;\n\tb=KlxEpVFepKzFJrr9qf+selPW71JqVvZTDD3N1aZyKqm95ibu440bsN0Ej8AHxKVvZW\n\tyXwSLq4mvL80GPUh8J9hwGdr7XbPrujm/Rct2wilfW/mdF6WQtHLRbov8osm/RBBWOdM\n\tyQ/RIVAt4pO2duwQ9YPyiNKeLhCQ+0X1eScbJ03EApk4R+dhbNtfCRM7HoBUP0Er/xgy\n\tTJZaucGlA0Rj2pQ+XsSOJOQo8iYc/TdfpYSA4PIu/HkC9UHzgZEZvhXnVbTO5DRGVHhK\n\tv38A2mcYzCrVuESFqVpw3J9AT/esQg6Y90Q2jYGkB9OSnsIamVPQaPjx08LBERlyRbWV\n\taLsg==","X-Gm-Message-State":"AOJu0YztsyEH2eoMPrhc0HQ0Muv5siQIk5LCG3H0XKrLIPbeahV3KpCT\n\tHmt9yFvL1xeush/ezdGoHq5m3p8UMAiH54JlmSWTC8FK+3B2QD0mOirT+2X8Cyf4C/Q1ITk0+A4\n\t=","X-Gm-Gg":"ASbGncsn2w/EjdXWXu7kVSyw+rWoaEfPPuxuz2i+C9jn+66vHJIqBCRUJPx9qTmpi98\n\tAEzjHTOiEJFhd64P+ZBkm1WaGutCIxGgMGNeJycm6zWMOlsn+nJ266n4Bd6osbfEwOxCeBHR9j4\n\tkkr+hVWJGoJqlIjxMk2/eq3r4mM0oYo2xHZw77PHIielq1RJy64WGr82O/iC0Iq3LNJmLbyfj/0\n\tq8obb3cVf85/JshzKfdDW4l2BlFol6iSdTs/VV59BSGf9mTzA1D4zwNGk34ohQKdwiQbCCmhcPO\n\tROgo0U70KcDcm32xiuUYpN6Hwn6nLFfQQiSnnKTKgIptcBZE0zv2AGnr","X-Google-Smtp-Source":"AGHT+IGn2qfGUYAH+t8z6PhbGyJzFyS+vn6QMceRw6v3aJrsXq+kjU7ayTWJF2/6m9+eErCJBhhihw==","X-Received":"by 2002:a05:6808:1452:b0:3ea:4aad:a877 with SMTP id\n\t5614622812f47-3ea6dda6c24mr8073652b6e.43.1732859616924; \n\tThu, 28 Nov 2024 21:53:36 -0800 (PST)","From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Harvey Yang ,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ,\n\tHarvey Yang ,\n\tKieran Bingham ","Subject":"[PATCH v6 1/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc05a2 sensor properties","Date":"Fri, 29 Nov 2024 05:52:18 +0000","Message-ID":"<20241129055331.2490988-2-chenghaoyang@chromium.org>","X-Mailer":"git-send-email 2.47.0.338.g60cca15819-goog","In-Reply-To":"<20241129055331.2490988-1-chenghaoyang@chromium.org>","References":"<20241129055331.2490988-1-chenghaoyang@chromium.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Harvey Yang \n\nProvide the GalaxyCore gc05a2 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nSigned-off-by: Han-Lin Chen \nCo-developed-by: Xing Gu \nSigned-off-by: Xing Gu \nCo-developed-by: Yudhistira Erlandinata \nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: Harvey Yang \nSigned-off-by: Harvey Yang \nReviewed-by: Kieran Bingham \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 13 +++++++++++++\n 2 files changed, 26 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex a0a5437aa..9fb55bcfa 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -519,6 +519,19 @@ private:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ar0521\", CameraSensorHelperAr0521)\n \n+class CameraSensorHelperGc05a2 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperGc05a2()\n+\t{\n+\t\t/* From datasheet: 64 at 10bits. */\n+\t\tblackLevel_ = 4096;\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 100, 0, 0, 1024 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n+\n class CameraSensorHelperImx214 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 3fe18c164..73c47b9a1 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -106,6 +106,19 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t},\n \t\t\t.sensorDelays = { },\n \t\t} },\n+\t\t{ \"gc05a2\", {\n+\t\t\t.unitCellSize = { 1120, 1120 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t},\n+\t\t\t.sensorDelays = {\n+\t\t\t\t.exposureDelay = 2,\n+\t\t\t\t.gainDelay = 2,\n+\t\t\t\t.vblankDelay = 2,\n+\t\t\t\t.hblankDelay = 2\n+\t\t\t},\n+\t\t} },\n \t\t{ \"hi846\", {\n \t\t\t.unitCellSize = { 1120, 1120 },\n \t\t\t.testPatternModes = {\n","prefixes":["v6","1/2"]}