[{"id":32830,"web_url":"https://patchwork.libcamera.org/comment/32830/","msgid":"<173445313754.32744.13565446164780176054@ping.linuxembedded.co.uk>","date":"2024-12-17T16:32:17","subject":"Re: [PATCH 1/2] libcamera: camera_sensor_properties: Add ov7251 and\n\tov9281","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-11-27 13:32:32)\n> Add entries for the OmniVision OV7251 and OV9281 sensors. The control\n> delay values are drawn from the Raspberry Pi CameraSensorHelper class\n> for these sensors - the pixel sizes from the datasheets. Both sensors\n> are monochrome and do not have test pattern settings that correspond\n> to defined control values.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Kieran Bingham \n\n> ---\n> .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 3fe18c16..0eccc937 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -360,6 +360,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> .hblankDelay = 2\n> },\n> } },\n> + { \"ov7251\", {\n> + .unitCellSize = { 3000, 3000 },\n> + .testPatternModes = { },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"ov8858\", {\n> .unitCellSize = { 1120, 1120 },\n> .testPatternModes = {\n> @@ -389,6 +399,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> },\n> .sensorDelays = { },\n> } },\n> + { \"ov9281\", {\n> + .unitCellSize = { 3000, 3000 },\n> + .testPatternModes = { },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"ov13858\", {\n> .unitCellSize = { 1120, 1120 },\n> .testPatternModes = {\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0481ABD1F1\n\tfor ;\n\tTue, 17 Dec 2024 16:32:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58E7267FE4;\n\tTue, 17 Dec 2024 17:32:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B950F67FD3\n\tfor ;\n\tTue, 17 Dec 2024 17:32:20 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43E0B4C7;\n\tTue, 17 Dec 2024 17:31:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eUGjqDTn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734453103;\n\tbh=PQroJlUOK85D0hxppl/VucwUViYEuRtFQ4q7XsqOqkU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=eUGjqDTnuZKKss9DPXLRDDiA8uVwdJ8V+9E1VDWtMjJ3COBmqK0Rx2lACbHlqbJeQ\n\tfacVjvCHGJoygMQfGG0NAusIwn3D7w2dEVCvje36f6gEanHF8YnNGMnHJ7vO+ekj+Y\n\tOOuQ/b5WVOHEUWiEqGr0ry9uYgjgOkJpsAz1thtI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241127133233.247977-2-dan.scally@ideasonboard.com>","References":"<20241127133233.247977-1-dan.scally@ideasonboard.com>\n\t<20241127133233.247977-2-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera: camera_sensor_properties: Add ov7251 and\n\tov9281","From":"Kieran Bingham ","Cc":"david.plowman@raspberrypi.com, naush@raspberrypi.com,\n\tDaniel Scally ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 17 Dec 2024 16:32:17 +0000","Message-ID":"<173445313754.32744.13565446164780176054@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32833,"web_url":"https://patchwork.libcamera.org/comment/32833/","msgid":"<20241217164242.GF20432@pendragon.ideasonboard.com>","date":"2024-12-17T16:42:42","subject":"Re: [PATCH 1/2] libcamera: camera_sensor_properties: Add ov7251 and\n\tov9281","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Nov 27, 2024 at 01:32:32PM +0000, Daniel Scally wrote:\n> Add entries for the OmniVision OV7251 and OV9281 sensors. The control\n> delay values are drawn from the Raspberry Pi CameraSensorHelper class\n> for these sensors - the pixel sizes from the datasheets. Both sensors\n> are monochrome and do not have test pattern settings that correspond\n> to defined control values.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../sensor/camera_sensor_properties.cpp | 20 +++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 3fe18c16..0eccc937 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -360,6 +360,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t.hblankDelay = 2\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov7251\", {\n> +\t\t\t.unitCellSize = { 3000, 3000 },\n> +\t\t\t.testPatternModes = { },\n> +\t\t\t.sensorDelays = {\n> +\t\t\t\t.exposureDelay = 2,\n> +\t\t\t\t.gainDelay = 2,\n> +\t\t\t\t.vblankDelay = 2,\n> +\t\t\t\t.hblankDelay = 2\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov8858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t\t.testPatternModes = {\n> @@ -389,6 +399,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t},\n> \t\t\t.sensorDelays = { },\n> \t\t} },\n> +\t\t{ \"ov9281\", {\n> +\t\t\t.unitCellSize = { 3000, 3000 },\n> +\t\t\t.testPatternModes = { },\n> +\t\t\t.sensorDelays = {\n> +\t\t\t\t.exposureDelay = 2,\n> +\t\t\t\t.gainDelay = 2,\n> +\t\t\t\t.vblankDelay = 2,\n> +\t\t\t\t.hblankDelay = 2\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov13858\", {\n> \t\t\t.unitCellSize = { 1120, 1120 },\n> \t\t\t.testPatternModes = {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B287BD1F1\n\tfor ;\n\tTue, 17 Dec 2024 16:42:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EC1E67FE6;\n\tTue, 17 Dec 2024 17:42:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3FA467FD3\n\tfor ;\n\tTue, 17 Dec 2024 17:42:44 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 485504C7;\n\tTue, 17 Dec 2024 17:42:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZyNHnO6+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734453727;\n\tbh=GIq8phmghGOoy7YnkW2MlwlpIXRopw057ciAtcFpeT8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZyNHnO6+Am0Gj7Hdfso8CAjKSnoJGsXZBMDux7QxskyQuZ9BSK0YGsKuymWkqu5Ls\n\tKF7/GseYdRE5i7FhfuscX/DAKz8obbKl/qf/GRufWz7RoZKXU2+QnM7BXJwRJxGU2W\n\t8BZAkkP0sETepWDg7kj5vwIN3mxgHmxqG3wDhCTE=","Date":"Tue, 17 Dec 2024 18:42:42 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, david.plowman@raspberrypi.com,\n\tnaush@raspberrypi.com","Subject":"Re: [PATCH 1/2] libcamera: camera_sensor_properties: Add ov7251 and\n\tov9281","Message-ID":"<20241217164242.GF20432@pendragon.ideasonboard.com>","References":"<20241127133233.247977-1-dan.scally@ideasonboard.com>\n\t<20241127133233.247977-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241127133233.247977-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]