[{"id":32386,"web_url":"https://patchwork.libcamera.org/comment/32386/","msgid":"<173263633496.1605529.11868542264721598287@ping.linuxembedded.co.uk>","date":"2024-11-26T15:52:14","subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-11-26 15:12:03)\n> Rather than hard coding default delays for control values in the\n> pipeline handlers, pick up the ones defined in the CameraSensor\n> properties.\n> \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Kieran Bingham \n\n> ---\n> Changes in v5:\n> \n> - Fixed the includes in each pipeline (remove property_ids.h, added\n> camera_sensor_properties.h)\n> \n> Changes in v4:\n> \n> - Used the struct reference rather than values directly\n> \n> Changes in v3:\n> \n> - Fixed some broken alignment \n> \n> Changes in v2:\n> \n> - Switched to use the new getSensorDelays() function\n> \n> src/libcamera/pipeline/ipu3/ipu3.cpp | 11 ++++-------\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 ++++-------\n> src/libcamera/pipeline/simple/simple.cpp | 6 ++++--\n> 3 files changed, 12 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0069d5e2..e31e3879 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -28,6 +28,7 @@\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> @@ -1077,14 +1078,10 @@ int PipelineHandlerIPU3::registerCameras()\n> if (ret)\n> continue;\n> \n> - /*\n> - * \\todo Read delay values from the sensor itself or from a\n> - * a sensor database. For now use generic values taken from\n> - * the Raspberry Pi and listed as 'generic values'.\n> - */\n> + const CameraSensorProperties::SensorDelays &delays = cio2->sensor()->sensorDelays();\n> std::unordered_map params = {\n> - { V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n> - { V4L2_CID_EXPOSURE, { 2, false } },\n> + { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> + { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> };\n> \n> data->delayedCtrls_ =\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 6c6d711f..908724e2 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -34,6 +34,7 @@\n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -1239,14 +1240,10 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> /* Initialize the camera properties. */\n> data->properties_ = data->sensor_->properties();\n> \n> - /*\n> - * \\todo Read delay values from the sensor itself or from a\n> - * a sensor database. For now use generic values taken from\n> - * the Raspberry Pi and listed as generic values.\n> - */\n> + const CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> std::unordered_map params = {\n> - { V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n> - { V4L2_CID_EXPOSURE, { 2, false } },\n> + { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> + { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> };\n> \n> data->delayedCtrls_ =\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 41fdf84c..dae9f31f 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -31,6 +31,7 @@\n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/converter.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -1290,9 +1291,10 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> if (outputCfgs.empty())\n> return 0;\n> \n> + const CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> std::unordered_map params = {\n> - { V4L2_CID_ANALOGUE_GAIN, { 2, false } },\n> - { V4L2_CID_EXPOSURE, { 2, false } },\n> + { V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> + { V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> };\n> data->delayedCtrls_ =\n> std::make_unique(data->sensor_->device(),\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80A9DC3200\n\tfor ;\n\tTue, 26 Nov 2024 15:52:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A531B65FCD;\n\tTue, 26 Nov 2024 16:52:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5110865F9E\n\tfor ;\n\tTue, 26 Nov 2024 16:52:18 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B08A96BE;\n\tTue, 26 Nov 2024 16:51:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gGPmWYNA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732636315;\n\tbh=50gzJFewqYiq5ilwTHk9Ier+W9ehmSRtlCZjgdaAW6Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gGPmWYNAN2XsFzOl2PP9vQywchFnPXuGCfVoMZTTm9Et0nduwdzRivrEsdeb6TKSy\n\tjo6tFIzMK1L6+l5J2GpiVoqsjTNUvf1diwvA70T6hTJT00TLGLhZHZ4bmflvU7JWWp\n\tQ/qiIwW9nA7UCV3QlNwt4mgxswyTNno/T5uYKoUk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241126151203.108407-3-dan.scally@ideasonboard.com>","References":"<20241126151203.108407-1-dan.scally@ideasonboard.com>\n\t<20241126151203.108407-3-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","From":"Kieran Bingham ","Cc":"mike.rudenko@gmail.com, Daniel Scally ,\n\tJacopo Mondi ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 26 Nov 2024 15:52:14 +0000","Message-ID":"<173263633496.1605529.11868542264721598287@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32403,"web_url":"https://patchwork.libcamera.org/comment/32403/","msgid":"<20241127070159.GS5461@pendragon.ideasonboard.com>","date":"2024-11-27T07:01:59","subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Nov 26, 2024 at 03:12:03PM +0000, Daniel Scally wrote:\n> Rather than hard coding default delays for control values in the\n> pipeline handlers, pick up the ones defined in the CameraSensor\n> properties.\n> \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Laurent Pinchart \n\nAny chance we could do the same for the Raspberry Pi pipeline handler,\nand drop the delays from its IPA module (in a separate patch of course)\n?\n\n> ---\n> Changes in v5:\n> \n> \t- Fixed the includes in each pipeline (remove property_ids.h, added\n> \t camera_sensor_properties.h)\n> \n> Changes in v4:\n> \n> \t- Used the struct reference rather than values directly\n> \n> Changes in v3:\n> \n> \t- Fixed some broken alignment \n> \n> Changes in v2:\n> \n> \t- Switched to use the new getSensorDelays() function\n> \n> src/libcamera/pipeline/ipu3/ipu3.cpp | 11 ++++-------\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 ++++-------\n> src/libcamera/pipeline/simple/simple.cpp | 6 ++++--\n> 3 files changed, 12 insertions(+), 16 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0069d5e2..e31e3879 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -28,6 +28,7 @@\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> @@ -1077,14 +1078,10 @@ int PipelineHandlerIPU3::registerCameras()\n> \t\tif (ret)\n> \t\t\tcontinue;\n> \n> -\t\t/*\n> -\t\t * \\todo Read delay values from the sensor itself or from a\n> -\t\t * a sensor database. For now use generic values taken from\n> -\t\t * the Raspberry Pi and listed as 'generic values'.\n> -\t\t */\n> +\t\tconst CameraSensorProperties::SensorDelays &delays = cio2->sensor()->sensorDelays();\n> \t\tstd::unordered_map params = {\n> -\t\t\t{ V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n> -\t\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n> +\t\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> +\t\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> \t\t};\n> \n> \t\tdata->delayedCtrls_ =\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 6c6d711f..908724e2 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -34,6 +34,7 @@\n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -1239,14 +1240,10 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n> \t/* Initialize the camera properties. */\n> \tdata->properties_ = data->sensor_->properties();\n> \n> -\t/*\n> -\t * \\todo Read delay values from the sensor itself or from a\n> -\t * a sensor database. For now use generic values taken from\n> -\t * the Raspberry Pi and listed as generic values.\n> -\t */\n> +\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> \tstd::unordered_map params = {\n> -\t\t{ V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n> -\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n> +\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> +\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> \t};\n> \n> \tdata->delayedCtrls_ =\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 41fdf84c..dae9f31f 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -31,6 +31,7 @@\n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> +#include \"libcamera/internal/camera_sensor_properties.h\"\n> #include \"libcamera/internal/converter.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -1290,9 +1291,10 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \tif (outputCfgs.empty())\n> \t\treturn 0;\n> \n> +\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n> \tstd::unordered_map params = {\n> -\t\t{ V4L2_CID_ANALOGUE_GAIN, { 2, false } },\n> -\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n> +\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n> +\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n> \t};\n> \tdata->delayedCtrls_ =\n> \t\tstd::make_unique(data->sensor_->device(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F3DC9BE08B\n\tfor ;\n\tWed, 27 Nov 2024 07:02:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 376BB66098;\n\tWed, 27 Nov 2024 08:02:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BA3465FD6\n\tfor ;\n\tWed, 27 Nov 2024 08:02:10 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE2C878C;\n\tWed, 27 Nov 2024 08:01:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I/wQob8z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732690907;\n\tbh=YiLVvFSBJkSLMSOn8lZ1E6pA35y6d6FQbqi3F4h+b68=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I/wQob8zMbe+R+QAxHCPdZ1B14YpYM03X1dGuXI6NY3Cd3p+d1CnjrOl1ZXATJyoB\n\tpssORbG+QTJA4qJ9rwSvR3vXVEG2gtqEoxQhR7F8UVNF0l45Z5Ja8tvPdLRwGSMdnX\n\twNyTZI2QZB4h+bvjWhRtL1oRHnQ16wTC5Jt9DiUU=","Date":"Wed, 27 Nov 2024 09:01:59 +0200","From":"Laurent Pinchart ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org, mike.rudenko@gmail.com,\n\tJacopo Mondi ","Subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","Message-ID":"<20241127070159.GS5461@pendragon.ideasonboard.com>","References":"<20241126151203.108407-1-dan.scally@ideasonboard.com>\n\t<20241126151203.108407-3-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241126151203.108407-3-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32410,"web_url":"https://patchwork.libcamera.org/comment/32410/","msgid":"","date":"2024-11-27T09:06:14","subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Morning Laurent\n\nOn 27/11/2024 07:01, Laurent Pinchart wrote:\n> On Tue, Nov 26, 2024 at 03:12:03PM +0000, Daniel Scally wrote:\n>> Rather than hard coding default delays for control values in the\n>> pipeline handlers, pick up the ones defined in the CameraSensor\n>> properties.\n>>\n>> Reviewed-by: Jacopo Mondi \n>> Signed-off-by: Daniel Scally \n> Reviewed-by: Laurent Pinchart \nThanks\n> Any chance we could do the same for the Raspberry Pi pipeline handler,\n> and drop the delays from its IPA module (in a separate patch of course)\n> ?\n\nSure, will do.\n\n>\n>> ---\n>> Changes in v5:\n>>\n>> \t- Fixed the includes in each pipeline (remove property_ids.h, added\n>> \t camera_sensor_properties.h)\n>>\n>> Changes in v4:\n>>\n>> \t- Used the struct reference rather than values directly\n>>\n>> Changes in v3:\n>>\n>> \t- Fixed some broken alignment\n>>\n>> Changes in v2:\n>>\n>> \t- Switched to use the new getSensorDelays() function\n>>\n>> src/libcamera/pipeline/ipu3/ipu3.cpp | 11 ++++-------\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 ++++-------\n>> src/libcamera/pipeline/simple/simple.cpp | 6 ++++--\n>> 3 files changed, 12 insertions(+), 16 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index 0069d5e2..e31e3879 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -28,6 +28,7 @@\n>> #include \"libcamera/internal/camera.h\"\n>> #include \"libcamera/internal/camera_lens.h\"\n>> #include \"libcamera/internal/camera_sensor.h\"\n>> +#include \"libcamera/internal/camera_sensor_properties.h\"\n>> #include \"libcamera/internal/delayed_controls.h\"\n>> #include \"libcamera/internal/device_enumerator.h\"\n>> #include \"libcamera/internal/framebuffer.h\"\n>> @@ -1077,14 +1078,10 @@ int PipelineHandlerIPU3::registerCameras()\n>> \t\tif (ret)\n>> \t\t\tcontinue;\n>> \n>> -\t\t/*\n>> -\t\t * \\todo Read delay values from the sensor itself or from a\n>> -\t\t * a sensor database. For now use generic values taken from\n>> -\t\t * the Raspberry Pi and listed as 'generic values'.\n>> -\t\t */\n>> +\t\tconst CameraSensorProperties::SensorDelays &delays = cio2->sensor()->sensorDelays();\n>> \t\tstd::unordered_map params = {\n>> -\t\t\t{ V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n>> -\t\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n>> +\t\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n>> +\t\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n>> \t\t};\n>> \n>> \t\tdata->delayedCtrls_ =\n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index 6c6d711f..908724e2 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -34,6 +34,7 @@\n>> \n>> #include \"libcamera/internal/camera.h\"\n>> #include \"libcamera/internal/camera_sensor.h\"\n>> +#include \"libcamera/internal/camera_sensor_properties.h\"\n>> #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n>> #include \"libcamera/internal/delayed_controls.h\"\n>> #include \"libcamera/internal/device_enumerator.h\"\n>> @@ -1239,14 +1240,10 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n>> \t/* Initialize the camera properties. */\n>> \tdata->properties_ = data->sensor_->properties();\n>> \n>> -\t/*\n>> -\t * \\todo Read delay values from the sensor itself or from a\n>> -\t * a sensor database. For now use generic values taken from\n>> -\t * the Raspberry Pi and listed as generic values.\n>> -\t */\n>> +\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n>> \tstd::unordered_map params = {\n>> -\t\t{ V4L2_CID_ANALOGUE_GAIN, { 1, false } },\n>> -\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n>> +\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n>> +\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n>> \t};\n>> \n>> \tdata->delayedCtrls_ =\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index 41fdf84c..dae9f31f 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -31,6 +31,7 @@\n>> \n>> #include \"libcamera/internal/camera.h\"\n>> #include \"libcamera/internal/camera_sensor.h\"\n>> +#include \"libcamera/internal/camera_sensor_properties.h\"\n>> #include \"libcamera/internal/converter.h\"\n>> #include \"libcamera/internal/delayed_controls.h\"\n>> #include \"libcamera/internal/device_enumerator.h\"\n>> @@ -1290,9 +1291,10 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n>> \tif (outputCfgs.empty())\n>> \t\treturn 0;\n>> \n>> +\tconst CameraSensorProperties::SensorDelays &delays = data->sensor_->sensorDelays();\n>> \tstd::unordered_map params = {\n>> -\t\t{ V4L2_CID_ANALOGUE_GAIN, { 2, false } },\n>> -\t\t{ V4L2_CID_EXPOSURE, { 2, false } },\n>> +\t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n>> +\t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n>> \t};\n>> \tdata->delayedCtrls_ =\n>> \t\tstd::make_unique(data->sensor_->device(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74816C3213\n\tfor ;\n\tWed, 27 Nov 2024 09:06:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3188660A7;\n\tWed, 27 Nov 2024 10:06:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 907FC660A7\n\tfor ;\n\tWed, 27 Nov 2024 10:06:17 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 312D9792;\n\tWed, 27 Nov 2024 10:05:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Eqkq+ZKC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732698354;\n\tbh=xUunatwnNs+0ZHJMP5de/OT5Pdeas3afCRAAwu+Xmvg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Eqkq+ZKCn1hOzrzuoz/rn95lppbRJpmgxQCvJvV8ZldmrkqBKbB8OXXTRR4pawk+7\n\tQ+rO8FhtvCeHShhIbtT+kiWVRzH5cdJ4rQYDXpOo+BAXpSlA5wKh7gBhCYHSEtTrH9\n\tBo/ybWWIVS0O+qaymLaTYLmz90Q6ZzbHsO1Zbq84=","Message-ID":"","Date":"Wed, 27 Nov 2024 09:06:14 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 2/2] libcamera: pipelines: Draw control delays from\n\tCameraSensor properties","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, mike.rudenko@gmail.com,\n\tJacopo Mondi ","References":"<20241126151203.108407-1-dan.scally@ideasonboard.com>\n\t<20241126151203.108407-3-dan.scally@ideasonboard.com>\n\t<20241127070159.GS5461@pendragon.ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20241127070159.GS5461@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]