[{"id":32382,"web_url":"https://patchwork.libcamera.org/comment/32382/","msgid":"<173261354395.1143262.13823097817162310576@ping.linuxembedded.co.uk>","date":"2024-11-26T09:32:23","subject":"Re: [PATCH v4 2/4] ipa: ipu3: Add constructor to the IPA context","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-11-26 09:15:03)\n> Let's have a constructor that takes just the non-default argument,\n> without the need to specify the defaults.\n> \n> Signed-off-by: Milan Zamazal \n\nThank you for changing this one too!\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/ipu3/ipa_context.cpp | 4 ++++\n> src/ipa/ipu3/ipa_context.h | 5 +++++\n> src/ipa/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/ipu3/ipa_context.cpp b/src/ipa/ipu3/ipa_context.cpp\n> index 917d06541..76eeb52fe 100644\n> --- a/src/ipa/ipu3/ipa_context.cpp\n> +++ b/src/ipa/ipu3/ipa_context.cpp\n> @@ -39,6 +39,10 @@ namespace libcamera::ipa::ipu3 {\n> * \\struct IPAContext\n> * \\brief Global IPA context data shared between all algorithms\n> *\n> + * \\fn IPAContext::IPAContext\n> + * \\brief Initialize the instance with the given number of frame contexts\n> + * \\param[in] frameContextSize Size of the frame context ring buffer\n> + *\n> * \\var IPAContext::configuration\n> * \\brief The IPA session configuration, immutable during the session\n> *\n> diff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\n> index c85d1e34e..24f51a296 100644\n> --- a/src/ipa/ipu3/ipa_context.h\n> +++ b/src/ipa/ipu3/ipa_context.h\n> @@ -84,6 +84,11 @@ struct IPAFrameContext : public FrameContext {\n> };\n> \n> struct IPAContext {\n> + IPAContext(unsigned int frameContextSize)\n> + : frameContexts(frameContextSize)\n> + {\n> + }\n> +\n> IPASessionConfiguration configuration;\n> IPAActiveState activeState;\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index 89c3192c6..b65dea122 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -187,7 +187,7 @@ private:\n> };\n> \n> IPAIPU3::IPAIPU3()\n> - : context_({ {}, {}, { kMaxFrameContexts }, {} })\n> + : context_(kMaxFrameContexts)\n> {\n> }\n> \n> -- \n> 2.44.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B372BD16B\n\tfor ;\n\tTue, 26 Nov 2024 09:32:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 462C965FBA;\n\tTue, 26 Nov 2024 10:32:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F28A65FAA\n\tfor ;\n\tTue, 26 Nov 2024 10:32:26 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6842BBC0;\n\tTue, 26 Nov 2024 10:32:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZFARFmAd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732613524;\n\tbh=11+Fb+qI//5Krzxp+Ipujxz14Ybnj9DNDKA1qHG1z8o=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ZFARFmAd3yAhvTI90W3OKdY6KWP2KCiPsLunOaYKT83QVlXZAry0O3h18Bps6ZdFu\n\t2hz7QeWALcyI3WzGOech/5P1sBsmBYYp5OGt+YKLww6wtJ0qGr+3WL4h3HyaFhKFVT\n\t4S1I5YgS6kirCFywoMsGX6V3uJCrEBOEvPF9y6xI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241126091509.89677-3-mzamazal@redhat.com>","References":"<20241126091509.89677-1-mzamazal@redhat.com>\n\t<20241126091509.89677-3-mzamazal@redhat.com>","Subject":"Re: [PATCH v4 2/4] ipa: ipu3: Add constructor to the IPA context","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Nov 2024 09:32:23 +0000","Message-ID":"<173261354395.1143262.13823097817162310576@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]