[{"id":32381,"web_url":"https://patchwork.libcamera.org/comment/32381/","msgid":"<173261352174.1143262.15418163580080317892@ping.linuxembedded.co.uk>","date":"2024-11-26T09:32:01","subject":"Re: [PATCH v4 1/4] ipa: software_isp: Add constructor to the IPA\n\tcontext","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-11-26 09:15:02)\n> Let's have a constructor that takes just the non-default argument,\n> without the need to specify the defaults.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/simple/ipa_context.h | 5 +++++\n> src/ipa/simple/soft_simple.cpp | 2 +-\n> 2 files changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> index fd121eebe..fd7343e91 100644\n> --- a/src/ipa/simple/ipa_context.h\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -59,6 +59,11 @@ struct IPAFrameContext : public FrameContext {\n> };\n> \n> struct IPAContext {\n> + IPAContext(unsigned int frameContextSize)\n> + : frameContexts(frameContextSize)\n> + {\n> + }\n> +\n> IPASessionConfiguration configuration;\n> IPAActiveState activeState;\n> FCQueue frameContexts;\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index ac2a94210..67ccc9ae0 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -41,7 +41,7 @@ class IPASoftSimple : public ipa::soft::IPASoftInterface, public Module\n> {\n> public:\n> IPASoftSimple()\n> - : context_({ {}, {}, { kMaxFrameContexts } })\n> + : context_(kMaxFrameContexts)\n> {\n> }\n> \n> -- \n> 2.44.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02797BD16B\n\tfor ;\n\tTue, 26 Nov 2024 09:32:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EF9F65FAD;\n\tTue, 26 Nov 2024 10:32:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B9A4A65EF7\n\tfor ;\n\tTue, 26 Nov 2024 10:32:04 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A959526;\n\tTue, 26 Nov 2024 10:31:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ENpaL9sR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732613502;\n\tbh=N2UxHdb17GvhL4rUeAVcI+yLfmwB61u8WzHnrMAl/tM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ENpaL9sRY18u5HuMpgbpOC9eLuoMfkyrbW4Qer54Lzf4o/Zixm0snwgQLx1qYWM3T\n\tOTmzGs/feCfg+83HyUy/r6KIzR3TEWUXBvCg+ZUadrk7DzXdeO5qWdPs91dfmGHWdn\n\tGNXQfpUyx9hVDUW5Xe1Cx2+F1VEEb7N5cM12eyFI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241126091509.89677-2-mzamazal@redhat.com>","References":"<20241126091509.89677-1-mzamazal@redhat.com>\n\t<20241126091509.89677-2-mzamazal@redhat.com>","Subject":"Re: [PATCH v4 1/4] ipa: software_isp: Add constructor to the IPA\n\tcontext","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Nov 2024 09:32:01 +0000","Message-ID":"<173261352174.1143262.15418163580080317892@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]