{"id":22077,"url":"https://patchwork.libcamera.org/api/patches/22077/?format=json","web_url":"https://patchwork.libcamera.org/patch/22077/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241125153003.3309066-2-paul.elder@ideasonboard.com>","date":"2024-11-25T15:30:00","name":"[1/4] libcamera: controls: Populate direction field in control definitions","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8c70f2caeb4bb706bcaec4a8b92731319ec91984","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22077/mbox/","series":[{"id":4819,"url":"https://patchwork.libcamera.org/api/series/4819/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4819","date":"2024-11-25T15:29:59","name":"Add direction field to ControlId","version":1,"mbox":"https://patchwork.libcamera.org/series/4819/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22077/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22077/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5E86C32A3\n\tfor ;\n\tMon, 25 Nov 2024 15:30:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 533E366030;\n\tMon, 25 Nov 2024 16:30:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95D7D65F6B\n\tfor ;\n\tMon, 25 Nov 2024 16:30:15 +0100 (CET)","from neptunite.flets-east.jp (unknown\n\t[IPv6:2404:7a81:160:2100:9d06:dcbb:7303:4be6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D55C6B5;\n\tMon, 25 Nov 2024 16:29:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GNj0a2gM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732548594;\n\tbh=HdaC5RTSGQkQQtvuOETAKDkk2V7quRdGa1vNc+DFB/E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GNj0a2gMYfKf/4apoUZaHdmaMZnNzhkQhPQf7+uJv0f3zY8Jv2XXZHMgaPO6S/FAU\n\t4EVCHlPNgPb4hB+VUnfpg1IOj+xpurjy3upSgO7zrIVygrBfSUv1jTtVLXBH8YacCm\n\tlypjEbPbLJCvLSuv/Sax2mz8xUQRXGGGvImclgqk=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Cc":"Paul Elder ","Subject":"[PATCH 1/4] libcamera: controls: Populate direction field in control\n\tdefinitions","Date":"Tue, 26 Nov 2024 00:30:00 +0900","Message-Id":"<20241125153003.3309066-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.39.2","In-Reply-To":"<20241125153003.3309066-1-paul.elder@ideasonboard.com>","References":"<20241125153003.3309066-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation for adding support for querying direction information\nfrom controls, populate the corresponding field in the control ID\ndefintions.\n\nSigned-off-by: Paul Elder \n---\n src/libcamera/control_ids_core.yaml | 12 ++++++++++++\n src/libcamera/control_ids_draft.yaml | 7 +++++++\n 2 files changed, 19 insertions(+)","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex d34a2d068b60..c0e91d1852cd 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -17,6 +17,7 @@ controls:\n \n - AeLocked:\n type: bool\n+ direction: out\n description: |\n Report the lock status of a running AE algorithm.\n \n@@ -236,6 +237,7 @@ controls:\n \n - AeFlickerDetected:\n type: int32_t\n+ direction: out\n description: |\n Flicker period detected in microseconds.\n \n@@ -274,6 +276,7 @@ controls:\n \n - Lux:\n type: float\n+ direction: out\n description: |\n Report an estimate of the current illuminance level in lux.\n \n@@ -324,6 +327,7 @@ controls:\n \n - AwbLocked:\n type: bool\n+ direction: out\n description: |\n Report the lock status of a running AWB algorithm.\n \n@@ -361,6 +365,7 @@ controls:\n \n - SensorBlackLevels:\n type: int32_t\n+ direction: out\n description: |\n Reports the sensor black levels used for processing a frame.\n \n@@ -385,6 +390,7 @@ controls:\n \n - FocusFoM:\n type: int32_t\n+ direction: out\n description: |\n Reports a Figure of Merit (FoM) to indicate how in-focus the frame is.\n \n@@ -442,6 +448,7 @@ controls:\n \n - FrameDuration:\n type: int64_t\n+ direction: out\n description: |\n The instantaneous frame duration from start of frame exposure to start\n of next exposure, expressed in microseconds.\n@@ -450,6 +457,7 @@ controls:\n \n - FrameDurationLimits:\n type: int64_t\n+ direction: in\n description: |\n The minimum and maximum (in that order) frame duration, expressed in\n microseconds.\n@@ -487,6 +495,7 @@ controls:\n \n - SensorTemperature:\n type: float\n+ direction: out\n description: |\n Temperature measure from the camera sensor in Celsius.\n \n@@ -499,6 +508,7 @@ controls:\n \n - SensorTimestamp:\n type: int64_t\n+ direction: out\n description: |\n The time when the first row of the image sensor active array is exposed.\n \n@@ -667,6 +677,7 @@ controls:\n \n - AfTrigger:\n type: int32_t\n+ direction: in\n description: |\n Start an autofocus scan.\n \n@@ -692,6 +703,7 @@ controls:\n \n - AfPause:\n type: int32_t\n+ direction: in\n description: |\n Pause lens movements when in continuous autofocus mode.\n \ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 1b284257f601..59aa6141c25c 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -79,6 +79,7 @@ controls:\n \n - AeState:\n type: int32_t\n+ direction: out\n description: |\n Control to report the current AE algorithm state. Currently identical to\n ANDROID_CONTROL_AE_STATE.\n@@ -108,6 +109,7 @@ controls:\n \n - AwbState:\n type: int32_t\n+ direction: out\n description: |\n Control to report the current AWB algorithm state. Currently identical\n to ANDROID_CONTROL_AWB_STATE.\n@@ -129,6 +131,7 @@ controls:\n \n - SensorRollingShutterSkew:\n type: int64_t\n+ direction: out\n description: |\n Control to report the time between the start of exposure of the first\n row and the start of exposure of the last row. Currently identical to\n@@ -262,6 +265,7 @@ controls:\n \n - FaceDetectFaceRectangles:\n type: Rectangle\n+ direction: out\n description: |\n Boundary rectangles of the detected faces. The number of values is\n the number of detected faces.\n@@ -273,6 +277,7 @@ controls:\n \n - FaceDetectFaceScores:\n type: uint8_t\n+ direction: out\n description: |\n Confidence score of each of the detected faces. The range of score is\n [0, 100]. The number of values should be the number of faces reported\n@@ -285,6 +290,7 @@ controls:\n \n - FaceDetectFaceLandmarks:\n type: Point\n+ direction: out\n description: |\n Array of human face landmark coordinates in format [..., left_eye_i,\n right_eye_i, mouth_i, left_eye_i+1, ...], with i = index of face. The\n@@ -298,6 +304,7 @@ controls:\n \n - FaceDetectFaceIds:\n type: int32_t\n+ direction: out\n description: |\n Each detected face is given a unique ID that is valid for as long as the\n face is visible to the camera device. A face that leaves the field of\n","prefixes":["1/4"]}