[{"id":2946,"web_url":"https://patchwork.libcamera.org/comment/2946/","msgid":"<20191022135541.GC21838@pendragon.ideasonboard.com>","date":"2019-10-22T13:55:41","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Remove rogue '; '","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Oct 22, 2019 at 03:35:51PM +0200, Jacopo Mondi wrote:\n> The ';' at the end of an inline method declaration is not required.\n> \n> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/libcamera/controls.h | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 0d279d508dcc..42e6df7e613d 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -30,8 +30,8 @@ public:\n>  \tControlValue(int32_t value);\n>  \tControlValue(int64_t value);\n>  \n> -\tControlType type() const { return type_; };\n> -\tbool isNone() const { return type_ == ControlTypeNone; };\n> +\tControlType type() const { return type_; }\n> +\tbool isNone() const { return type_ == ControlTypeNone; }\n>  \n>  \ttemplate<typename T>\n>  \tconst T &get() const;","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 220C76137A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Oct 2019 15:55:47 +0200 (CEST)","from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net\n\t[93.2.121.143])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A18EE595;\n\tTue, 22 Oct 2019 15:55:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1571752546;\n\tbh=W6dF5Ze7DWrqZNn9L9EBPo64Fv34PhEajLVWGlIVQ8Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HECP6oBbs7z33JK+CTU+RiwsI8aVzMWblbyaY/mlPi/CXk9/s2oZT7BS7UUMaXqjY\n\tkFEHzFaOG9VGR3X9xuJfD+IMCU9R773OCJUn02VEhjDA8vkyXQwDaftB/8jyDXm0X0\n\toyvPEY9q9vGBoJzrX/G1pxDfCcLxeH5yv3QWLoAQ=","Date":"Tue, 22 Oct 2019 16:55:41 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191022135541.GC21838@pendragon.ideasonboard.com>","References":"<20191022133551.17763-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191022133551.17763-1-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Remove rogue '; '","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 22 Oct 2019 13:55:47 -0000"}}]