{"id":2207,"url":"https://patchwork.libcamera.org/api/patches/2207/?format=json","web_url":"https://patchwork.libcamera.org/patch/2207/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20191022133551.17763-1-jacopo@jmondi.org>","date":"2019-10-22T13:35:51","name":"[libcamera-devel] libcamera: controls: Remove rogue ';'","commit_ref":"408c98ea456a63e3820fe264039a0ff240984372","pull_url":null,"state":"accepted","archived":false,"hash":"83104899e9f42f6ebd6318d9d65e2bb9b109598d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2207/mbox/","series":[{"id":540,"url":"https://patchwork.libcamera.org/api/series/540/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=540","date":"2019-10-22T13:35:51","name":"[libcamera-devel] libcamera: controls: Remove rogue ';'","version":1,"mbox":"https://patchwork.libcamera.org/series/540/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2207/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2207/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3B8D6137A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Oct 2019 15:34:06 +0200 (CEST)","from uno.localdomain (143.121.2.93.rev.sfr.net [93.2.121.143])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 513D624001F;\n\tTue, 22 Oct 2019 13:34:06 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 22 Oct 2019 15:35:51 +0200","Message-Id":"<20191022133551.17763-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.23.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: controls: Remove rogue ';'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 22 Oct 2019 13:34:07 -0000"},"content":"The ';' at the end of an inline method declaration is not required.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/controls.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 0d279d508dcc..42e6df7e613d 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -30,8 +30,8 @@ public:\n \tControlValue(int32_t value);\n \tControlValue(int64_t value);\n \n-\tControlType type() const { return type_; };\n-\tbool isNone() const { return type_ == ControlTypeNone; };\n+\tControlType type() const { return type_; }\n+\tbool isNone() const { return type_ == ControlTypeNone; }\n \n \ttemplate<typename T>\n \tconst T &get() const;\n","prefixes":["libcamera-devel"]}