[{"id":32364,"web_url":"https://patchwork.libcamera.org/comment/32364/","msgid":"","date":"2024-11-25T18:06:17","subject":"Re: [PATCH v2 1/8] libcamera: rkisp1: Fix scope of dewarper stop()\n\texit action","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Mon, Nov 25, 2024 at 04:14:10PM +0100, Stefan Klug wrote:\n> Move the definition of the dewarper stop() action into the scope were\n> the corresponding start() happens.\n>\n> Fixes: 12b553d691d4 (\"libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\")\n> Signed-off-by: Stefan Klug \n>\n\nExtraneous blank line ;)\n\n> Reviewed-by: Paul Elder \n> Reviewed-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 6c6d711f91b3..5ffcfbce56be 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1043,8 +1043,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL\n> \t\t\t\tLOG(RkISP1, Error) << \"Failed to start dewarper\";\n> \t\t\t\treturn ret;\n> \t\t\t}\n> +\t\t\tactions += [&]() { dewarper_->stop(); };\n> \t\t}\n> -\t\tactions += [&]() { dewarper_->stop(); };\n> \t}\n>\n> \tif (data->mainPath_->isEnabled()) {\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9199C3274\n\tfor ;\n\tMon, 25 Nov 2024 18:06:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F10666034;\n\tMon, 25 Nov 2024 19:06:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CE8765F66\n\tfor ;\n\tMon, 25 Nov 2024 19:06:21 +0100 (CET)","from ideasonboard.com (mob-5-90-139-188.net.vodafone.it\n\t[5.90.139.188])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 533BA6B5;\n\tMon, 25 Nov 2024 19:05:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hn4heYO1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732557959;\n\tbh=ayNOCIjfCfL7oV+uMCpo9kAO8OwIkdIA7zzAeP6qKR4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hn4heYO1iTDPsGBHIJDN4nSs6aFfvCei2wI3/7bMxUgFyvqx9yKJZAhnrji7YuIcb\n\tcCKxD799wG6Cp8IZkOO6V/NXFmKrPR19KxeHM885eqgH9aashN8dRdD3N94SAFCDTa\n\toWW2lnIVXyyic4jFVEI/CVQQEfTojeBmVUF9INto=","Date":"Mon, 25 Nov 2024 19:06:17 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org, \n\tPaul Elder ,\n\tJacopo Mondi ","Subject":"Re: [PATCH v2 1/8] libcamera: rkisp1: Fix scope of dewarper stop()\n\texit action","Message-ID":"","References":"<20241125151430.2437285-1-stefan.klug@ideasonboard.com>\n\t<20241125151430.2437285-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241125151430.2437285-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]