[{"id":32358,"web_url":"https://patchwork.libcamera.org/comment/32358/","msgid":"","date":"2024-11-25T10:06:34","subject":"Re: [PATCH v3 5/5] libcamera: libipa: camera_sensor_helper: add\n\tIMX290 black level","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n\nOn Sun, Nov 24, 2024 at 08:29:50PM +0100, Geoffrey Van Landeghem wrote:\n> Report the default sensor black level reported by the datasheet.\n> Note that IMX327 and IMX462 depend on the IMX290 CameraSensorHelper.\n> That's fine since those sensors report the same defaults for the\n> black level as the Sony IMX290.\n>\n> Signed-off-by: Geoffrey Van Landeghem \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f870dc28..07657700 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -576,6 +576,8 @@ class CameraSensorHelperImx290 : public CameraSensorHelper\n> public:\n> \tCameraSensorHelperImx290()\n> \t{\n> +\t\t/* From datasheet: 0xF0 at 12bits. */\n\nnit: we usually use lowecase for hex\n\n> +\t\tblackLevel_ = 3840;\n\nLooks correct at 16 bpp.\n\nI can change the comment when applying, no worries\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \t\tgainType_ = AnalogueGainExponential;\n> \t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n> \t}\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78835BD160\n\tfor ;\n\tMon, 25 Nov 2024 10:06:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC73466021;\n\tMon, 25 Nov 2024 11:06:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 773FA66010\n\tfor ;\n\tMon, 25 Nov 2024 11:06:38 +0100 (CET)","from ideasonboard.com (mob-5-90-136-47.net.vodafone.it\n\t[5.90.136.47])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFBDE6B5;\n\tMon, 25 Nov 2024 11:06:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rMUzlrUd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732529176;\n\tbh=IuCwL9wVax3B+Xe9kggRmbP2sdYfNSw5xPF7UXUfHWg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rMUzlrUdlCd/ArGJzQh5BB6GMVhozKxKjKNfi7AYTH4WxqqhmvzBR3+s4M4P3WURh\n\ttX51p3J13BrTaION+CoVyGqbqfKrPwKWLxBzN2XQzDFOxr6owLdDt3O/IIrmYZ6fNy\n\tnxr74uKjUxj6pu5b66270bCCshOTh3Q//N82b3cQ=","Date":"Mon, 25 Nov 2024 11:06:34 +0100","From":"Jacopo Mondi ","To":"Geoffrey Van Landeghem ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 5/5] libcamera: libipa: camera_sensor_helper: add\n\tIMX290 black level","Message-ID":"","References":"<20241124192950.542686-1-geoffrey.vl@gmail.com>\n\t<20241124192950.542686-6-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241124192950.542686-6-geoffrey.vl@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]