{"id":22064,"url":"https://patchwork.libcamera.org/api/patches/22064/?format=json","web_url":"https://patchwork.libcamera.org/patch/22064/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241124192950.542686-6-geoffrey.vl@gmail.com>","date":"2024-11-24T19:29:50","name":"[v3,5/5] libcamera: libipa: camera_sensor_helper: add IMX290 black level","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"21226a892e74c38a74c55f5cac08121a3f5677cb","submitter":{"id":214,"url":"https://patchwork.libcamera.org/api/people/214/?format=json","name":"Geoffrey Van Landeghem","email":"geoffrey.vl@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22064/mbox/","series":[{"id":4815,"url":"https://patchwork.libcamera.org/api/series/4815/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4815","date":"2024-11-24T19:29:45","name":"Add support for Sony IMX327 and IMX462 sensors","version":3,"mbox":"https://patchwork.libcamera.org/series/4815/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22064/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22064/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E754C3311\n\tfor ;\n\tSun, 24 Nov 2024 19:30:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 710406600B;\n\tSun, 24 Nov 2024 20:30:05 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22DB866004\n\tfor ;\n\tSun, 24 Nov 2024 20:30:01 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-4349e4e252dso3658385e9.0\n\tfor ;\n\tSun, 24 Nov 2024 11:30:01 -0800 (PST)","from localhost.localdomain\n\t(ptr-gh3gmp9ck9bx99mg7lb.18120a2.ip6.access.telenet.be.\n\t[2a02:1812:2512:400:400a:4d18:885b:f46f])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-433b463ab6csm169691645e9.35.2024.11.24.11.29.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 24 Nov 2024 11:29:58 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"M6rOg8zp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1732476600; x=1733081400;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=neUXGfzfS0Z/CEm9uX4Za1tzbcsXlm78S0zLa/twTLo=;\n\tb=M6rOg8zp3PsR9h4K0DcETD7VHAOyqGUnvIIUuiphZsJrLsptSqEDWhWjwl/r1Opx4S\n\t74USuRdpcEkc3dzuAaYgDkm1xHvcwv3lW/CMi718+SZB8yQkfQbgDsix4Rz57d+sFa0Y\n\tpnMg+PO3jR/qs8wL4LpvShW6cy+bal5n9v3aVCG5r8i3Qc5KBNHLF+dAwqz2kuhVuC/i\n\tjigeLHFj/bAEbcAN8R/UqAPrS81yTd1i66knSORVAg1Cz5thLqcv7OMH3q+4p/vbDTU7\n\tkMFYkZxRmH9dIzTeln0VZGyZQgcWUvlnd28KYPs9iE0xxuLrO0mVXaJ02vclxEhu3Hf3\n\tPGeA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732476600; x=1733081400;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=neUXGfzfS0Z/CEm9uX4Za1tzbcsXlm78S0zLa/twTLo=;\n\tb=MT8u8n76Yn14AoTqeHmLYXB9jaiXYc6OW9Ml7Wq9j8AGXJGrwu95WmPqsQBeuOdFNe\n\tLwH56nywSALitjkhVUBKququmDuT0rBgVs6a5whucHTHv3UnkFE0Yd4WO6G66zAA9QBP\n\t09JtVHOwYqym8muhgyr/30zIrh/AieIHSRimeCwD9+XytZuxv6nncVt+aI9BxO6HYdUX\n\to2V3RgWJpPplw+m6EpMZKAh7bz4IbxTdEp2IawZ6rnrNKKGlSNoWvOEZsDXyfyz2LLsN\n\tNMefEWRO+B/JXvu35My8w1ctDHATKEIey0p+zMU8/TNYBvk3hjGXjkc6ZLuj3crJ9XNa\n\tEUTg==","X-Gm-Message-State":"AOJu0YxZ0ROIznpnA/0JcZs6QUv6bGLud6dsqzbFgF/iejiLNOKV/irZ\n\teETzlln7VfS5PaWfOeWWvNiyldmgUhF7XhtpDp4MPkcolrluiXAYKs4fBg==","X-Gm-Gg":"ASbGncuorGdgbuPJFVsuwRPXdFz2tSIGSabZr9QFjW4XgtYJjSC12WHxoJqQ0txG64s\n\tFQKHOORyLDFdB00nkDEV77ufNuUK4DLcQe2pcZfVr4UjNetwwNqtMxOuk5/OI2voRji1SsfSXzH\n\t7hKeHo8fvK9HY+LN9l5935UIkTWJgaINVAwSVQP7S0x7guVtnv0u4VBhat5vCy3HxV3DdN2P2Gf\n\tZ+l6cGiQm9msnXBvnH2ptWAHPgsfZ83+hRAbtw47NbW/4/16MJkaYUnNoe+BRKbrT49v55hOQfN\n\tFIXiImeyzndw2K2LvP7PL5L3kWnnAmZuuEQu9vyvkO5a2T3eFQTwBJY=","X-Google-Smtp-Source":"AGHT+IFXjQrvwNbAXVntyCuxEJBhd63Hxz3VGYUcp3u85i9j5XsfRJLS9arYSqiWSxR+8o0c16Z92Q==","X-Received":"by 2002:a05:600c:4447:b0:431:55bf:fe4 with SMTP id\n\t5b1f17b1804b1-433ce491837mr89917955e9.24.1732476599725; \n\tSun, 24 Nov 2024 11:29:59 -0800 (PST)","From":"Geoffrey Van Landeghem ","To":"libcamera-devel@lists.libcamera.org","Cc":"Geoffrey Van Landeghem ","Subject":"[PATCH v3 5/5] libcamera: libipa: camera_sensor_helper: add IMX290\n\tblack level","Date":"Sun, 24 Nov 2024 20:29:50 +0100","Message-ID":"<20241124192950.542686-6-geoffrey.vl@gmail.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241124192950.542686-1-geoffrey.vl@gmail.com>","References":"<20241124192950.542686-1-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Report the default sensor black level reported by the datasheet.\nNote that IMX327 and IMX462 depend on the IMX290 CameraSensorHelper.\nThat's fine since those sensors report the same defaults for the\nblack level as the Sony IMX290.\n\nSigned-off-by: Geoffrey Van Landeghem \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex f870dc28..07657700 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -576,6 +576,8 @@ class CameraSensorHelperImx290 : public CameraSensorHelper\n public:\n \tCameraSensorHelperImx290()\n \t{\n+\t\t/* From datasheet: 0xF0 at 12bits. */\n+\t\tblackLevel_ = 3840;\n \t\tgainType_ = AnalogueGainExponential;\n \t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n \t}\n","prefixes":["v3","5/5"]}