[{"id":32352,"web_url":"https://patchwork.libcamera.org/comment/32352/","msgid":"<xjnj5wawiskhrwb2adovynwtqoh7rynfylaofgskfcwub7j56a@j5b3ocvc3cdn>","date":"2024-11-25T09:52:29","subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n  thanks for the patch\n\nOn Sun, Nov 24, 2024 at 08:29:46PM +0100, Geoffrey Van Landeghem wrote:\n> The sensor is largely compatible with the already supported\n> Sony IMX290 so we can reuse the same helpers for the analogue\n> gain conversion functions.\n>\n> Signed-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n\nWhen you receive a tag on patch series version vX you should carry it\nforward in version v(X + 1)\n\nFeels a bit clunky doing that by hand, I know\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 5 +++++\n>  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp      | 1 +\n>  src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n>  3 files changed, 10 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c6169bdc..f870dc28 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -622,6 +622,11 @@ public:\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n>\n> +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> +{\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> +\n>  class CameraSensorHelperImx477 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index e57ab538..0cc24a6d 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -73,3 +73,4 @@ static CamHelper *create()\n>  }\n>\n>  static RegisterCamHelper reg(\"imx290\", &create);\n> +static RegisterCamHelper reg462(\"imx462\", &create);\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 6d4136d0..e2305166 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -142,6 +142,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>  \t\t\t.unitCellSize = { 1450, 1450 },\n>  \t\t\t.testPatternModes = {},\n>  \t\t} },\n> +\t\t{ \"imx462\", {\n> +\t\t\t.unitCellSize = { 2900, 2900 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n>  \t\t{ \"imx477\", {\n>  \t\t\t.unitCellSize = { 1550, 1550 },\n>  \t\t\t.testPatternModes = {},\n> --\n> 2.43.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B990C32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 09:52:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F29A66013;\n\tMon, 25 Nov 2024 10:52:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E18D36600E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 10:52:32 +0100 (CET)","from ideasonboard.com (mob-5-90-136-47.net.vodafone.it\n\t[5.90.136.47])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 413594AD;\n\tMon, 25 Nov 2024 10:52:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KjQknR1i\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732528331;\n\tbh=8J98H1LzBvusYKqma2heiwsMdjvjPf4OafznFXVON1o=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KjQknR1i5whAcO3qbxmITrKWH9Y0j2yhQ9DBshcGEQTK8CFNlh345FexVs6VsxPSA\n\txHyLsImhYQVaAV9pgSHxRZ38b1GY90WX+2y3NFh+na8QbsP7WKl2dFt7zYHiZByvqo\n\trwD/I0JJpwfYZlM+4mPXKtD1uvmR0QnO3xyY6NH8=","Date":"Mon, 25 Nov 2024 10:52:29 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Geoffrey Van Landeghem <geoffrey.vl@gmail.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","Message-ID":"<xjnj5wawiskhrwb2adovynwtqoh7rynfylaofgskfcwub7j56a@j5b3ocvc3cdn>","References":"<20241124192950.542686-1-geoffrey.vl@gmail.com>\n\t<20241124192950.542686-2-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241124192950.542686-2-geoffrey.vl@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":32353,"web_url":"https://patchwork.libcamera.org/comment/32353/","msgid":"<CABX3Wh7X_aS7FMwp_4JpiKTYpgnr24f23MeON7=GH5tVD1OZyw@mail.gmail.com>","date":"2024-11-25T09:57:15","subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","submitter":{"id":214,"url":"https://patchwork.libcamera.org/api/people/214/","name":"Geoffrey Van Landeghem","email":"geoffrey.vl@gmail.com"},"content":"Hi Jacopo,\n\nah OK, so not every new version of a patch has to be reviewed entirely\nagain then?\nThanks for the clarification, I'll take it along with any other remarks\nthat you still have.\n\nGeoffrey\n\n\nOp ma 25 nov 2024 om 10:52 schreef Jacopo Mondi <\njacopo.mondi@ideasonboard.com>:\n\n> Hi Geoffrey\n>   thanks for the patch\n>\n> On Sun, Nov 24, 2024 at 08:29:46PM +0100, Geoffrey Van Landeghem wrote:\n> > The sensor is largely compatible with the already supported\n> > Sony IMX290 so we can reuse the same helpers for the analogue\n> > gain conversion functions.\n> >\n> > Signed-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n>\n> When you receive a tag on patch series version vX you should carry it\n> forward in version v(X + 1)\n>\n> Feels a bit clunky doing that by hand, I know\n>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n>\n> Thanks\n>   j\n>\n> > ---\n> >  src/ipa/libipa/camera_sensor_helper.cpp           | 5 +++++\n> >  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp      | 1 +\n> >  src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> >  3 files changed, 10 insertions(+)\n> >\n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp\n> b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index c6169bdc..f870dc28 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -622,6 +622,11 @@ public:\n> >  };\n> >  REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n> >\n> > +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> > +{\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> > +\n> >  class CameraSensorHelperImx477 : public CameraSensorHelper\n> >  {\n> >  public:\n> > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > index e57ab538..0cc24a6d 100644\n> > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > @@ -73,3 +73,4 @@ static CamHelper *create()\n> >  }\n> >\n> >  static RegisterCamHelper reg(\"imx290\", &create);\n> > +static RegisterCamHelper reg462(\"imx462\", &create);\n> > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp\n> b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > index 6d4136d0..e2305166 100644\n> > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > @@ -142,6 +142,10 @@ const CameraSensorProperties\n> *CameraSensorProperties::get(const std::string &sen\n> >                       .unitCellSize = { 1450, 1450 },\n> >                       .testPatternModes = {},\n> >               } },\n> > +             { \"imx462\", {\n> > +                     .unitCellSize = { 2900, 2900 },\n> > +                     .testPatternModes = {},\n> > +             } },\n> >               { \"imx477\", {\n> >                       .unitCellSize = { 1550, 1550 },\n> >                       .testPatternModes = {},\n> > --\n> > 2.43.0\n> >\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CEDDBD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 09:57:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74C1966013;\n\tMon, 25 Nov 2024 10:57:29 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AB2066010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 10:57:28 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id\n\t4fb4d7f45d1cf-5cece886771so6572406a12.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 01:57:28 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m5AtpXzv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1732528648; x=1733133448;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=KFU1BriKMLsKYe5wmEQO38sqJwLIZETsATQSBul4WpY=;\n\tb=m5AtpXzvkoSo2CpSbSaoPBl6UtZgwlue+6PQ/y/rWzGzqK2+snZ50fxHf2CtcLFeBj\n\tHooTAIldhuAY9MhAxtVryjzb5gtkYXGDHALZUiywabUkO1RoingZh1+s5fOgr092Ds6q\n\tkxGRw3WghN+lCYGJuVnws7+a23mwt5gn0hiJ5Vv6Cc/m6LVTYC67TrPHrD7fdjm8H/PR\n\tPkNVwBURQinTq2DNCXeRTY6vDIq+tt4xUIpIuUW9gOZ/6dQSOnhgg9JnUZkNRsoev/iQ\n\teDAqW67coWkLMr1rNTDPt8ik6qH5iM/Y7bkvffSgscYumk4K32XpW9HUMNaMoSOOmnKk\n\t1ItA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1732528648; x=1733133448;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=KFU1BriKMLsKYe5wmEQO38sqJwLIZETsATQSBul4WpY=;\n\tb=Z3ZjvRZkQ9Kh0QHWPN8V4N+a3vJ1toEmsGd4VJN1D9GfoeuH72onlMqDVHMXafj/Xe\n\tcHqwdWy73RRY95SI+9OzSjxzqureRZnJwke9xoB50lgd1uwy8buaJx3BsBvV7OYATsI5\n\tUHFFFf1rfUuITfUfftZ9bPfxaMbrhHXXtqCYuNBX6A8BBJ/vd/c6f9zTVXYTeqBSkuTC\n\tgFRmmgS3OTI1y/ewgon6xz8NJ16gH66KTvM9VOCuQ3G6BkUczwekP6JifKm/AMlG2rkt\n\t6VBVQrbRFeeMS/P65tiqgpfHjzUJLS4e41BjELh0fqQgKzOWiDK/Eecs0uNnxFwzbV08\n\trz2g==","X-Gm-Message-State":"AOJu0YyPSSnR4ww8HvK4BQO27KmfSe5eTKkF3DXx6skDXAUnxBL4aeTK\n\t/l6TBRv3rDvX51djyzjjqw7gSvv6Yxw3Bbv2bYebzW1N20VloTZ/7nTNLGy74FEtqawzwoXkeqh\n\tdmHsAJrv1Wg0jUpj+IqP3ubx1098JQOhX","X-Gm-Gg":"ASbGnctt4BRja4NgKvl9tPvrLkCEVJShs3e8jNV614CTDssn9n8ldVBxNnCkSsb3qT6\n\tKmNCWREcvdtbBm4c+SUMpa7eGMiO1MF7MJw==","X-Google-Smtp-Source":"AGHT+IFs+6HtYJCHdCeFjYQ5wdLat90pKPuEfI47zWKIi7bhc+dmSAOy5XRMGYOOEWsf77rjdWgASZOsLd7ykLrmtHI=","X-Received":"by 2002:a05:6402:2686:b0:5cf:d341:dfec with SMTP id\n\t4fb4d7f45d1cf-5d0073daa0cmr16588806a12.0.1732528646125;\n\tMon, 25 Nov 2024 01:57:26 -0800 (PST)","MIME-Version":"1.0","References":"<20241124192950.542686-1-geoffrey.vl@gmail.com>\n\t<20241124192950.542686-2-geoffrey.vl@gmail.com>\n\t<xjnj5wawiskhrwb2adovynwtqoh7rynfylaofgskfcwub7j56a@j5b3ocvc3cdn>","In-Reply-To":"<xjnj5wawiskhrwb2adovynwtqoh7rynfylaofgskfcwub7j56a@j5b3ocvc3cdn>","From":"Geoffrey Van Landeghem <geoffrey.vl@gmail.com>","Date":"Mon, 25 Nov 2024 10:57:15 +0100","Message-ID":"<CABX3Wh7X_aS7FMwp_4JpiKTYpgnr24f23MeON7=GH5tVD1OZyw@mail.gmail.com>","Subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000008400060627b9c2a7\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":32359,"web_url":"https://patchwork.libcamera.org/comment/32359/","msgid":"<w3fmsnsnn45cgu3yq3kglstkma4eaberrj46zmt7gfybze2si5@c7bitthz7xus>","date":"2024-11-25T10:10:03","subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n\nOn Mon, Nov 25, 2024 at 10:57:15AM +0100, Geoffrey Van Landeghem wrote:\n> Hi Jacopo,\n>\n> ah OK, so not every new version of a patch has to be reviewed entirely\n> again then?\n\nWell, it depends. If you make substantial changes to the new version\nyou can decide to drop a tag because you think the patch is worth a\nnew review (and maybe mention it in the cover letter).\n\nFor me, as a reviewer, if I've sent a tag and the tag is new patch\nversion and the patch hasn't changed, I'll just gloss over to make\nsure but won't go in a detailed review.\n\n> Thanks for the clarification, I'll take it along with any other remarks\n> that you still have.\n>\n\nThanks for sticking with us and getting through this sometimes\nunfriendly process.\n\n> Geoffrey\n>\n>\n> Op ma 25 nov 2024 om 10:52 schreef Jacopo Mondi <\n> jacopo.mondi@ideasonboard.com>:\n>\n> > Hi Geoffrey\n> >   thanks for the patch\n> >\n> > On Sun, Nov 24, 2024 at 08:29:46PM +0100, Geoffrey Van Landeghem wrote:\n> > > The sensor is largely compatible with the already supported\n> > > Sony IMX290 so we can reuse the same helpers for the analogue\n> > > gain conversion functions.\n> > >\n> > > Signed-off-by: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>\n> >\n> > When you receive a tag on patch series version vX you should carry it\n> > forward in version v(X + 1)\n> >\n> > Feels a bit clunky doing that by hand, I know\n> >\n> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n> >\n> > Thanks\n> >   j\n> >\n> > > ---\n> > >  src/ipa/libipa/camera_sensor_helper.cpp           | 5 +++++\n> > >  src/ipa/rpi/cam_helper/cam_helper_imx290.cpp      | 1 +\n> > >  src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> > >  3 files changed, 10 insertions(+)\n> > >\n> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp\n> > b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > index c6169bdc..f870dc28 100644\n> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > @@ -622,6 +622,11 @@ public:\n> > >  };\n> > >  REGISTER_CAMERA_SENSOR_HELPER(\"imx415\", CameraSensorHelperImx415)\n> > >\n> > > +class CameraSensorHelperImx462 : public CameraSensorHelperImx290\n> > > +{\n> > > +};\n> > > +REGISTER_CAMERA_SENSOR_HELPER(\"imx462\", CameraSensorHelperImx462)\n> > > +\n> > >  class CameraSensorHelperImx477 : public CameraSensorHelper\n> > >  {\n> > >  public:\n> > > diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > index e57ab538..0cc24a6d 100644\n> > > --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> > > @@ -73,3 +73,4 @@ static CamHelper *create()\n> > >  }\n> > >\n> > >  static RegisterCamHelper reg(\"imx290\", &create);\n> > > +static RegisterCamHelper reg462(\"imx462\", &create);\n> > > diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > index 6d4136d0..e2305166 100644\n> > > --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> > > @@ -142,6 +142,10 @@ const CameraSensorProperties\n> > *CameraSensorProperties::get(const std::string &sen\n> > >                       .unitCellSize = { 1450, 1450 },\n> > >                       .testPatternModes = {},\n> > >               } },\n> > > +             { \"imx462\", {\n> > > +                     .unitCellSize = { 2900, 2900 },\n> > > +                     .testPatternModes = {},\n> > > +             } },\n> > >               { \"imx477\", {\n> > >                       .unitCellSize = { 1550, 1550 },\n> > >                       .testPatternModes = {},\n> > > --\n> > > 2.43.0\n> > >\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB507C32A3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Nov 2024 10:10:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 250DC66020;\n\tMon, 25 Nov 2024 11:10:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E62D66010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Nov 2024 11:10:07 +0100 (CET)","from ideasonboard.com (mob-5-90-136-47.net.vodafone.it\n\t[5.90.136.47])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64AC46B5;\n\tMon, 25 Nov 2024 11:09:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VrKTnOin\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732529385;\n\tbh=9OJlEvxPfVGHsDWJtx+RCHdOvH3C0i6x/qJhVDREFk0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VrKTnOin5CflxyveFMNZnoyHsgs3M2DUdVJsrZrWNa/S56kjvPi+zLDW9wyQvFiL7\n\tMpkERkjw/hL3ffyIAyd8sxgmrq7e8fl4YuiXYcJgg2PF6BeSNmowh1410rVMnlWStO\n\toDYqIAVEe6r+H/U1GSS12nDJUR1EzZ5iuVWp9T+g=","Date":"Mon, 25 Nov 2024 11:10:03 +0100","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Geoffrey Van Landeghem <geoffrey.vl@gmail.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 1/5] libcamera: libipa: camera_sensor: Provide helper\n\tand properties for Sony IMX462","Message-ID":"<w3fmsnsnn45cgu3yq3kglstkma4eaberrj46zmt7gfybze2si5@c7bitthz7xus>","References":"<20241124192950.542686-1-geoffrey.vl@gmail.com>\n\t<20241124192950.542686-2-geoffrey.vl@gmail.com>\n\t<xjnj5wawiskhrwb2adovynwtqoh7rynfylaofgskfcwub7j56a@j5b3ocvc3cdn>\n\t<CABX3Wh7X_aS7FMwp_4JpiKTYpgnr24f23MeON7=GH5tVD1OZyw@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<CABX3Wh7X_aS7FMwp_4JpiKTYpgnr24f23MeON7=GH5tVD1OZyw@mail.gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]