[{"id":32327,"web_url":"https://patchwork.libcamera.org/comment/32327/","msgid":"<173218038749.1605529.13871727324360507980@ping.linuxembedded.co.uk>","date":"2024-11-21T09:13:07","subject":"Re: [PATCH v5 2/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc08a3 sensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Harvey Yang (2024-11-21 08:57:17)\n> From: Harvey Yang \n> \n> Provide the GalaxyCore gc08a3 camera sensor properties and registration\n> with libipa for the gain code helpers.\n> \n> Signed-off-by: Han-Lin Chen \n> Co-developed-by: Xing Gu \n> Co-developed-by: Yudhistira Erlandinata \n> Co-developed-by: Harvey Yang \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 13 +++++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 7 +++++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 3067d9bc1..e2da07723 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -532,6 +532,19 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"gc05a2\", CameraSensorHelperGc05a2)\n> \n> +class CameraSensorHelperGc08a3 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperGc08a3()\n> + {\n> + /* From datasheet: 64 at 10bits. */\n> + blackLevel_ = 4096;\n\n\nReviewed-by: Kieran Bingham \n\n> + gainType_ = AnalogueGainLinear;\n> + gainConstants_.linear = { 100, 0, 0, 1024 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n> +\n> class CameraSensorHelperImx214 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 2f048d4a3..a15004341 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -77,6 +77,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModeColorBars, 1 },\n> },\n> } },\n> + { \"gc08a3\", {\n> + .unitCellSize = { 1120, 1120 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 2 },\n> + },\n> + } },\n> { \"hi846\", {\n> .unitCellSize = { 1120, 1120 },\n> .testPatternModes = {\n> -- \n> 2.47.0.338.g60cca15819-goog\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F799C32F9\n\tfor ;\n\tThu, 21 Nov 2024 09:13:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED84865FBC;\n\tThu, 21 Nov 2024 10:13:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDC5D65FB0\n\tfor ;\n\tThu, 21 Nov 2024 10:13:10 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CF36670;\n\tThu, 21 Nov 2024 10:12:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eQCO6f6F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732180372;\n\tbh=upXq80KYXZO4xbXRSDsjZIwYzKxlJnEuiLcBe+kk/TI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=eQCO6f6FAdrfY2NgY5CfmT6sgRa/D8/5ekR3AcSPwoHxRYtPpvuDA0VxpQQwp9I87\n\tYxAw0nfbcaZuHo3F41vENYbcofoAhJXDc4MeUViekHUE070VV3xM1foSKV368/dGSs\n\tE31C+T7mPmEtl8c5dc7LrtkC64IUmt/YTC5+j1OU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20241121085800.3208123-3-chenghaoyang@chromium.org>","References":"<20241121085800.3208123-1-chenghaoyang@chromium.org>\n\t<20241121085800.3208123-3-chenghaoyang@chromium.org>","Subject":"Re: [PATCH v5 2/2] libcamera: libipa: camera_sensor: Add GalaxyCore\n\tgc08a3 sensor properties","From":"Kieran Bingham ","Cc":"Harvey Yang ,\n\tHan-Lin Chen , Xing Gu ,\n\tYudhistira Erlandinata ,\n\tHarvey Yang ","To":"Harvey Yang ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 21 Nov 2024 09:13:07 +0000","Message-ID":"<173218038749.1605529.13871727324360507980@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]