[{"id":32339,"web_url":"https://patchwork.libcamera.org/comment/32339/","msgid":"<4syktfjstl2tmgw5exowcoeh4ulqsyvhanrrvpmbuaul74koll@pvrvzn245mky>","date":"2024-11-21T15:43:37","subject":"Re: [PATCH 7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Wed, Nov 20, 2024 at 09:57:46AM +0100, Stefan Klug wrote:\n> The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\n> value. Add it to the rkisp1.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index c2ce38b1c253..647b5754bd55 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -24,6 +24,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -870,7 +871,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t\t\t * coordinates.\n> \t\t\t\t */\n> \t\t\t\tdewarperSensorCrop_ = outputCrop.mappedBetween(inputCrop,\n> -\t\t\t\t\t\t\t\t\t ipaConfig.sensorInfo.analogCrop);\n> +\t\t\t\t\t\t\t\t\t sensorInfo.analogCrop);\n\nWhy this change ?\n\n> \t\t\t}\n> \t\t} else if (hasSelfPath_) {\n> \t\t\tret = selfPath_.configure(cfg, format);\n> @@ -1247,6 +1248,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n> \t\t\t\t\t\t\t max,\n> \t\t\t\t\t\t\t max);\n> +\t\tdata->properties_.set(properties::ScalerCropMaximum, max);\n\nWhat about platforms without dewarper ?\n\n> \t\tactiveCrop_ = max;\n> \t}\n>\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65B6AC326C\n\tfor ;\n\tThu, 21 Nov 2024 15:43:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7466565FD4;\n\tThu, 21 Nov 2024 16:43:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BDC7B65FD0\n\tfor ;\n\tThu, 21 Nov 2024 16:43:40 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8043670;\n\tThu, 21 Nov 2024 16:43:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ajwm2XYX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732203801;\n\tbh=GiDN9DsyYVcYaPSBRsR1ioaNjvYOTfrVmAhoYXcHeI0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ajwm2XYX/OjKZ3Mgq567RMnOG8z3M7yLbZzlGCguo5wsnU8VUzw454wkDj6xXKpPL\n\t0ZxN7/NVRWjBuWrxSM/8hmP9bzuEt1yGVmPV5xeHMUa3kcPeNRd88DUE5+HbhHeu+V\n\tuQcMed/J/4rskdXH/XU2MuJ9qcKnil78QBRNF9kU=","Date":"Thu, 21 Nov 2024 16:43:37 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","Message-ID":"<4syktfjstl2tmgw5exowcoeh4ulqsyvhanrrvpmbuaul74koll@pvrvzn245mky>","References":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>\n\t<20241120085753.1993436-8-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241120085753.1993436-8-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32363,"web_url":"https://patchwork.libcamera.org/comment/32363/","msgid":"<2g3hja3soyj2xa5g4whnijuevrac6wjeftnk6a75phscpp4enm@obxre5lxneuc>","date":"2024-11-25T14:58:43","subject":"Re: [PATCH 7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the review.\n\nOn Thu, Nov 21, 2024 at 04:43:37PM +0100, Jacopo Mondi wrote:\n> Hi Stefan\n> \n> On Wed, Nov 20, 2024 at 09:57:46AM +0100, Stefan Klug wrote:\n> > The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\n> > value. Add it to the rkisp1.\n> >\n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index c2ce38b1c253..647b5754bd55 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -24,6 +24,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -870,7 +871,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > \t\t\t\t * coordinates.\n> > \t\t\t\t */\n> > \t\t\t\tdewarperSensorCrop_ = outputCrop.mappedBetween(inputCrop,\n> > -\t\t\t\t\t\t\t\t\t ipaConfig.sensorInfo.analogCrop);\n> > +\t\t\t\t\t\t\t\t\t sensorInfo.analogCrop);\n> \n> Why this change ?\n\nThanks for spotting. That belongs to \n\n[PATCH 5/7] pipeline: rkisp1: Reorder sensorInfo collection code\n\nI corrected that in v2.\n\n> \n> > \t\t\t}\n> > \t\t} else if (hasSelfPath_) {\n> > \t\t\tret = selfPath_.configure(cfg, format);\n> > @@ -1247,6 +1248,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> > \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n> > \t\t\t\t\t\t\t max,\n> > \t\t\t\t\t\t\t max);\n> > +\t\tdata->properties_.set(properties::ScalerCropMaximum, max);\n> \n> What about platforms without dewarper ?\n\nAtm there won't be scaler crop support. You mean the rockchips using\nresizer?\n\nBest regards,\nStefan\n\n> \n> > \t\tactiveCrop_ = max;\n> > \t}\n> >\n> > --\n> > 2.43.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 960E1BD160\n\tfor ;\n\tMon, 25 Nov 2024 14:58:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB01C65F60;\n\tMon, 25 Nov 2024 15:58:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E74F565F56\n\tfor ;\n\tMon, 25 Nov 2024 15:58:46 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4cf:a935:de6f:a329])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17F4AA2F;\n\tMon, 25 Nov 2024 15:58:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BYbaJgYK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732546705;\n\tbh=qIsEdLhAQgfyEekx/6DJvCXoDpr2t2aRS6+5NriotuE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BYbaJgYKcqZZMbcRtsZ0FmNzANy1weMQ/hXkCyq4/XmNZKl7XocXKeOLaHryISx89\n\tCW/EbOhxNgU38WPx6ZAazhD+CBxMmacsRHaHQ+REYdK0CwrIPhbfK2W08np91pza6t\n\tpWk6GJYPmkUYtmoLo5qXK9/lTZD21+DwQH3kbOCk=","Date":"Mon, 25 Nov 2024 15:58:43 +0100","From":"Stefan Klug ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","Message-ID":"<2g3hja3soyj2xa5g4whnijuevrac6wjeftnk6a75phscpp4enm@obxre5lxneuc>","References":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>\n\t<20241120085753.1993436-8-stefan.klug@ideasonboard.com>\n\t<4syktfjstl2tmgw5exowcoeh4ulqsyvhanrrvpmbuaul74koll@pvrvzn245mky>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<4syktfjstl2tmgw5exowcoeh4ulqsyvhanrrvpmbuaul74koll@pvrvzn245mky>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]