{"id":22029,"url":"https://patchwork.libcamera.org/api/patches/22029/?format=json","web_url":"https://patchwork.libcamera.org/patch/22029/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241120085753.1993436-8-stefan.klug@ideasonboard.com>","date":"2024-11-20T08:57:46","name":"[7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"940f866d9ddc51cee08e5f2864ccb909b3becadc","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/22029/mbox/","series":[{"id":4807,"url":"https://patchwork.libcamera.org/api/series/4807/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4807","date":"2024-11-20T08:57:39","name":"rkisp1: Fix aspect ratio and ScalerCrop","version":1,"mbox":"https://patchwork.libcamera.org/series/4807/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/22029/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/22029/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A394EC330D\n\tfor ;\n\tWed, 20 Nov 2024 08:58:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31DAC65F51;\n\tWed, 20 Nov 2024 09:58:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00AF565F30\n\tfor ;\n\tWed, 20 Nov 2024 09:58:17 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bbd:82cc:f3f3:e12e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0A43755A;\n\tWed, 20 Nov 2024 09:57:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jPMhIorM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732093079;\n\tbh=tZphfWIhGEQeLXpOwirq4VVHqyST/gTXN1DCGq09QZQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jPMhIorMjrMR3ZKgxC4L1dHPu4TG6srWU8FvNE4zAYhL/UoTcQNS8OTg4zy41nWGZ\n\tvh2z8a/7GRurdO+XPJPL1m7aqtJThNBDdV4aprJqG9PlPay2KzTfTJR3kIrz/x3ABL\n\tbIjm+MkJfxAaTwjns0f8oUg/BmAc+pBHXaMGhH50=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH 7/7] pipeline: rkisp1: Add ScalerMaximumCrop property","Date":"Wed, 20 Nov 2024 09:57:46 +0100","Message-ID":"<20241120085753.1993436-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>","References":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ScalerMaximumCrop property holds the biggest allowed ScalerCrop\nvalue. Add it to the rkisp1.\n\nSigned-off-by: Stefan Klug \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c2ce38b1c253..647b5754bd55 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -24,6 +24,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n #include \n@@ -870,7 +871,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t\t\t * coordinates.\n \t\t\t\t */\n \t\t\t\tdewarperSensorCrop_ = outputCrop.mappedBetween(inputCrop,\n-\t\t\t\t\t\t\t\t\t ipaConfig.sensorInfo.analogCrop);\n+\t\t\t\t\t\t\t\t\t sensorInfo.analogCrop);\n \t\t\t}\n \t\t} else if (hasSelfPath_) {\n \t\t\tret = selfPath_.configure(cfg, format);\n@@ -1247,6 +1248,7 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n \t\tcontrols[&controls::ScalerCrop] = ControlInfo(min,\n \t\t\t\t\t\t\t max,\n \t\t\t\t\t\t\t max);\n+\t\tdata->properties_.set(properties::ScalerCropMaximum, max);\n \t\tactiveCrop_ = max;\n \t}\n \n","prefixes":["7/7"]}