[{"id":32302,"web_url":"https://patchwork.libcamera.org/comment/32302/","msgid":"","date":"2024-11-20T10:56:02","subject":"Re: [PATCH 1/7] libcamera: rkisp1: Fix scope of dewarper stop() exit\n\taction","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Nov 20, 2024 at 09:57:40AM +0100, Stefan Klug wrote:\n> Move the definition of the dewarper stop() action into the scope were\n> the corresponding start() happens.\n> \n> Fixes: 12b553d691d4 (\"libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\")\n> Signed-off-by: Stefan Klug \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 6c6d711f91b3..5ffcfbce56be 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1043,8 +1043,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL\n> \t\t\t\tLOG(RkISP1, Error) << \"Failed to start dewarper\";\n> \t\t\t\treturn ret;\n> \t\t\t}\n> +\t\t\tactions += [&]() { dewarper_->stop(); };\n> \t\t}\n> -\t\tactions += [&]() { dewarper_->stop(); };\n> \t}\n> \n> \tif (data->mainPath_->isEnabled()) {\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A9C6C32F5\n\tfor ;\n\tWed, 20 Nov 2024 10:56:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8697F65F45;\n\tWed, 20 Nov 2024 11:56:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E52A0658B6\n\tfor ;\n\tWed, 20 Nov 2024 11:56:11 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:6f8:18b9:c92f:628d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D806055A;\n\tWed, 20 Nov 2024 11:55:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r10yUAKR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732100153;\n\tbh=ue1u16rpSxqs8QfXhxvegAz763V08fL7IuamswOW3E4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=r10yUAKRZIPo3rzv52GRjVj7wpk3+7MKomrvxWhnzJwNo3T7RQDuwGR5imNyUWUfp\n\tTZSouTuBLra8OWdoPwdSqdRufdHBaIRpLdCnHj5P8S6nGAQjgS9aJHH6SVVQmBOgYx\n\t9tHCbjeN5E2sMjYbsDZBqhInfMvh8vavEYETmMp0=","Date":"Wed, 20 Nov 2024 19:56:02 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/7] libcamera: rkisp1: Fix scope of dewarper stop() exit\n\taction","Message-ID":"","References":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>\n\t<20241120085753.1993436-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20241120085753.1993436-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32325,"web_url":"https://patchwork.libcamera.org/comment/32325/","msgid":"","date":"2024-11-21T08:55:04","subject":"Re: [PATCH 1/7] libcamera: rkisp1: Fix scope of dewarper stop() exit\n\taction","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Wed, Nov 20, 2024 at 09:57:40AM +0100, Stefan Klug wrote:\n> Move the definition of the dewarper stop() action into the scope were\n> the corresponding start() happens.\n>\n> Fixes: 12b553d691d4 (\"libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\")\n> Signed-off-by: Stefan Klug \n\nindeed\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 6c6d711f91b3..5ffcfbce56be 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1043,8 +1043,8 @@ int PipelineHandlerRkISP1::start(Camera *camera, [[maybe_unused]] const ControlL\n> \t\t\t\tLOG(RkISP1, Error) << \"Failed to start dewarper\";\n> \t\t\t\treturn ret;\n> \t\t\t}\n> +\t\t\tactions += [&]() { dewarper_->stop(); };\n> \t\t}\n> -\t\tactions += [&]() { dewarper_->stop(); };\n> \t}\n>\n> \tif (data->mainPath_->isEnabled()) {\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2FE99C32F9\n\tfor ;\n\tThu, 21 Nov 2024 08:55:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6619165FAC;\n\tThu, 21 Nov 2024 09:55:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA99165F9F\n\tfor ;\n\tThu, 21 Nov 2024 09:55:07 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F15EB219;\n\tThu, 21 Nov 2024 09:54:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YCUw9bfh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732179289;\n\tbh=sKX5o+Ux6x9BlEULEpMEBldWU7V5OqjM5oZqYgtnKwc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=YCUw9bfhzB5GTLMY0ZUnfzmbmjkxEQo/SFxpmbLweJ6xslOk0Zv2L4aka546dAX8D\n\tKY2mTv+z7Z6zFfdtZcjjB0qDTtpnv4VMrmMOKxyoPhEkPMQQlDjypgzdLubvtHB4SX\n\tSlgw684WwJtSdjtSQnjwHSifTdmcFZkoDpkVeMSA=","Date":"Thu, 21 Nov 2024 09:55:04 +0100","From":"Jacopo Mondi ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/7] libcamera: rkisp1: Fix scope of dewarper stop() exit\n\taction","Message-ID":"","References":"<20241120085753.1993436-1-stefan.klug@ideasonboard.com>\n\t<20241120085753.1993436-2-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241120085753.1993436-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]