[{"id":32279,"web_url":"https://patchwork.libcamera.org/comment/32279/","msgid":"<20241119114320.GO31681@pendragon.ideasonboard.com>","date":"2024-11-19T11:43:20","subject":"Re: [PATCH v2 8/9] rkisp1: Use Matrix class from libcamera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Tue, Nov 19, 2024 at 11:37:35AM +0100, Stefan Klug wrote:\n> Use the Matrix class from libcamera/internal in the rkisp IPA so that\n> the libipa one can be dropped later.\n> \n> Signed-off-by: Stefan Klug \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/ccm.h | 3 ++-\n> src/ipa/rkisp1/ipa_context.h | 2 +-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.h b/src/ipa/rkisp1/algorithms/ccm.h\n> index 46a1416e6be5..a5d9a9a45e5d 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.h\n> +++ b/src/ipa/rkisp1/algorithms/ccm.h\n> @@ -9,8 +9,9 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/matrix.h\"\n> +\n> #include \"libipa/interpolator.h\"\n> -#include \"libipa/matrix.h\"\n> \n> #include \"algorithm.h\"\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 7b93a9e9461d..12b37d1c73b0 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -21,10 +21,10 @@\n> #include \n> \n> #include \"libcamera/internal/debug_controls.h\"\n> +#include \"libcamera/internal/matrix.h\"\n> \n> #include \n> #include \n> -#include \n> \n> namespace libcamera {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65DEDC326B\n\tfor ;\n\tTue, 19 Nov 2024 11:43:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 145A465F11;\n\tTue, 19 Nov 2024 12:43:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3D3165F03\n\tfor ;\n\tTue, 19 Nov 2024 12:43:28 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86967641;\n\tTue, 19 Nov 2024 12:43:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tsrXQobR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732016591;\n\tbh=FXjXheHBZNcwBt4AX1/n1jIQbcY8DEwqpldqGtY88hY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tsrXQobRgdLhHviEdG9L6hAjb4WRZESjbz3rZPEEX1QXNXKBS7klMM7tGjsPt4WNT\n\t9MgwwMtlS0y50f05VhbuOFj9LK3vbOE43INmowinVCVAMBQuZbJI50RO8Jc0sGE/Vf\n\tyFRmhrz8I9t8jUTIQzGZuVcWINes4icwyP1RtlLo=","Date":"Tue, 19 Nov 2024 13:43:20 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 8/9] rkisp1: Use Matrix class from libcamera","Message-ID":"<20241119114320.GO31681@pendragon.ideasonboard.com>","References":"<20241119103740.1919807-1-stefan.klug@ideasonboard.com>\n\t<20241119103740.1919807-9-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241119103740.1919807-9-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]