[{"id":32278,"web_url":"https://patchwork.libcamera.org/comment/32278/","msgid":"<20241119114249.GN31681@pendragon.ideasonboard.com>","date":"2024-11-19T11:42:49","subject":"Re: [PATCH v2 7/9] libipa: Use Matrix class from libcamera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Tue, Nov 19, 2024 at 11:37:34AM +0100, Stefan Klug wrote:\n> Use the Matrix class from libcamera/internal in libipa so that the one\n> from libipa can be dropped later.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/libipa/vector.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\n> index 8612a06a2ab2..dcafcb1c0e96 100644\n> --- a/src/ipa/libipa/vector.h\n> +++ b/src/ipa/libipa/vector.h\n> @@ -14,9 +14,9 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/yaml_parser.h\"\n> +#include \"libcamera/internal/matrix.h\"\n> \n\nYou can drop this blank line.\n\nReviewed-by: Laurent Pinchart \n\n> -#include \"matrix.h\"\n> +#include \"libcamera/internal/yaml_parser.h\"\n> \n> namespace libcamera {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80798C326B\n\tfor ;\n\tTue, 19 Nov 2024 11:43:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36C4D65F0B;\n\tTue, 19 Nov 2024 12:43:00 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8489965F03\n\tfor ;\n\tTue, 19 Nov 2024 12:42:58 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12364641;\n\tTue, 19 Nov 2024 12:42:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hbHDh7/s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732016561;\n\tbh=9Z7VMLVz1KoWWpoIjOMFLv2s6dZoyRVmNRP99Y/drkk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hbHDh7/s0JYaLMQq+Qt34hLwbN0SClVKuuLmci93Ub51YK9zniMErg4J/l+wMWETG\n\t7ONh/2fjyhaoXIiN1JWEuBraeXw9mePV6xXtTcDrPDonresotZKHTuL7HTJaCL0cxn\n\twW2rWEiWoL9ALbvR6cpYZNFcCpxy9MuaYzrU8Dnc=","Date":"Tue, 19 Nov 2024 13:42:49 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 7/9] libipa: Use Matrix class from libcamera","Message-ID":"<20241119114249.GN31681@pendragon.ideasonboard.com>","References":"<20241119103740.1919807-1-stefan.klug@ideasonboard.com>\n\t<20241119103740.1919807-8-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241119103740.1919807-8-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]