[{"id":32282,"web_url":"https://patchwork.libcamera.org/comment/32282/","msgid":"<2e7boeqobbi366or4hfhha74exr4jvfrgelkzzdthjpoa3y2om@kdoulqr5glvf>","date":"2024-11-19T12:57:44","subject":"Re: [PATCH v2 2/4] ipa: rpi: cam_helper: Add Sony IMX327","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Geoffrey\n\nOn Mon, Nov 18, 2024 at 11:53:08PM +0100, Geoffrey Van Landeghem wrote:\n> Signed-off-by: Geoffrey Van Landeghem \n\nAs said, even if trivial, we need a commit message for each patch.\n\nThat apart, this looks good to me\nReviewed-by: Jacopo Mondi \n\nI'll let rpi ack the tuning files (David already did I think)\n\n> ---\n> src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> index 0cc24a6d..3b87751e 100644\n> --- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> +++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n> @@ -73,4 +73,5 @@ static CamHelper *create()\n> }\n>\n> static RegisterCamHelper reg(\"imx290\", &create);\n> +static RegisterCamHelper reg327(\"imx327\", &create);\n> static RegisterCamHelper reg462(\"imx462\", &create);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6C54C326B\n\tfor ;\n\tTue, 19 Nov 2024 12:57:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98E6965F14;\n\tTue, 19 Nov 2024 13:57:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FEDD658A2\n\tfor ;\n\tTue, 19 Nov 2024 13:57:48 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 296723A2;\n\tTue, 19 Nov 2024 13:57:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"K4BKFiBa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1732021051;\n\tbh=las7Mo7FsfaA+REtAwaLDAtTSiYGGwPRy6PKEy+i2rg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=K4BKFiBanPH21G3FmHIRNAJtVGHIMMzgwGYtl6YvdZrI2M32fRakXbrq6poJHHaxe\n\teWJ7c3g0PrHw9klT3poROEWBcSCtxJNXWfI4aPR2bHqkV37pNnYgh0rcis1rtZ1XRv\n\tZ208G+aN64CPhUigyNrSWk8aEw3NLekwNl7eomvA=","Date":"Tue, 19 Nov 2024 13:57:44 +0100","From":"Jacopo Mondi ","To":"Geoffrey Van Landeghem ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 2/4] ipa: rpi: cam_helper: Add Sony IMX327","Message-ID":"<2e7boeqobbi366or4hfhha74exr4jvfrgelkzzdthjpoa3y2om@kdoulqr5glvf>","References":"<20241118225310.446706-1-geoffrey.vl@gmail.com>\n\t<20241118225310.446706-3-geoffrey.vl@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241118225310.446706-3-geoffrey.vl@gmail.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]