{"id":21970,"url":"https://patchwork.libcamera.org/api/patches/21970/?format=json","web_url":"https://patchwork.libcamera.org/patch/21970/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118221618.13953-11-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T22:16:11","name":"[v3,10/17] ipa: libipa: vector: Add sum() function","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"28377602afbac91cdb477c22271af0b5e0f376a5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21970/mbox/","series":[{"id":4798,"url":"https://patchwork.libcamera.org/api/series/4798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4798","date":"2024-11-18T22:16:01","name":"Improve linear algebra helpers in libipa","version":3,"mbox":"https://patchwork.libcamera.org/series/4798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21970/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21970/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 288C3C32F0\n\tfor ;\n\tMon, 18 Nov 2024 22:16:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ACFD65ED9;\n\tMon, 18 Nov 2024 23:16:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC130658FE\n\tfor ;\n\tMon, 18 Nov 2024 23:16:41 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0D056DE\n\tfor ;\n\tMon, 18 Nov 2024 23:16:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XjZcu67r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968185;\n\tbh=CfQrts0FGzibO3+YYYZdwluX8ReZ/57VWl/f+nCSqpM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=XjZcu67rNEoqSddSHkX2BUvHfMQKRs8wwesJPNoMLljbsSIRMW9B31rvoBKjGgc8P\n\tcW3BbQNtbL4HCdATCvM1jVB5RTMnL89NAYopJTHjki+SeORg9GEp79STtSC00ZhU9G\n\tct8KHTtwJmG+LRYgdZZI5VeniulvslWdY2DdmJKQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 10/17] ipa: libipa: vector: Add sum() function","Date":"Tue, 19 Nov 2024 00:16:11 +0200","Message-ID":"<20241118221618.13953-11-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","References":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a function to calculate the sum of a vector. It will be useful for\nalgorithms.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Milan Zamazal \n---\nChanges since v1:\n\n- Drop Vector::normalize()\n---\n src/ipa/libipa/vector.cpp | 12 ++++++++++++\n src/ipa/libipa/vector.h | 7 +++++++\n 2 files changed, 19 insertions(+)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 56c494a7e4da..a1ad47cd046b 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -302,6 +302,18 @@ namespace ipa {\n * \\return The length of the vector\n */\n \n+/**\n+ * \\fn Vector::sum() const\n+ * \\brief Calculate the sum of all the vector elements\n+ * \\tparam R The type of the sum\n+ *\n+ * The type R of the sum defaults to the type T of the elements, but can be set\n+ * explicitly to use a different type in case the type T would risk\n+ * overflowing.\n+ *\n+ * \\return The sum of all the vector elements\n+ */\n+\n /**\n * \\fn Vector operator*(const Matrix &m, const Vector &v)\n * \\brief Multiply a matrix by a vector\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 3fed9570bf62..564292743829 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -10,6 +10,7 @@\n #include \n #include \n #include \n+#include \n #include \n #include \n \n@@ -251,6 +252,12 @@ public:\n \t\treturn std::sqrt(length2());\n \t}\n \n+\ttemplate\n+\tconstexpr R sum() const\n+\t{\n+\t\treturn std::accumulate(data_.begin(), data_.end(), R{});\n+\t}\n+\n private:\n \tstatic constexpr Vector apply(const Vector &lhs, const Vector &rhs, std::function func)\n \t{\n","prefixes":["v3","10/17"]}