{"id":21967,"url":"https://patchwork.libcamera.org/api/patches/21967/?format=json","web_url":"https://patchwork.libcamera.org/patch/21967/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20241118221618.13953-8-laurent.pinchart@ideasonboard.com>","date":"2024-11-18T22:16:08","name":"[v3,07/17] ipa: libipa: vector: Add missing binary arithemtic operators","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f4748c6f7b16052be8483dd58690ffd320f29551","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21967/mbox/","series":[{"id":4798,"url":"https://patchwork.libcamera.org/api/series/4798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4798","date":"2024-11-18T22:16:01","name":"Improve linear algebra helpers in libipa","version":3,"mbox":"https://patchwork.libcamera.org/series/4798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21967/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21967/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8DBAC32EA\n\tfor ;\n\tMon, 18 Nov 2024 22:16:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E06DC65904;\n\tMon, 18 Nov 2024 23:16:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3043658FB\n\tfor ;\n\tMon, 18 Nov 2024 23:16:37 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD8258DB\n\tfor ;\n\tMon, 18 Nov 2024 23:16:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ilD6vlyu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731968181;\n\tbh=RGa3DPbSiu66UA1a5vLH2UJf2jGLe7CJXsiMRW1gvjE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ilD6vlyudu9O2CyjqXtf2H3M/118m62Y9wgZ8kczt7NCuaoSw4ZHdTOnIA8zizALB\n\tZhctiE6fRxFEExf2+7ZEL7LplfWknc2S1zfKtayGIGhLven0YaEWZBn/+vMm3I9WP5\n\txcWx0OqCaE3FK8FZIcW4KmbvP5Qg/XWdj0zPQBiI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v3 07/17] ipa: libipa: vector: Add missing binary arithemtic\n\toperators","Date":"Tue, 19 Nov 2024 00:16:08 +0200","Message-ID":"<20241118221618.13953-8-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","References":"<20241118221618.13953-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Vector class defines multiple element-wise arithmetic operators\nbetween vectors or between a vector and a scalar. A few variants are\nmissing. Add them.\n\nSigned-off-by: Laurent Pinchart \n---\nChanges since v2:\n\n- Use std::plus, std::minus, std::multiplies and std::divides\n---\n src/ipa/libipa/vector.cpp | 54 +++++++++++++++++++++++++++++----------\n src/ipa/libipa/vector.h | 38 ++++++++++++++++++++-------\n 2 files changed, 70 insertions(+), 22 deletions(-)","diff":"diff --git a/src/ipa/libipa/vector.cpp b/src/ipa/libipa/vector.cpp\nindex 143ee9262f05..d8f7ce951d60 100644\n--- a/src/ipa/libipa/vector.cpp\n+++ b/src/ipa/libipa/vector.cpp\n@@ -77,32 +77,60 @@ namespace ipa {\n * \\return The negated vector\n */\n \n+/**\n+ * \\fn Vector::operator+(Vector const &other) const\n+ * \\brief Calculate the sum of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise sum of this vector and \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::operator+(T scalar) const\n+ * \\brief Calculate the sum of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise sum of this vector and \\a other\n+ */\n+\n /**\n * \\fn Vector::operator-(Vector const &other) const\n- * \\brief Subtract one vector from another\n+ * \\brief Calculate the difference of this vector and \\a other element-wise\n * \\param[in] other The other vector\n- * \\return The difference of \\a other from this vector\n+ * \\return The element-wise subtraction of \\a other from this vector\n */\n \n /**\n- * \\fn Vector::operator+()\n- * \\brief Add two vectors together\n+ * \\fn Vector::operator-(T scalar) const\n+ * \\brief Calculate the difference of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise subtraction of \\a scalar from this vector\n+ */\n+\n+/**\n+ * \\fn Vector::operator*(const Vector &other) const\n+ * \\brief Calculate the product of this vector and \\a other element-wise\n * \\param[in] other The other vector\n- * \\return The sum of the two vectors\n+ * \\return The element-wise product of this vector and \\a other\n */\n \n /**\n- * \\fn Vector::operator*(T factor) const\n- * \\brief Multiply the vector by a scalar\n- * \\param[in] factor The factor\n- * \\return The vector multiplied by \\a factor\n+ * \\fn Vector::operator*(T scalar) const\n+ * \\brief Calculate the product of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise product of this vector and \\a scalar\n */\n \n /**\n- * \\fn Vector::operator/()\n- * \\brief Divide the vector by a scalar\n- * \\param[in] factor The factor\n- * \\return The vector divided by \\a factor\n+ * \\fn Vector::operator/(const Vector &other) const\n+ * \\brief Calculate the quotient of this vector and \\a other element-wise\n+ * \\param[in] other The other vector\n+ * \\return The element-wise division of this vector by \\a other\n+ */\n+\n+/**\n+ * \\fn Vector::operator/(T scalar) const\n+ * \\brief Calculate the quotient of this vector and \\a scalar element-wise\n+ * \\param[in] scalar The scalar\n+ * \\return The element-wise division of this vector by \\a scalar\n */\n \n /**\ndiff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\nindex 76fd2934b870..88f2a03fe579 100644\n--- a/src/ipa/libipa/vector.h\n+++ b/src/ipa/libipa/vector.h\n@@ -80,24 +80,44 @@ public:\n \t\treturn ret;\n \t}\n \n-\tconstexpr Vector operator-(const Vector &other) const\n-\t{\n-\t\treturn apply(*this, other, std::minus<>{});\n-\t}\n-\n \tconstexpr Vector operator+(const Vector &other) const\n \t{\n \t\treturn apply(*this, other, std::plus<>{});\n \t}\n \n-\tconstexpr Vector operator*(T factor) const\n+\tconstexpr Vector operator+(T scalar) const\n \t{\n-\t\treturn apply(*this, factor, std::multiplies<>{});\n+\t\treturn apply(*this, scalar, std::plus<>{});\n \t}\n \n-\tconstexpr Vector operator/(T factor) const\n+\tconstexpr Vector operator-(const Vector &other) const\n \t{\n-\t\treturn apply(*this, factor, std::divides<>{});\n+\t\treturn apply(*this, other, std::minus<>{});\n+\t}\n+\n+\tconstexpr Vector operator-(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, std::minus<>{});\n+\t}\n+\n+\tconstexpr Vector operator*(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, std::multiplies<>{});\n+\t}\n+\n+\tconstexpr Vector operator*(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, std::multiplies<>{});\n+\t}\n+\n+\tconstexpr Vector operator/(const Vector &other) const\n+\t{\n+\t\treturn apply(*this, other, std::divides<>{});\n+\t}\n+\n+\tconstexpr Vector operator/(T scalar) const\n+\t{\n+\t\treturn apply(*this, scalar, std::divides<>{});\n \t}\n \n \tconstexpr T dot(const Vector &other) const\n","prefixes":["v3","07/17"]}