[{"id":32242,"web_url":"https://patchwork.libcamera.org/comment/32242/","msgid":"<20241118161247.GT31681@pendragon.ideasonboard.com>","date":"2024-11-18T16:12:47","subject":"Re: [PATCH 3/4] libcamera: matrix: Use Span instead of vector for\n\tconstruction","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Mon, Nov 18, 2024 at 04:05:06PM +0100, Stefan Klug wrote:\n> Use a Span for construction to be more flexible. Additionally add an\n> assert for the correct size of the span.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> include/libcamera/internal/matrix.h | 3 ++-\n> src/libcamera/matrix.cpp | 10 ++++++++++\n> 2 files changed, 12 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/libcamera/internal/matrix.h b/include/libcamera/internal/matrix.h\n> index b82d33f98658..28ea68a55af9 100644\n> --- a/include/libcamera/internal/matrix.h\n> +++ b/include/libcamera/internal/matrix.h\n> @@ -39,8 +39,9 @@ public:\n> \t\tstd::copy(data.begin(), data.end(), data_.begin());\n> \t}\n> \n> -\tMatrix(const std::vector &data)\n> +\tMatrix(const Span &data)\n\nA span is certainly better than a vector.\n\n> \t{\n> +\t\tASSERT(data.size() == Rows * Cols);\n\nIt would be nice to drop this constructor in favour of an std::array\nconstructor, as indicated in my review of 2/4. I haven't checked if that\nwould be possible.\n\n> \t\tstd::copy(data.begin(), data.end(), data_.begin());\n> \t}\n> \n> diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp\n> index c3ed54895b22..bb9fd3003996 100644\n> --- a/src/libcamera/matrix.cpp\n> +++ b/src/libcamera/matrix.cpp\n> @@ -31,6 +31,16 @@ LOG_DEFINE_CATEGORY(Matrix)\n> * \\brief Construct a zero matrix\n> */\n> \n> +/**\n> + * \\fn Matrix::Matrix(std::initializer_list data)\n> + * \\brief Construct a matrix from supplied data\n> + * \\param[in] data Data from which to construct a matrix\n> + *\n> + * \\a data is a one-dimensional vector and will be turned into a matrix in\n> + * row-major order. The size of \\a data must be equal to the product of the\n> + * number of rows and columns of the matrix (Rows x Cols).\n> + */\n\nThis is unrelated to the commit message.\n\n> +\n> /**\n> * \\fn Matrix::Matrix(const Span &data)\n\nAnd this was added in 2/4. I think something went wrong at some point\nduring a split & rebase.\n\n> * \\brief Construct a matrix from supplied data","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CDE1C32EA\n\tfor ;\n\tMon, 18 Nov 2024 16:12:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4047F658EB;\n\tMon, 18 Nov 2024 17:12:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9D2A658DC\n\tfor ;\n\tMon, 18 Nov 2024 17:12:56 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0D84A57;\n\tMon, 18 Nov 2024 17:12:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GK3hfLl1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731946360;\n\tbh=sb0LLO6LvmS4KyMOUxQMbNHjfEX3cKR5iVf8SYtjwWE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GK3hfLl1J8ruitmQtcrDqJpc41oLtALBe1y1fN8aOmccHgMUXbQIUNI9PZw26ceci\n\tdUpPg53Tqxx1AxrZ+Yq/7wD7SzarclHpiw4BARuprKmo0q8d4EK2QWZnsffNKPMcWi\n\trtW9ks0cp9YJcwnxQq7avTNyXWu5Godlv77qVwzs=","Date":"Mon, 18 Nov 2024 18:12:47 +0200","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/4] libcamera: matrix: Use Span instead of vector for\n\tconstruction","Message-ID":"<20241118161247.GT31681@pendragon.ideasonboard.com>","References":"<20241118150528.1856797-1-stefan.klug@ideasonboard.com>\n\t<20241118150528.1856797-4-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20241118150528.1856797-4-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]