[{"id":32223,"web_url":"https://patchwork.libcamera.org/comment/32223/","msgid":"<87r078hct4.fsf@redhat.com>","date":"2024-11-18T13:49:27","subject":"Re: [RFC PATCH v2 11/12] ipa: rkisp1: awb: Use RGB class to store\n\tcolour gains","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> Replace the individual colour gains with instances of the RGB\n> class. This simplifies the code that performs calculations on the gains.\n\nNice, thank you.\n\nReviewed-by: Milan Zamazal \n\n(Some very minor comments below.)\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 102 ++++++++++++------------------\n> src/ipa/rkisp1/algorithms/awb.h | 2 +-\n> src/ipa/rkisp1/ipa_context.cpp | 31 +--------\n> src/ipa/rkisp1/ipa_context.h | 20 ++----\n> 4 files changed, 48 insertions(+), 107 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b3c00bef9b7e..1c572055acdd 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -45,12 +45,8 @@ Awb::Awb()\n> int Awb::configure(IPAContext &context,\n> \t\t const IPACameraSensorInfo &configInfo)\n> {\n> -\tcontext.activeState.awb.gains.manual.red = 1.0;\n> -\tcontext.activeState.awb.gains.manual.blue = 1.0;\n> -\tcontext.activeState.awb.gains.manual.green = 1.0;\n> -\tcontext.activeState.awb.gains.automatic.red = 1.0;\n> -\tcontext.activeState.awb.gains.automatic.blue = 1.0;\n> -\tcontext.activeState.awb.gains.automatic.green = 1.0;\n> +\tcontext.activeState.awb.gains.manual = RGB({ 1.0, 1.0, 1.0 });\n> +\tcontext.activeState.awb.gains.automatic = RGB({ 1.0, 1.0, 1.0 });\n> \tcontext.activeState.awb.autoEnabled = true;\n> \n> \t/*\n> @@ -87,21 +83,17 @@ void Awb::queueRequest(IPAContext &context,\n> \n> \tconst auto &colourGains = controls.get(controls::ColourGains);\n> \tif (colourGains && !awb.autoEnabled) {\n> -\t\tawb.gains.manual.red = (*colourGains)[0];\n> -\t\tawb.gains.manual.blue = (*colourGains)[1];\n> +\t\tawb.gains.manual.r() = (*colourGains)[0];\n> +\t\tawb.gains.manual.b() = (*colourGains)[1];\n> \n> \t\tLOG(RkISP1Awb, Debug)\n> -\t\t\t<< \"Set colour gains to red: \" << awb.gains.manual.red\n> -\t\t\t<< \", blue: \" << awb.gains.manual.blue;\n> +\t\t\t<< \"Set colour gains to \" << awb.gains.manual;\n> \t}\n> \n> \tframeContext.awb.autoEnabled = awb.autoEnabled;\n> \n> -\tif (!awb.autoEnabled) {\n> -\t\tframeContext.awb.gains.red = awb.gains.manual.red;\n> -\t\tframeContext.awb.gains.green = 1.0;\n> -\t\tframeContext.awb.gains.blue = awb.gains.manual.blue;\n> -\t}\n> +\tif (!awb.autoEnabled)\n> +\t\tframeContext.awb.gains = awb.gains.manual;\n> }\n> \n> /**\n> @@ -114,19 +106,16 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t * This is the latest time we can read the active state. This is the\n> \t * most up-to-date automatic values we can read.\n> \t */\n> -\tif (frameContext.awb.autoEnabled) {\n> -\t\tframeContext.awb.gains.red = context.activeState.awb.gains.automatic.red;\n> -\t\tframeContext.awb.gains.green = context.activeState.awb.gains.automatic.green;\n> -\t\tframeContext.awb.gains.blue = context.activeState.awb.gains.automatic.blue;\n> -\t}\n> +\tif (frameContext.awb.autoEnabled)\n> +\t\tframeContext.awb.gains = context.activeState.awb.gains.automatic;\n> \n> \tauto gainConfig = params->block();\n> \tgainConfig.setEnabled(true);\n> \n> -\tgainConfig->gain_green_b = std::clamp(256 * frameContext.awb.gains.green, 0, 0x3ff);\n> -\tgainConfig->gain_blue = std::clamp(256 * frameContext.awb.gains.blue, 0, 0x3ff);\n> -\tgainConfig->gain_red = std::clamp(256 * frameContext.awb.gains.red, 0, 0x3ff);\n> -\tgainConfig->gain_green_r = std::clamp(256 * frameContext.awb.gains.green, 0, 0x3ff);\n> +\tgainConfig->gain_green_b = std::clamp(256 * frameContext.awb.gains.g(), 0, 0x3ff);\n> +\tgainConfig->gain_blue = std::clamp(256 * frameContext.awb.gains.b(), 0, 0x3ff);\n> +\tgainConfig->gain_red = std::clamp(256 * frameContext.awb.gains.r(), 0, 0x3ff);\n> +\tgainConfig->gain_green_r = std::clamp(256 * frameContext.awb.gains.g(), 0, 0x3ff);\n> \n> \t/* If we have already set the AWB measurement parameters, return. */\n> \tif (frame > 0)\n> @@ -178,12 +167,12 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> \t}\n> }\n> \n> -uint32_t Awb::estimateCCT(double red, double green, double blue)\n> +uint32_t Awb::estimateCCT(const RGB &rgb)\n\nNote this is in conflict with a recently posted patch moving this to\nthe common IPA.\n\n> {\n> \t/* Convert the RGB values to CIE tristimulus values (XYZ) */\n> -\tdouble X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n> -\tdouble Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n> -\tdouble Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n> +\tdouble X = -0.14282 * rgb.r() + 1.54924 * rgb.g() - 0.95641 * rgb.b();\n> +\tdouble Y = -0.32466 * rgb.r() + 1.57837 * rgb.g() - 0.73191 * rgb.b();\n> +\tdouble Z = -0.68202 * rgb.r() + 0.77073 * rgb.g() + 0.56332 * rgb.b();\n\nDoes this demonstrate that operator* would be more handy as a dot product?\n\n> \t/* Calculate the normalized chromaticity values */\n> \tdouble x = X / (X + Y + Z);\n> @@ -206,14 +195,12 @@ void Awb::process(IPAContext &context,\n> \tconst rkisp1_cif_isp_stat *params = &stats->params;\n> \tconst rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n> \tIPAActiveState &activeState = context.activeState;\n> -\tdouble greenMean;\n> -\tdouble redMean;\n> -\tdouble blueMean;\n> +\tRGB rgbMeans;\n> \n> \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> \tmetadata.set(controls::ColourGains, {\n> -\t\t\tstatic_cast(frameContext.awb.gains.red),\n> -\t\t\tstatic_cast(frameContext.awb.gains.blue)\n> +\t\t\tstatic_cast(frameContext.awb.gains.r()),\n> +\t\t\tstatic_cast(frameContext.awb.gains.b())\n> \t\t});\n> \tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> \n> @@ -223,9 +210,9 @@ void Awb::process(IPAContext &context,\n> \t}\n> \n> \tif (rgbMode_) {\n> -\t\tgreenMean = awb->awb_mean[0].mean_y_or_g;\n> -\t\tredMean = awb->awb_mean[0].mean_cr_or_r;\n> -\t\tblueMean = awb->awb_mean[0].mean_cb_or_b;\n> +\t\trgbMeans.r() = awb->awb_mean[0].mean_cr_or_r;\n> +\t\trgbMeans.g() = awb->awb_mean[0].mean_y_or_g;\n> +\t\trgbMeans.b() = awb->awb_mean[0].mean_cb_or_b;\n> \t} else {\n> \t\t/* Get the YCbCr mean values */\n> \t\tdouble yMean = awb->awb_mean[0].mean_y_or_g;\n> @@ -247,9 +234,9 @@ void Awb::process(IPAContext &context,\n> \t\tyMean -= 16;\n> \t\tcbMean -= 128;\n> \t\tcrMean -= 128;\n> -\t\tredMean = 1.1636 * yMean - 0.0623 * cbMean + 1.6008 * crMean;\n> -\t\tgreenMean = 1.1636 * yMean - 0.4045 * cbMean - 0.7949 * crMean;\n> -\t\tblueMean = 1.1636 * yMean + 1.9912 * cbMean - 0.0250 * crMean;\n> +\t\trgbMeans.r() = 1.1636 * yMean - 0.0623 * cbMean + 1.6008 * crMean;\n> +\t\trgbMeans.g() = 1.1636 * yMean - 0.4045 * cbMean - 0.7949 * crMean;\n> +\t\trgbMeans.b() = 1.1636 * yMean + 1.9912 * cbMean - 0.0250 * crMean;\n> \n> \t\t/*\n> \t\t * Due to hardware rounding errors in the YCbCr means, the\n> @@ -257,9 +244,7 @@ void Awb::process(IPAContext &context,\n> \t\t * negative gains, messing up calculation. Prevent this by\n> \t\t * clamping the means to positive values.\n> \t\t */\n> -\t\tredMean = std::max(redMean, 0.0);\n> -\t\tgreenMean = std::max(greenMean, 0.0);\n> -\t\tblueMean = std::max(blueMean, 0.0);\n> +\t\trgbMeans = rgbMeans.max(0.0);\n> \t}\n> \n> \t/*\n> @@ -267,19 +252,17 @@ void Awb::process(IPAContext &context,\n> \t * divide by the gains that were used to get the raw means from the\n> \t * sensor.\n> \t */\n> -\tredMean /= frameContext.awb.gains.red;\n> -\tgreenMean /= frameContext.awb.gains.green;\n> -\tblueMean /= frameContext.awb.gains.blue;\n> +\trgbMeans /= frameContext.awb.gains;\n> \n> \t/*\n> \t * If the means are too small we don't have enough information to\n> \t * meaningfully calculate gains. Freeze the algorithm in that case.\n> \t */\n> -\tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n> -\t blueMean < kMeanMinThreshold)\n> +\tif (rgbMeans.r() < kMeanMinThreshold && rgbMeans.g() < kMeanMinThreshold &&\n> +\t rgbMeans.b() < kMeanMinThreshold)\n\nWould it be worth to define also operator< ?\n\n> \t\treturn;\n> \n> -\tactiveState.awb.temperatureK = estimateCCT(redMean, greenMean, blueMean);\n> +\tactiveState.awb.temperatureK = estimateCCT(rgbMeans);\n> \n> \t/* Metadata shall contain the up to date measurement */\n> \tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> @@ -289,8 +272,11 @@ void Awb::process(IPAContext &context,\n> \t * gain is hardcoded to 1.0. Avoid divisions by zero by clamping the\n> \t * divisor to a minimum value of 1.0.\n> \t */\n> -\tdouble redGain = greenMean / std::max(redMean, 1.0);\n> -\tdouble blueGain = greenMean / std::max(blueMean, 1.0);\n> +\tRGB gains({\n> +\t\trgbMeans.g() / std::max(rgbMeans.r(), 1.0),\n> +\t\t1.0,\n> +\t\trgbMeans.g() / std::max(rgbMeans.b(), 1.0)\n> +\t});\n> \n> \t/*\n> \t * Clamp the gain values to the hardware, which expresses gains as Q2.8\n> @@ -298,24 +284,18 @@ void Awb::process(IPAContext &context,\n> \t * divisions by zero when computing the raw means in subsequent\n> \t * iterations.\n> \t */\n> -\tredGain = std::clamp(redGain, 1.0 / 256, 1023.0 / 256);\n> -\tblueGain = std::clamp(blueGain, 1.0 / 256, 1023.0 / 256);\n> +\tgains = gains.max(1.0 / 256).min(1023.0 / 256);\n> \n> \t/* Filter the values to avoid oscillations. */\n> \tdouble speed = 0.2;\n> -\tredGain = speed * redGain + (1 - speed) * activeState.awb.gains.automatic.red;\n> -\tblueGain = speed * blueGain + (1 - speed) * activeState.awb.gains.automatic.blue;\n> +\tgains = gains * speed + activeState.awb.gains.automatic * (1 - speed);\n> \n> -\tactiveState.awb.gains.automatic.red = redGain;\n> -\tactiveState.awb.gains.automatic.blue = blueGain;\n> -\tactiveState.awb.gains.automatic.green = 1.0;\n> +\tactiveState.awb.gains.automatic = gains;\n> \n> \tLOG(RkISP1Awb, Debug)\n> \t\t<< std::showpoint\n> -\t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> -\t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> -\t\t<< activeState.awb.gains.automatic.green << \", \"\n> -\t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n> +\t\t<< \"Means \" << rgbMeans << \", gains \"\n> +\t\t<< activeState.awb.gains.automatic << \", temp \"\n> \t\t<< activeState.awb.temperatureK << \"K\";\n> }\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> index b3b2c0bbb9ae..058c0fc53490 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.h\n> +++ b/src/ipa/rkisp1/algorithms/awb.h\n> @@ -32,7 +32,7 @@ public:\n> \t\t ControlList &metadata) override;\n> \n> private:\n> -\tuint32_t estimateCCT(double red, double green, double blue);\n> +\tuint32_t estimateCCT(const RGB &rgb);\n> \n> \tbool rgbMode_;\n> };\n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index 14d0c02a2b32..8f545cd76d52 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -188,30 +188,12 @@ namespace libcamera::ipa::rkisp1 {\n> * \\struct IPAActiveState::awb.gains\n> * \\brief White balance gains\n> *\n> - * \\struct IPAActiveState::awb.gains.manual\n> + * \\var IPAActiveState::awb.gains.manual\n> * \\brief Manual white balance gains (set through requests)\n> *\n> - * \\var IPAActiveState::awb.gains.manual.red\n> - * \\brief Manual white balance gain for R channel\n> - *\n> - * \\var IPAActiveState::awb.gains.manual.green\n> - * \\brief Manual white balance gain for G channel\n> - *\n> - * \\var IPAActiveState::awb.gains.manual.blue\n> - * \\brief Manual white balance gain for B channel\n> - *\n> - * \\struct IPAActiveState::awb.gains.automatic\n> + * \\var IPAActiveState::awb.gains.automatic\n> * \\brief Automatic white balance gains (computed by the algorithm)\n> *\n> - * \\var IPAActiveState::awb.gains.automatic.red\n> - * \\brief Automatic white balance gain for R channel\n> - *\n> - * \\var IPAActiveState::awb.gains.automatic.green\n> - * \\brief Automatic white balance gain for G channel\n> - *\n> - * \\var IPAActiveState::awb.gains.automatic.blue\n> - * \\brief Automatic white balance gain for B channel\n> - *\n> * \\var IPAActiveState::awb.temperatureK\n> * \\brief Estimated color temperature\n> *\n> @@ -333,15 +315,6 @@ namespace libcamera::ipa::rkisp1 {\n> * \\struct IPAFrameContext::awb.gains\n> * \\brief White balance gains\n> *\n> - * \\var IPAFrameContext::awb.gains.red\n> - * \\brief White balance gain for R channel\n> - *\n> - * \\var IPAFrameContext::awb.gains.green\n> - * \\brief White balance gain for G channel\n> - *\n> - * \\var IPAFrameContext::awb.gains.blue\n> - * \\brief White balance gain for B channel\n> - *\n> * \\var IPAFrameContext::awb.temperatureK\n> * \\brief Estimated color temperature\n> *\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 7b93a9e9461d..b4dec0c3288d 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -25,6 +25,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> namespace libcamera {\n> \n> @@ -87,16 +88,8 @@ struct IPAActiveState {\n> \n> \tstruct {\n> \t\tstruct {\n> -\t\t\tstruct {\n> -\t\t\t\tdouble red;\n> -\t\t\t\tdouble green;\n> -\t\t\t\tdouble blue;\n> -\t\t\t} manual;\n> -\t\t\tstruct {\n> -\t\t\t\tdouble red;\n> -\t\t\t\tdouble green;\n> -\t\t\t\tdouble blue;\n> -\t\t\t} automatic;\n> +\t\t\tRGB manual;\n> +\t\t\tRGB automatic;\n> \t\t} gains;\n> \n> \t\tunsigned int temperatureK;\n> @@ -140,12 +133,7 @@ struct IPAFrameContext : public FrameContext {\n> \t} agc;\n> \n> \tstruct {\n> -\t\tstruct {\n> -\t\t\tdouble red;\n> -\t\t\tdouble green;\n> -\t\t\tdouble blue;\n> -\t\t} gains;\n> -\n> +\t\tRGB gains;\n> \t\tbool autoEnabled;\n> \t} awb;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BA1FC32EA\n\tfor ;\n\tMon, 18 Nov 2024 13:49:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B01E2658D4;\n\tMon, 18 Nov 2024 14:49:36 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D068960532\n\tfor ;\n\tMon, 18 Nov 2024 14:49:34 +0100 (CET)","from mail-wr1-f69.google.com (mail-wr1-f69.google.com\n\t[209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-348-xNISfqITNLWWKPE44KNwDg-1; Mon, 18 Nov 2024 08:49:31 -0500","by mail-wr1-f69.google.com with SMTP id\n\tffacd0b85a97d-382428c257eso653237f8f.0\n\tfor ;\n\tMon, 18 Nov 2024 05:49:31 -0800 (PST)","from nuthatch ([2a00:102a:400a:489a:ffe9:aa41:63cd:fc2b])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-382462dbb5esm3578997f8f.52.2024.11.18.05.49.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 18 Nov 2024 05:49:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"I3OB4q9j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1731937773;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Zh+FDIhZePzBOo1vYwW7PvxNZKccGxiblHo6u1mZmHo=;\n\tb=I3OB4q9j5Sm0UcYnW5Mh+c1j4xoo1QCTcsBH6Cjf1KDffqCFwkdE8kgB6xaoOBeSWqn4nA\n\tDA0bp0VrWMBI8VUKBOdUIefjWp+mORVxyPrf2uVSD5S1UUMIK2zlNYk26M/Bzz7QAq6cQU\n\tUILhN889S9hqpYw+2PzPs+I16u9Gs5o=","X-MC-Unique":"xNISfqITNLWWKPE44KNwDg-1","X-Mimecast-MFC-AGG-ID":"xNISfqITNLWWKPE44KNwDg","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1731937770; x=1732542570;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Zh+FDIhZePzBOo1vYwW7PvxNZKccGxiblHo6u1mZmHo=;\n\tb=onxqNu/8YbWBydqjwfWIsivKu61jgZpaaYpyaHWN3ifunZlVjG9rP1eMTi9+rGRmSB\n\t+c5d841fx0Mm58XVN3xva/S9mggZ4Aj86/AiDAZswZxHTu+pwuT4cazQiPb8GamWR80Z\n\trcTE7wPIUcmXU0j8Fsd2IEu6FuBie93GnbTX/6HkTd8TRXa3jUmyIVBvs3vv0SYvCyRb\n\tliZl9UWxLAMmLQgmmYgWiJF4w6RVk+5NIrkVPyuVPzhoNamUQCkZLxNOSZkSq89a2S5i\n\tNNWYdHAvAlWpxxoZkH14ZkK/uh1PgxJiSAqKzvkbKqasBZbd1V1QUds6uXAs8PabKNTH\n\tBj1g==","X-Gm-Message-State":"AOJu0Yw7MXYT7dxBw/a+hZCIZhZ0NlXASo2iZIKi3wOfOTf+V+7mUELK\n\t41n2OXe8T6iq7w6kmgNYiIvYzcI9qk/ewnXFHjMWO01sQJw9GGscj6jHIbWQYROew3Ba5pnwBGZ\n\tP4b4UrKdmZTRJVqRnAiFG6QtAr1aZHH/6g3L/K4UGPZnAbBuVjjWVuijbnjNiNS7X5TCGR42eWj\n\tvdeTMTMge+M5TOR2veM3Qfr3fehT1Ej30b0TL/iU+KVcgLEZTEuWlKUmU=","X-Received":["by 2002:adf:e187:0:b0:382:6d3:407b with SMTP id\n\tffacd0b85a97d-38225ab98ecmr10126994f8f.59.1731937770056; \n\tMon, 18 Nov 2024 05:49:30 -0800 (PST)","by 2002:adf:e187:0:b0:382:6d3:407b with SMTP id\n\tffacd0b85a97d-38225ab98ecmr10126973f8f.59.1731937769580; \n\tMon, 18 Nov 2024 05:49:29 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IFojD6zAK9hlW8eZZR78Vcq9PVC84z6av+SlghK7jR3r984RbGL79W1xCpm8VvIxlGoWZowqw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 11/12] ipa: rkisp1: awb: Use RGB class to store\n\tcolour gains","In-Reply-To":"<20241118000738.18977-12-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Mon, 18 Nov 2024 02:07:37 +0200\")","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>\n\t<20241118000738.18977-12-laurent.pinchart@ideasonboard.com>","Date":"Mon, 18 Nov 2024 14:49:27 +0100","Message-ID":"<87r078hct4.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"JVY33pUZgDYhGEmz1Hk6HgP9l3cdZgK_tj136QgYpIM_1731937771","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":32233,"web_url":"https://patchwork.libcamera.org/comment/32233/","msgid":"<20241118143300.GQ31681@pendragon.ideasonboard.com>","date":"2024-11-18T14:33:00","subject":"Re: [RFC PATCH v2 11/12] ipa: rkisp1: awb: Use RGB class to store\n\tcolour gains","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nOn Mon, Nov 18, 2024 at 02:49:27PM +0100, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> \n> > Replace the individual colour gains with instances of the RGB\n> > class. This simplifies the code that performs calculations on the gains.\n> \n> Nice, thank you.\n> \n> Reviewed-by: Milan Zamazal \n> \n> (Some very minor comments below.)\n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/ipa/rkisp1/algorithms/awb.cpp | 102 ++++++++++++------------------\n> > src/ipa/rkisp1/algorithms/awb.h | 2 +-\n> > src/ipa/rkisp1/ipa_context.cpp | 31 +--------\n> > src/ipa/rkisp1/ipa_context.h | 20 ++----\n> > 4 files changed, 48 insertions(+), 107 deletions(-)\n> >\n> > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> > index b3c00bef9b7e..1c572055acdd 100644\n> > --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> > @@ -45,12 +45,8 @@ Awb::Awb()\n> > int Awb::configure(IPAContext &context,\n> > \t\t const IPACameraSensorInfo &configInfo)\n> > {\n> > -\tcontext.activeState.awb.gains.manual.red = 1.0;\n> > -\tcontext.activeState.awb.gains.manual.blue = 1.0;\n> > -\tcontext.activeState.awb.gains.manual.green = 1.0;\n> > -\tcontext.activeState.awb.gains.automatic.red = 1.0;\n> > -\tcontext.activeState.awb.gains.automatic.blue = 1.0;\n> > -\tcontext.activeState.awb.gains.automatic.green = 1.0;\n> > +\tcontext.activeState.awb.gains.manual = RGB({ 1.0, 1.0, 1.0 });\n> > +\tcontext.activeState.awb.gains.automatic = RGB({ 1.0, 1.0, 1.0 });\n> > \tcontext.activeState.awb.autoEnabled = true;\n> > \n> > \t/*\n> > @@ -87,21 +83,17 @@ void Awb::queueRequest(IPAContext &context,\n> > \n> > \tconst auto &colourGains = controls.get(controls::ColourGains);\n> > \tif (colourGains && !awb.autoEnabled) {\n> > -\t\tawb.gains.manual.red = (*colourGains)[0];\n> > -\t\tawb.gains.manual.blue = (*colourGains)[1];\n> > +\t\tawb.gains.manual.r() = (*colourGains)[0];\n> > +\t\tawb.gains.manual.b() = (*colourGains)[1];\n> > \n> > \t\tLOG(RkISP1Awb, Debug)\n> > -\t\t\t<< \"Set colour gains to red: \" << awb.gains.manual.red\n> > -\t\t\t<< \", blue: \" << awb.gains.manual.blue;\n> > +\t\t\t<< \"Set colour gains to \" << awb.gains.manual;\n> > \t}\n> > \n> > \tframeContext.awb.autoEnabled = awb.autoEnabled;\n> > \n> > -\tif (!awb.autoEnabled) {\n> > -\t\tframeContext.awb.gains.red = awb.gains.manual.red;\n> > -\t\tframeContext.awb.gains.green = 1.0;\n> > -\t\tframeContext.awb.gains.blue = awb.gains.manual.blue;\n> > -\t}\n> > +\tif (!awb.autoEnabled)\n> > +\t\tframeContext.awb.gains = awb.gains.manual;\n> > }\n> > \n> > /**\n> > @@ -114,19 +106,16 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> > \t * This is the latest time we can read the active state. This is the\n> > \t * most up-to-date automatic values we can read.\n> > \t */\n> > -\tif (frameContext.awb.autoEnabled) {\n> > -\t\tframeContext.awb.gains.red = context.activeState.awb.gains.automatic.red;\n> > -\t\tframeContext.awb.gains.green = context.activeState.awb.gains.automatic.green;\n> > -\t\tframeContext.awb.gains.blue = context.activeState.awb.gains.automatic.blue;\n> > -\t}\n> > +\tif (frameContext.awb.autoEnabled)\n> > +\t\tframeContext.awb.gains = context.activeState.awb.gains.automatic;\n> > \n> > \tauto gainConfig = params->block();\n> > \tgainConfig.setEnabled(true);\n> > \n> > -\tgainConfig->gain_green_b = std::clamp(256 * frameContext.awb.gains.green, 0, 0x3ff);\n> > -\tgainConfig->gain_blue = std::clamp(256 * frameContext.awb.gains.blue, 0, 0x3ff);\n> > -\tgainConfig->gain_red = std::clamp(256 * frameContext.awb.gains.red, 0, 0x3ff);\n> > -\tgainConfig->gain_green_r = std::clamp(256 * frameContext.awb.gains.green, 0, 0x3ff);\n> > +\tgainConfig->gain_green_b = std::clamp(256 * frameContext.awb.gains.g(), 0, 0x3ff);\n> > +\tgainConfig->gain_blue = std::clamp(256 * frameContext.awb.gains.b(), 0, 0x3ff);\n> > +\tgainConfig->gain_red = std::clamp(256 * frameContext.awb.gains.r(), 0, 0x3ff);\n> > +\tgainConfig->gain_green_r = std::clamp(256 * frameContext.awb.gains.g(), 0, 0x3ff);\n> > \n> > \t/* If we have already set the AWB measurement parameters, return. */\n> > \tif (frame > 0)\n> > @@ -178,12 +167,12 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n> > \t}\n> > }\n> > \n> > -uint32_t Awb::estimateCCT(double red, double green, double blue)\n> > +uint32_t Awb::estimateCCT(const RGB &rgb)\n> \n> Note this is in conflict with a recently posted patch moving this to\n> the common IPA.\n\nYes, I know. I don't mind the order in which the series will be merged.\n\n> > {\n> > \t/* Convert the RGB values to CIE tristimulus values (XYZ) */\n> > -\tdouble X = (-0.14282) * (red) + (1.54924) * (green) + (-0.95641) * (blue);\n> > -\tdouble Y = (-0.32466) * (red) + (1.57837) * (green) + (-0.73191) * (blue);\n> > -\tdouble Z = (-0.68202) * (red) + (0.77073) * (green) + (0.56332) * (blue);\n> > +\tdouble X = -0.14282 * rgb.r() + 1.54924 * rgb.g() - 0.95641 * rgb.b();\n> > +\tdouble Y = -0.32466 * rgb.r() + 1.57837 * rgb.g() - 0.73191 * rgb.b();\n> > +\tdouble Z = -0.68202 * rgb.r() + 0.77073 * rgb.g() + 0.56332 * rgb.b();\n> \n> Does this demonstrate that operator* would be more handy as a dot product?\n\nI don't think so, but see patch 12/12 where this code gets much\nimproved.\n\n> > \t/* Calculate the normalized chromaticity values */\n> > \tdouble x = X / (X + Y + Z);\n> > @@ -206,14 +195,12 @@ void Awb::process(IPAContext &context,\n> > \tconst rkisp1_cif_isp_stat *params = &stats->params;\n> > \tconst rkisp1_cif_isp_awb_stat *awb = ¶ms->awb;\n> > \tIPAActiveState &activeState = context.activeState;\n> > -\tdouble greenMean;\n> > -\tdouble redMean;\n> > -\tdouble blueMean;\n> > +\tRGB rgbMeans;\n> > \n> > \tmetadata.set(controls::AwbEnable, frameContext.awb.autoEnabled);\n> > \tmetadata.set(controls::ColourGains, {\n> > -\t\t\tstatic_cast(frameContext.awb.gains.red),\n> > -\t\t\tstatic_cast(frameContext.awb.gains.blue)\n> > +\t\t\tstatic_cast(frameContext.awb.gains.r()),\n> > +\t\t\tstatic_cast(frameContext.awb.gains.b())\n> > \t\t});\n> > \tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> > \n> > @@ -223,9 +210,9 @@ void Awb::process(IPAContext &context,\n> > \t}\n> > \n> > \tif (rgbMode_) {\n> > -\t\tgreenMean = awb->awb_mean[0].mean_y_or_g;\n> > -\t\tredMean = awb->awb_mean[0].mean_cr_or_r;\n> > -\t\tblueMean = awb->awb_mean[0].mean_cb_or_b;\n> > +\t\trgbMeans.r() = awb->awb_mean[0].mean_cr_or_r;\n> > +\t\trgbMeans.g() = awb->awb_mean[0].mean_y_or_g;\n> > +\t\trgbMeans.b() = awb->awb_mean[0].mean_cb_or_b;\n> > \t} else {\n> > \t\t/* Get the YCbCr mean values */\n> > \t\tdouble yMean = awb->awb_mean[0].mean_y_or_g;\n> > @@ -247,9 +234,9 @@ void Awb::process(IPAContext &context,\n> > \t\tyMean -= 16;\n> > \t\tcbMean -= 128;\n> > \t\tcrMean -= 128;\n> > -\t\tredMean = 1.1636 * yMean - 0.0623 * cbMean + 1.6008 * crMean;\n> > -\t\tgreenMean = 1.1636 * yMean - 0.4045 * cbMean - 0.7949 * crMean;\n> > -\t\tblueMean = 1.1636 * yMean + 1.9912 * cbMean - 0.0250 * crMean;\n> > +\t\trgbMeans.r() = 1.1636 * yMean - 0.0623 * cbMean + 1.6008 * crMean;\n> > +\t\trgbMeans.g() = 1.1636 * yMean - 0.4045 * cbMean - 0.7949 * crMean;\n> > +\t\trgbMeans.b() = 1.1636 * yMean + 1.9912 * cbMean - 0.0250 * crMean;\n> > \n> > \t\t/*\n> > \t\t * Due to hardware rounding errors in the YCbCr means, the\n> > @@ -257,9 +244,7 @@ void Awb::process(IPAContext &context,\n> > \t\t * negative gains, messing up calculation. Prevent this by\n> > \t\t * clamping the means to positive values.\n> > \t\t */\n> > -\t\tredMean = std::max(redMean, 0.0);\n> > -\t\tgreenMean = std::max(greenMean, 0.0);\n> > -\t\tblueMean = std::max(blueMean, 0.0);\n> > +\t\trgbMeans = rgbMeans.max(0.0);\n> > \t}\n> > \n> > \t/*\n> > @@ -267,19 +252,17 @@ void Awb::process(IPAContext &context,\n> > \t * divide by the gains that were used to get the raw means from the\n> > \t * sensor.\n> > \t */\n> > -\tredMean /= frameContext.awb.gains.red;\n> > -\tgreenMean /= frameContext.awb.gains.green;\n> > -\tblueMean /= frameContext.awb.gains.blue;\n> > +\trgbMeans /= frameContext.awb.gains;\n> > \n> > \t/*\n> > \t * If the means are too small we don't have enough information to\n> > \t * meaningfully calculate gains. Freeze the algorithm in that case.\n> > \t */\n> > -\tif (redMean < kMeanMinThreshold && greenMean < kMeanMinThreshold &&\n> > -\t blueMean < kMeanMinThreshold)\n> > +\tif (rgbMeans.r() < kMeanMinThreshold && rgbMeans.g() < kMeanMinThreshold &&\n> > +\t rgbMeans.b() < kMeanMinThreshold)\n> \n> Would it be worth to define also operator< ?\n\nWe could experiment with that, as long as it doesn't hinder readability.\nOnly for comparison between a vector and a scalar though.\n\n> > \t\treturn;\n> > \n> > -\tactiveState.awb.temperatureK = estimateCCT(redMean, greenMean, blueMean);\n> > +\tactiveState.awb.temperatureK = estimateCCT(rgbMeans);\n> > \n> > \t/* Metadata shall contain the up to date measurement */\n> > \tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n> > @@ -289,8 +272,11 @@ void Awb::process(IPAContext &context,\n> > \t * gain is hardcoded to 1.0. Avoid divisions by zero by clamping the\n> > \t * divisor to a minimum value of 1.0.\n> > \t */\n> > -\tdouble redGain = greenMean / std::max(redMean, 1.0);\n> > -\tdouble blueGain = greenMean / std::max(blueMean, 1.0);\n> > +\tRGB gains({\n> > +\t\trgbMeans.g() / std::max(rgbMeans.r(), 1.0),\n> > +\t\t1.0,\n> > +\t\trgbMeans.g() / std::max(rgbMeans.b(), 1.0)\n> > +\t});\n> > \n> > \t/*\n> > \t * Clamp the gain values to the hardware, which expresses gains as Q2.8\n> > @@ -298,24 +284,18 @@ void Awb::process(IPAContext &context,\n> > \t * divisions by zero when computing the raw means in subsequent\n> > \t * iterations.\n> > \t */\n> > -\tredGain = std::clamp(redGain, 1.0 / 256, 1023.0 / 256);\n> > -\tblueGain = std::clamp(blueGain, 1.0 / 256, 1023.0 / 256);\n> > +\tgains = gains.max(1.0 / 256).min(1023.0 / 256);\n> > \n> > \t/* Filter the values to avoid oscillations. */\n> > \tdouble speed = 0.2;\n> > -\tredGain = speed * redGain + (1 - speed) * activeState.awb.gains.automatic.red;\n> > -\tblueGain = speed * blueGain + (1 - speed) * activeState.awb.gains.automatic.blue;\n> > +\tgains = gains * speed + activeState.awb.gains.automatic * (1 - speed);\n> > \n> > -\tactiveState.awb.gains.automatic.red = redGain;\n> > -\tactiveState.awb.gains.automatic.blue = blueGain;\n> > -\tactiveState.awb.gains.automatic.green = 1.0;\n> > +\tactiveState.awb.gains.automatic = gains;\n> > \n> > \tLOG(RkISP1Awb, Debug)\n> > \t\t<< std::showpoint\n> > -\t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> > -\t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> > -\t\t<< activeState.awb.gains.automatic.green << \", \"\n> > -\t\t<< activeState.awb.gains.automatic.blue << \"], temp \"\n> > +\t\t<< \"Means \" << rgbMeans << \", gains \"\n> > +\t\t<< activeState.awb.gains.automatic << \", temp \"\n> > \t\t<< activeState.awb.temperatureK << \"K\";\n> > }\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/awb.h b/src/ipa/rkisp1/algorithms/awb.h\n> > index b3b2c0bbb9ae..058c0fc53490 100644\n> > --- a/src/ipa/rkisp1/algorithms/awb.h\n> > +++ b/src/ipa/rkisp1/algorithms/awb.h\n> > @@ -32,7 +32,7 @@ public:\n> > \t\t ControlList &metadata) override;\n> > \n> > private:\n> > -\tuint32_t estimateCCT(double red, double green, double blue);\n> > +\tuint32_t estimateCCT(const RGB &rgb);\n> > \n> > \tbool rgbMode_;\n> > };\n> > diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> > index 14d0c02a2b32..8f545cd76d52 100644\n> > --- a/src/ipa/rkisp1/ipa_context.cpp\n> > +++ b/src/ipa/rkisp1/ipa_context.cpp\n> > @@ -188,30 +188,12 @@ namespace libcamera::ipa::rkisp1 {\n> > * \\struct IPAActiveState::awb.gains\n> > * \\brief White balance gains\n> > *\n> > - * \\struct IPAActiveState::awb.gains.manual\n> > + * \\var IPAActiveState::awb.gains.manual\n> > * \\brief Manual white balance gains (set through requests)\n> > *\n> > - * \\var IPAActiveState::awb.gains.manual.red\n> > - * \\brief Manual white balance gain for R channel\n> > - *\n> > - * \\var IPAActiveState::awb.gains.manual.green\n> > - * \\brief Manual white balance gain for G channel\n> > - *\n> > - * \\var IPAActiveState::awb.gains.manual.blue\n> > - * \\brief Manual white balance gain for B channel\n> > - *\n> > - * \\struct IPAActiveState::awb.gains.automatic\n> > + * \\var IPAActiveState::awb.gains.automatic\n> > * \\brief Automatic white balance gains (computed by the algorithm)\n> > *\n> > - * \\var IPAActiveState::awb.gains.automatic.red\n> > - * \\brief Automatic white balance gain for R channel\n> > - *\n> > - * \\var IPAActiveState::awb.gains.automatic.green\n> > - * \\brief Automatic white balance gain for G channel\n> > - *\n> > - * \\var IPAActiveState::awb.gains.automatic.blue\n> > - * \\brief Automatic white balance gain for B channel\n> > - *\n> > * \\var IPAActiveState::awb.temperatureK\n> > * \\brief Estimated color temperature\n> > *\n> > @@ -333,15 +315,6 @@ namespace libcamera::ipa::rkisp1 {\n> > * \\struct IPAFrameContext::awb.gains\n> > * \\brief White balance gains\n> > *\n> > - * \\var IPAFrameContext::awb.gains.red\n> > - * \\brief White balance gain for R channel\n> > - *\n> > - * \\var IPAFrameContext::awb.gains.green\n> > - * \\brief White balance gain for G channel\n> > - *\n> > - * \\var IPAFrameContext::awb.gains.blue\n> > - * \\brief White balance gain for B channel\n> > - *\n> > * \\var IPAFrameContext::awb.temperatureK\n> > * \\brief Estimated color temperature\n> > *\n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index 7b93a9e9461d..b4dec0c3288d 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -25,6 +25,7 @@\n> > #include \n> > #include \n> > #include \n> > +#include \n> > \n> > namespace libcamera {\n> > \n> > @@ -87,16 +88,8 @@ struct IPAActiveState {\n> > \n> > \tstruct {\n> > \t\tstruct {\n> > -\t\t\tstruct {\n> > -\t\t\t\tdouble red;\n> > -\t\t\t\tdouble green;\n> > -\t\t\t\tdouble blue;\n> > -\t\t\t} manual;\n> > -\t\t\tstruct {\n> > -\t\t\t\tdouble red;\n> > -\t\t\t\tdouble green;\n> > -\t\t\t\tdouble blue;\n> > -\t\t\t} automatic;\n> > +\t\t\tRGB manual;\n> > +\t\t\tRGB automatic;\n> > \t\t} gains;\n> > \n> > \t\tunsigned int temperatureK;\n> > @@ -140,12 +133,7 @@ struct IPAFrameContext : public FrameContext {\n> > \t} agc;\n> > \n> > \tstruct {\n> > -\t\tstruct {\n> > -\t\t\tdouble red;\n> > -\t\t\tdouble green;\n> > -\t\t\tdouble blue;\n> > -\t\t} gains;\n> > -\n> > +\t\tRGB gains;\n> > \t\tbool autoEnabled;\n> > \t} awb;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A84CC32EA\n\tfor ;\n\tMon, 18 Nov 2024 14:33:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 616B2658DA;\n\tMon, 18 Nov 2024 15:33:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B063C60532\n\tfor ;\n\tMon, 18 Nov 2024 15:33:09 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B31F0A57;\n\tMon, 18 Nov 2024 15:32:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IWCpfjuo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1731940372;\n\tbh=bTvaUrLTSAxcbaVZwXCvg6JHJkJpOzyelf0pqHwC2PU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IWCpfjuoQz3iEygFhfZOwKLGuhYyhdSMpZShGG0zqE7XlTHam6nmoy7b3hw5zSWKf\n\t+CkxFSNvGJPTAu2hqS7opt4q3hckOxRI+n+/niQ1xGmA2LR4GJ3Uv61IqniIc63JJz\n\tuFVspPWuvt0gFkVPlmb3YaQsLyIgtLnMVFBqPYUU=","Date":"Mon, 18 Nov 2024 16:33:00 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 11/12] ipa: rkisp1: awb: Use RGB class to store\n\tcolour gains","Message-ID":"<20241118143300.GQ31681@pendragon.ideasonboard.com>","References":"<20241118000738.18977-1-laurent.pinchart@ideasonboard.com>\n\t<20241118000738.18977-12-laurent.pinchart@ideasonboard.com>\n\t<87r078hct4.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87r078hct4.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]